github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-13 21:54:17 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #2586] [PM-2748] Refactoring locator strategy for Cipher Details page #3665

New Issue
Closed
opened 2025-11-26 23:35:53 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:35:53 -06:00
Owner
Copy Link

Original Pull Request: https://github.com/bitwarden/android/pull/2586

State: closed
Merged: Yes

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

We changed the strategy we followed on CipherDetailsPage due to some changes on our side. This PR replaces the specific locators we added for static locators:

  • ItemRow for each Cipher field row
  • ItemName for each Cipher field name
  • ItemValue for each Cipher field value

Code changes

  • CipherDetailsPage.xaml: Changing automationIDs strategy

Screenshots

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
**Original Pull Request:** https://github.com/bitwarden/android/pull/2586 **State:** closed **Merged:** Yes --- ## Type of change - [ ] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective We changed the strategy we followed on CipherDetailsPage due to some changes on our side. This PR replaces the specific locators we added for static locators: * `ItemRow` for each Cipher field row * `ItemName` for each Cipher field name * `ItemValue` for each Cipher field value ## Code changes * **CipherDetailsPage.xaml:** Changing automationIDs strategy ## Screenshots <!--Required for any UI changes. Delete if not applicable--> ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team
GiteaMirror added the pull-request label 2025-11-26 23:35:53 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3665
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?