github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-06 07:48:22 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #2586] [MERGED] [PM-2748] Refactoring locator strategy for Cipher Details page #40755

New Issue
Closed
opened 2026-04-23 19:34:50 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 19:34:50 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2586
Author: @ifernandezdiaz
Created: 6/24/2023
Status: ✅ Merged
Merged: 6/26/2023
Merged by: @ifernandezdiaz

Base: master ← Head: PM-2748/updating-ID-strategy-CipherDetailsPage

📝 Commits (2)

  • 5a6fede Refactoring locator strategy for Cipher Details page
  • 66b735c Fixing extra spaces

📊 Changes

1 file changed (+107 additions, -72 deletions)

View changed files

📝 src/App/Pages/Vault/CipherDetailsPage.xaml (+107 -72)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

We changed the strategy we followed on CipherDetailsPage due to some changes on our side. This PR replaces the specific locators we added for static locators:

  • ItemRow for each Cipher field row
  • ItemName for each Cipher field name
  • ItemValue for each Cipher field value

Code changes

  • CipherDetailsPage.xaml: Changing automationIDs strategy

Screenshots

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2586 **Author:** [@ifernandezdiaz](https://github.com/ifernandezdiaz) **Created:** 6/24/2023 **Status:** ✅ Merged **Merged:** 6/26/2023 **Merged by:** [@ifernandezdiaz](https://github.com/ifernandezdiaz) **Base:** `master` ← **Head:** `PM-2748/updating-ID-strategy-CipherDetailsPage` --- ### 📝 Commits (2) - [`5a6fede`](https://github.com/bitwarden/android/commit/5a6fedec5745b4c9078d256347e9b8d3993f5d5b) Refactoring locator strategy for Cipher Details page - [`66b735c`](https://github.com/bitwarden/android/commit/66b735c83b6fb4d9e67a82fe58dfd4a76c7cb683) Fixing extra spaces ### 📊 Changes **1 file changed** (+107 additions, -72 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Vault/CipherDetailsPage.xaml` (+107 -72) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective We changed the strategy we followed on CipherDetailsPage due to some changes on our side. This PR replaces the specific locators we added for static locators: * `ItemRow` for each Cipher field row * `ItemName` for each Cipher field name * `ItemValue` for each Cipher field value ## Code changes * **CipherDetailsPage.xaml:** Changing automationIDs strategy ## Screenshots <!--Required for any UI changes. Delete if not applicable--> ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 19:34:50 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#40755
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?