[PR #2458] [MERGED] Revert "[PM-1615] Fix cipher options not working in lists due to binding failing" #3576

Closed
opened 2025-11-26 23:34:38 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2458
Author: @fedemkr
Created: 3/31/2023
Status: Merged
Merged: 3/31/2023
Merged by: @fedemkr

Base: masterHead: revert-2456-PM-1615-fix-cipher-options-not-working


📝 Commits (1)

  • 00c3373 Revert "PM-1615 Fix cipher options not working in lists due to binding failing due to type mismatch. Updated GroupingsPageViewModel to new way of calling as well (#2456)"

📊 Changes

2 files changed (+13 additions, -8 deletions)

View changed files

📝 src/App/Controls/CipherViewCell/CipherViewCell.xaml.cs (+3 -4)
📝 src/App/Pages/Vault/GroupingsPage/GroupingsPageViewModel.cs (+10 -4)

📄 Description

Reverts bitwarden/mobile#2456 so QA can test before merging.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2458 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 3/31/2023 **Status:** ✅ Merged **Merged:** 3/31/2023 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `master` ← **Head:** `revert-2456-PM-1615-fix-cipher-options-not-working` --- ### 📝 Commits (1) - [`00c3373`](https://github.com/bitwarden/android/commit/00c337348d0bc6501e178510a3e6a17b21e3b471) Revert "PM-1615 Fix cipher options not working in lists due to binding failing due to type mismatch. Updated GroupingsPageViewModel to new way of calling as well (#2456)" ### 📊 Changes **2 files changed** (+13 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Controls/CipherViewCell/CipherViewCell.xaml.cs` (+3 -4) 📝 `src/App/Pages/Vault/GroupingsPage/GroupingsPageViewModel.cs` (+10 -4) </details> ### 📄 Description Reverts bitwarden/mobile#2456 so QA can test before merging. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:34:38 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3576