github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-21 13:52:07 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

PM-17958: Remove language supporting text (#4688)

Browse Source
This commit is contained in:
David Perez
2025-02-04 11:22:23 -06:00
committed by GitHub
parent 5e29df5f30
commit de7416d96e
3 changed files with 3 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/appearance/AppearanceScreen.kt
View File

@@ -139,7 +139,6 @@ private fun LanguageSelectionRow(
)
languageChangedDialogOption = selectedLanguage
},
supportingText = stringResource(id = R.string.language_description),
cardStyle = CardStyle.Full,
modifier = modifier,
)

1
app/src/main/res/values/strings.xml
View File

@@ -793,7 +793,6 @@ Do you want to switch to this account?</string>
<string name="no_pending_requests">No pending requests</string>
<string name="enable_camer_permission_to_use_the_scanner">Enable camera permission to use the scanner</string>
<string name="language">Language</string>
<string name="language_description">Change the application\'s language</string>
<string name="language_change_x_description">The language has been changed to %1$s. Please restart the app to see the change</string>
<string name="language_change_requires_app_restart">Language change requires app restart</string>
<string name="default_system">Default (System)</string>

12
app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/settings/appearance/AppearanceScreenTest.kt
View File

@@ -54,9 +54,7 @@ class AppearanceScreenTest : BaseComposeTest() {
@Test
fun `on language row click should display language selection dialog`() {
composeTestRule
.onNodeWithContentDescription(
label = "Default (System). Language. Change the application's language",
)
.onNodeWithContentDescription(label = "Default (System). Language")
.performScrollTo()
.performClick()
composeTestRule
@@ -69,9 +67,7 @@ class AppearanceScreenTest : BaseComposeTest() {
fun `on language selection dialog item click should send LanguageChange and show dialog`() {
// Clicking the Language row shows the language selection dialog
composeTestRule
.onNodeWithContentDescription(
label = "Default (System). Language. Change the application's language",
)
.onNodeWithContentDescription(label = "Default (System). Language")
.performScrollTo()
.performClick()
// Selecting a language dismisses this dialog and displays the confirmation
@@ -107,9 +103,7 @@ class AppearanceScreenTest : BaseComposeTest() {
@Test
fun `on language selection dialog cancel click should dismiss dialog`() {
composeTestRule
.onNodeWithContentDescription(
label = "Default (System). Language. Change the application's language",
)
.onNodeWithContentDescription(label = "Default (System). Language")
.performScrollTo()
.performClick()
composeTestRule