From de7416d96e298dc459a0b1bea7818812dcf9a05e Mon Sep 17 00:00:00 2001 From: David Perez Date: Tue, 4 Feb 2025 11:22:23 -0600 Subject: [PATCH] PM-17958: Remove language supporting text (#4688) --- .../feature/settings/appearance/AppearanceScreen.kt | 1 - app/src/main/res/values/strings.xml | 1 - .../settings/appearance/AppearanceScreenTest.kt | 12 +++--------- 3 files changed, 3 insertions(+), 11 deletions(-) diff --git a/app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/appearance/AppearanceScreen.kt b/app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/appearance/AppearanceScreen.kt index 8f401adb0f..146c139cdb 100644 --- a/app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/appearance/AppearanceScreen.kt +++ b/app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/appearance/AppearanceScreen.kt @@ -139,7 +139,6 @@ private fun LanguageSelectionRow( ) languageChangedDialogOption = selectedLanguage }, - supportingText = stringResource(id = R.string.language_description), cardStyle = CardStyle.Full, modifier = modifier, ) diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index 5a9b8fdecf..4b98de2a46 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -793,7 +793,6 @@ Do you want to switch to this account? No pending requests Enable camera permission to use the scanner Language - Change the application\'s language The language has been changed to %1$s. Please restart the app to see the change Language change requires app restart Default (System) diff --git a/app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/settings/appearance/AppearanceScreenTest.kt b/app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/settings/appearance/AppearanceScreenTest.kt index 719ffbe5df..aefc6ce69a 100644 --- a/app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/settings/appearance/AppearanceScreenTest.kt +++ b/app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/settings/appearance/AppearanceScreenTest.kt @@ -54,9 +54,7 @@ class AppearanceScreenTest : BaseComposeTest() { @Test fun `on language row click should display language selection dialog`() { composeTestRule - .onNodeWithContentDescription( - label = "Default (System). Language. Change the application's language", - ) + .onNodeWithContentDescription(label = "Default (System). Language") .performScrollTo() .performClick() composeTestRule @@ -69,9 +67,7 @@ class AppearanceScreenTest : BaseComposeTest() { fun `on language selection dialog item click should send LanguageChange and show dialog`() { // Clicking the Language row shows the language selection dialog composeTestRule - .onNodeWithContentDescription( - label = "Default (System). Language. Change the application's language", - ) + .onNodeWithContentDescription(label = "Default (System). Language") .performScrollTo() .performClick() // Selecting a language dismisses this dialog and displays the confirmation @@ -107,9 +103,7 @@ class AppearanceScreenTest : BaseComposeTest() { @Test fun `on language selection dialog cancel click should dismiss dialog`() { composeTestRule - .onNodeWithContentDescription( - label = "Default (System). Language. Change the application's language", - ) + .onNodeWithContentDescription(label = "Default (System). Language") .performScrollTo() .performClick() composeTestRule