github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-25 23:46:58 -05:00
Code Issues 1.5k Packages Projects Releases 125 Wiki Activity

BIT-1679: Adding element IDs for view item screen (#932)

Browse Source
This commit is contained in:
Joshua Queen
2024-02-01 02:42:15 -05:00
committed by Álison Fernandes
parent c5e8faccc3
commit c9eca38e08
5 changed files with 12 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/attachments/AttachmentsContent.kt
View File

@@ -162,6 +162,7 @@ private fun AttachmentListEntry(
color = MaterialTheme.colorScheme.outlineVariant,
)
.defaultMinSize(minHeight = 56.dp)
.semantics { testTag = "CipherAttachment" }
.padding(vertical = 8.dp)
.then(modifier),
verticalAlignment = Alignment.CenterVertically,

3
app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemCardContent.kt
View File

@@ -11,6 +11,8 @@ import androidx.compose.runtime.Composable
import androidx.compose.ui.Modifier
import androidx.compose.ui.res.painterResource
import androidx.compose.ui.res.stringResource
import androidx.compose.ui.semantics.semantics
import androidx.compose.ui.semantics.testTag
import androidx.compose.ui.unit.dp
import com.x8bit.bitwarden.R
import com.x8bit.bitwarden.ui.platform.components.BitwardenIconButtonWithResource
@@ -231,6 +233,7 @@ fun VaultItemCardContent(
header = "${stringResource(id = R.string.date_updated)}: ",
text = commonState.lastUpdated,
modifier = Modifier
.semantics { testTag = "ItemRow" }
.fillMaxWidth()
.padding(horizontal = 16.dp),
)

3
app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemIdentityContent.kt
View File

@@ -10,6 +10,8 @@ import androidx.compose.foundation.lazy.items
import androidx.compose.runtime.Composable
import androidx.compose.ui.Modifier
import androidx.compose.ui.res.stringResource
import androidx.compose.ui.semantics.semantics
import androidx.compose.ui.semantics.testTag
import androidx.compose.ui.unit.dp
import com.x8bit.bitwarden.R
import com.x8bit.bitwarden.ui.platform.components.BitwardenListHeaderText
@@ -261,6 +263,7 @@ fun VaultItemIdentityContent(
header = "${stringResource(id = R.string.date_updated)}: ",
text = commonState.lastUpdated,
modifier = Modifier
.semantics { testTag = "ItemRow" }
.fillMaxWidth()
.padding(horizontal = 16.dp),
)

3
app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemLoginContent.kt
View File

@@ -16,6 +16,7 @@ import androidx.compose.ui.Modifier
import androidx.compose.ui.res.painterResource
import androidx.compose.ui.res.stringResource
import androidx.compose.ui.semantics.semantics
import androidx.compose.ui.semantics.testTag
import androidx.compose.ui.unit.dp
import com.x8bit.bitwarden.R
import com.x8bit.bitwarden.ui.platform.components.BitwardenCircularCountdownIndicator
@@ -129,6 +130,7 @@ fun VaultItemLoginContent(
onCopyUriClick = vaultLoginItemTypeHandlers.onCopyUriClick,
onLaunchUriClick = vaultLoginItemTypeHandlers.onLaunchUriClick,
modifier = Modifier
.semantics { testTag = "UriRow" }
.fillMaxWidth()
.padding(horizontal = 16.dp),
)
@@ -207,6 +209,7 @@ fun VaultItemLoginContent(
header = "${stringResource(id = R.string.date_updated)}: ",
text = commonState.lastUpdated,
modifier = Modifier
.semantics { testTag = "ItemRow" }
.fillMaxWidth()
.padding(horizontal = 16.dp),
)

2
app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemSecureNoteContent.kt
View File

@@ -14,6 +14,7 @@ import androidx.compose.runtime.Composable
import androidx.compose.ui.Modifier
import androidx.compose.ui.res.stringResource
import androidx.compose.ui.semantics.semantics
import androidx.compose.ui.semantics.testTag
import androidx.compose.ui.unit.dp
import com.x8bit.bitwarden.R
import com.x8bit.bitwarden.ui.platform.components.BitwardenListHeaderText
@@ -130,6 +131,7 @@ fun VaultItemSecureNoteContent(
Spacer(modifier = Modifier.height(24.dp))
Row(
modifier = Modifier
.semantics { testTag = "ItemRow" }
.fillMaxWidth()
.padding(horizontal = 16.dp)
.semantics(mergeDescendants = true) { },