From c9eca38e086c0ef2c739af051397e6b10034d4a6 Mon Sep 17 00:00:00 2001 From: Joshua Queen <139182194+joshua-livefront@users.noreply.github.com> Date: Thu, 1 Feb 2024 02:42:15 -0500 Subject: [PATCH] BIT-1679: Adding element IDs for view item screen (#932) --- .../ui/vault/feature/attachments/AttachmentsContent.kt | 1 + .../bitwarden/ui/vault/feature/item/VaultItemCardContent.kt | 3 +++ .../ui/vault/feature/item/VaultItemIdentityContent.kt | 3 +++ .../bitwarden/ui/vault/feature/item/VaultItemLoginContent.kt | 3 +++ .../ui/vault/feature/item/VaultItemSecureNoteContent.kt | 2 ++ 5 files changed, 12 insertions(+) diff --git a/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/attachments/AttachmentsContent.kt b/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/attachments/AttachmentsContent.kt index 0daf6519a5..6bd588aff0 100644 --- a/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/attachments/AttachmentsContent.kt +++ b/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/attachments/AttachmentsContent.kt @@ -162,6 +162,7 @@ private fun AttachmentListEntry( color = MaterialTheme.colorScheme.outlineVariant, ) .defaultMinSize(minHeight = 56.dp) + .semantics { testTag = "CipherAttachment" } .padding(vertical = 8.dp) .then(modifier), verticalAlignment = Alignment.CenterVertically, diff --git a/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemCardContent.kt b/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemCardContent.kt index 3b4f2e7d2f..a8982d3b36 100644 --- a/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemCardContent.kt +++ b/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemCardContent.kt @@ -11,6 +11,8 @@ import androidx.compose.runtime.Composable import androidx.compose.ui.Modifier import androidx.compose.ui.res.painterResource import androidx.compose.ui.res.stringResource +import androidx.compose.ui.semantics.semantics +import androidx.compose.ui.semantics.testTag import androidx.compose.ui.unit.dp import com.x8bit.bitwarden.R import com.x8bit.bitwarden.ui.platform.components.BitwardenIconButtonWithResource @@ -231,6 +233,7 @@ fun VaultItemCardContent( header = "${stringResource(id = R.string.date_updated)}: ", text = commonState.lastUpdated, modifier = Modifier + .semantics { testTag = "ItemRow" } .fillMaxWidth() .padding(horizontal = 16.dp), ) diff --git a/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemIdentityContent.kt b/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemIdentityContent.kt index 8e7d31a42b..3d467e5d0c 100644 --- a/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemIdentityContent.kt +++ b/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemIdentityContent.kt @@ -10,6 +10,8 @@ import androidx.compose.foundation.lazy.items import androidx.compose.runtime.Composable import androidx.compose.ui.Modifier import androidx.compose.ui.res.stringResource +import androidx.compose.ui.semantics.semantics +import androidx.compose.ui.semantics.testTag import androidx.compose.ui.unit.dp import com.x8bit.bitwarden.R import com.x8bit.bitwarden.ui.platform.components.BitwardenListHeaderText @@ -261,6 +263,7 @@ fun VaultItemIdentityContent( header = "${stringResource(id = R.string.date_updated)}: ", text = commonState.lastUpdated, modifier = Modifier + .semantics { testTag = "ItemRow" } .fillMaxWidth() .padding(horizontal = 16.dp), ) diff --git a/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemLoginContent.kt b/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemLoginContent.kt index 72db2c72ad..0642323b7b 100644 --- a/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemLoginContent.kt +++ b/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemLoginContent.kt @@ -16,6 +16,7 @@ import androidx.compose.ui.Modifier import androidx.compose.ui.res.painterResource import androidx.compose.ui.res.stringResource import androidx.compose.ui.semantics.semantics +import androidx.compose.ui.semantics.testTag import androidx.compose.ui.unit.dp import com.x8bit.bitwarden.R import com.x8bit.bitwarden.ui.platform.components.BitwardenCircularCountdownIndicator @@ -129,6 +130,7 @@ fun VaultItemLoginContent( onCopyUriClick = vaultLoginItemTypeHandlers.onCopyUriClick, onLaunchUriClick = vaultLoginItemTypeHandlers.onLaunchUriClick, modifier = Modifier + .semantics { testTag = "UriRow" } .fillMaxWidth() .padding(horizontal = 16.dp), ) @@ -207,6 +209,7 @@ fun VaultItemLoginContent( header = "${stringResource(id = R.string.date_updated)}: ", text = commonState.lastUpdated, modifier = Modifier + .semantics { testTag = "ItemRow" } .fillMaxWidth() .padding(horizontal = 16.dp), ) diff --git a/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemSecureNoteContent.kt b/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemSecureNoteContent.kt index abb79bb896..e8ded888b4 100644 --- a/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemSecureNoteContent.kt +++ b/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemSecureNoteContent.kt @@ -14,6 +14,7 @@ import androidx.compose.runtime.Composable import androidx.compose.ui.Modifier import androidx.compose.ui.res.stringResource import androidx.compose.ui.semantics.semantics +import androidx.compose.ui.semantics.testTag import androidx.compose.ui.unit.dp import com.x8bit.bitwarden.R import com.x8bit.bitwarden.ui.platform.components.BitwardenListHeaderText @@ -130,6 +131,7 @@ fun VaultItemSecureNoteContent( Spacer(modifier = Modifier.height(24.dp)) Row( modifier = Modifier + .semantics { testTag = "ItemRow" } .fillMaxWidth() .padding(horizontal = 16.dp) .semantics(mergeDescendants = true) { },