github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-11 20:54:58 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

PM-21351: Clear scemantics on new send button (#5165)

Browse Source
This commit is contained in:
David Perez
2025-05-09 15:51:14 -05:00
committed by GitHub
parent 5037af07c7
commit c5ee389231
1 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/send/SendEmpty.kt
View File

@@ -17,13 +17,15 @@ import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.platform.testTag
import androidx.compose.ui.res.stringResource
import androidx.compose.ui.semantics.clearAndSetSemantics
import androidx.compose.ui.semantics.hideFromAccessibility
import androidx.compose.ui.semantics.semantics
import androidx.compose.ui.semantics.text
import androidx.compose.ui.text.style.TextAlign
import androidx.compose.ui.tooling.preview.Preview
import androidx.compose.ui.unit.dp
import com.x8bit.bitwarden.R
import com.x8bit.bitwarden.ui.platform.base.util.standardHorizontalMargin
import com.x8bit.bitwarden.ui.platform.base.util.toAnnotatedString
import com.x8bit.bitwarden.ui.platform.components.button.BitwardenFilledButton
import com.x8bit.bitwarden.ui.platform.components.card.BitwardenInfoCalloutCard
import com.x8bit.bitwarden.ui.platform.components.util.rememberVectorPainter
@@ -32,6 +34,7 @@ import com.x8bit.bitwarden.ui.platform.theme.BitwardenTheme
/**
* Content for the empty state of the [SendScreen].
*/
@Suppress("LongMethod")
@Composable
fun SendEmpty(
policyDisablesSend: Boolean,
@@ -87,12 +90,16 @@ fun SendEmpty(
Spacer(modifier = Modifier.height(24.dp))
// This button is hidden from accessibility to avoid duplicate voice over with the FAB
val newSendLabel = stringResource(id = R.string.add_a_send)
BitwardenFilledButton(
onClick = onAddItemClick,
label = stringResource(id = R.string.add_a_send),
icon = rememberVectorPainter(R.drawable.ic_plus_small),
modifier = Modifier
.semantics { hideFromAccessibility() }
.clearAndSetSemantics {
text = newSendLabel.toAnnotatedString()
hideFromAccessibility()
}
.standardHorizontalMargin(),
)
Spacer(modifier = Modifier.weight(1F))