github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-12 05:04:17 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4731] [MERGED] PM-18032 Adding a new folder while adding or editing an item. #5165

New Issue
Closed
opened 2025-11-26 23:54:56 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:54:56 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4731
Author: @dseverns-livefront
Created: 2/17/2025
Status: ✅ Merged
Merged: 2/18/2025
Merged by: @dseverns-livefront

Base: main ← Head: PM-180323-select-add-folder-in-edit-item

📝 Commits (7)

📊 Changes

11 files changed (+826 additions, -167 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/bottomsheet/BitwardenModalBottomSheet.kt (+6 -0)
➕ app/src/main/java/com/x8bit/bitwarden/ui/platform/components/button/BitwardenTextSelectionButton.kt (+174 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/dropdown/BitwardenMultiSelectButton.kt (+20 -126)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditItemContent.kt (+3 -7)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditScreen.kt (+181 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModel.kt (+120 -4)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/handlers/VaultAddEditCommonHandlers.kt (+26 -6)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/util/CipherViewExtensions.kt (+6 -2)
📝 app/src/main/res/values/strings.xml (+1 -1)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditScreenTest.kt (+143 -14)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModelTest.kt (+146 -7)

📄 Description

🎟️ Tracking

PM-18032

📔 Objective

  • Effects both Add/Edit screens for items that can be added to folders
  • Update design of folder selection to use a bottom sheet where the users select the option and then save to confirm selection
  • In the bottom sheet allow users to add a new folder by name.

📸 Screenshots

https://github.com/user-attachments/assets/c736b0f4-305b-4a18-8ffa-234dd17ede34

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4731 **Author:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Created:** 2/17/2025 **Status:** ✅ Merged **Merged:** 2/18/2025 **Merged by:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Base:** `main` ← **Head:** `PM-180323-select-add-folder-in-edit-item` --- ### 📝 Commits (7) - [`9037e9a`](https://github.com/bitwarden/android/commit/9037e9a51ee25418fe686309baadc2846289a750) PM-18032 adding a folder from new bottom sheet in the Add/Edit item screen. - [`59dd7ee`](https://github.com/bitwarden/android/commit/59dd7eefeaf4921169f96397da30253c93a8b5ea) no more timber - [`a20abdc`](https://github.com/bitwarden/android/commit/a20abdcbd17aef9c7d8f90322a0913d1067008c2) comment - [`58d4ade`](https://github.com/bitwarden/android/commit/58d4ade6cd33e5365b4eb18ebfb8510604bc6e31) pr feedback and updating to observe folders - [`3c04965`](https://github.com/bitwarden/android/commit/3c049659b51b0fb6d5b962b39bd5de28ef505ef9) add test - [`903d09b`](https://github.com/bitwarden/android/commit/903d09b13dd57d036e17fc427ea79dc614de2226) other stuffs - [`740bbc8`](https://github.com/bitwarden/android/commit/740bbc8df54ad917a723a2f77afc50daa4796008) explicit text color ### 📊 Changes **11 files changed** (+826 additions, -167 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/bottomsheet/BitwardenModalBottomSheet.kt` (+6 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/button/BitwardenTextSelectionButton.kt` (+174 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/dropdown/BitwardenMultiSelectButton.kt` (+20 -126) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditItemContent.kt` (+3 -7) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditScreen.kt` (+181 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModel.kt` (+120 -4) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/handlers/VaultAddEditCommonHandlers.kt` (+26 -6) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/util/CipherViewExtensions.kt` (+6 -2) 📝 `app/src/main/res/values/strings.xml` (+1 -1) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditScreenTest.kt` (+143 -14) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModelTest.kt` (+146 -7) </details> ### 📄 Description ## 🎟️ Tracking [PM-18032](https://bitwarden.atlassian.net/browse/PM-18032) <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> ## 📔 Objective - Effects both Add/Edit screens for items that can be added to folders - Update design of folder selection to use a bottom sheet where the users select the option and then save to confirm selection - In the bottom sheet allow users to add a new folder by name. <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> ## 📸 Screenshots https://github.com/user-attachments/assets/c736b0f4-305b-4a18-8ffa-234dd17ede34 <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-18032]: https://bitwarden.atlassian.net/browse/PM-18032?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:54:56 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#5165
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?