mirror of
https://github.com/actualbudget/actual.git
synced 2026-03-11 20:44:32 -05:00
e8a4ebaaa3
* fix(transactions): preserve split categories when merging with imported uncategorized tx; avoid orphaned subtransactions When merging a split-categorized manual transaction with an uncategorized imported one, keep the split lines (including categoryId) and avoid leaving orphaned subtransactions by properly transferring parent_id references. Fixes #5801. * docs: add release note for PR #5856 * fix: resolve lint and typecheck errors - Rename unused variables sub1, sub2 to _sub1, _sub2 to fix lint warnings - Fix typecheck error by using double type assertion (unknown) in merge.ts * refactor: optimize subtransaction queries and test db access Address code review feedback: - Merge two SQL queries into one using IN clause for better performance - Use db.first in test to avoid conversion path and match db.all semantics 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * [autofix.ci] apply automated fixes * refactor: apply code review feedback with stable branch logic - Revert test to use db.getTransaction (not db.first) to preserve type conversion - Refactor SQL query to use explicit branches (IN for 2 parents, = for 1, skip for 0) - This approach is more stable across different SQL drivers Addresses: #5856 (review feedback from @joel-jeremy) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * chore(release-notes): set category to Enhancements and shorten text; fix(merge): use shared deleteTransaction with grouped fetch + batchUpdateTransactions * resolving lint warnings and recommendation on the test query * switching to use the getTransaction helper * corrected is_parent assertion to be true * updated the PR number --------- Co-authored-by: Golenspade <2023004079@mails.cust.edu.cn> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: fankex <2112325885@qq.com> Co-authored-by: youngcw <calebyoung94@gmail.com>