github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 03:32:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #5790] [MERGED] fix live report time ranges #6121

New Issue
Closed
opened 2026-02-28 21:24:14 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:24:14 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5790
Author: @matt-fidd
Created: 9/25/2025
Status: ✅ Merged
Merged: 9/25/2025
Merged by: @matt-fidd

Base: master ← Head: fix-live-range

📝 Commits (6)

  • 085d3e8 fix live range
  • 18c88dd note
  • 2ac7b6d use latest of currentMonth/latestTransaction
  • 5a2c83f [autofix.ci] apply automated fixes
  • 7168544 standardise card code
  • e9938e2 Merge branch 'master' into fix-live-range

📊 Changes

11 files changed (+181 additions, -59 deletions)

View changed files

📝 packages/desktop-client/src/components/reports/reportRanges.ts (+11 -1)
📝 packages/desktop-client/src/components/reports/reports/Calendar.tsx (+22 -11)
📝 packages/desktop-client/src/components/reports/reports/CalendarCard.tsx (+22 -5)
📝 packages/desktop-client/src/components/reports/reports/CashFlow.tsx (+17 -8)
📝 packages/desktop-client/src/components/reports/reports/CashFlowCard.tsx (+20 -2)
📝 packages/desktop-client/src/components/reports/reports/NetWorth.tsx (+17 -7)
📝 packages/desktop-client/src/components/reports/reports/NetWorthCard.tsx (+20 -4)
📝 packages/desktop-client/src/components/reports/reports/SpendingCard.tsx (+2 -3)
📝 packages/desktop-client/src/components/reports/reports/Summary.tsx (+21 -10)
📝 packages/desktop-client/src/components/reports/reports/SummaryCard.tsx (+23 -8)
➕ upcoming-release-notes/5790.md (+6 -0)

📄 Description

Fixes https://discord.com/channels/937901803608096828/1389677350215618623/1420520966295126036

This was a balance between retaining the existing behaviour and keeping the changes from https://github.com/actualbudget/actual/pull/5753. I settled on this way because I imagine most people will not add transactions in future months, so they wouldn't see a difference. If you do though, the ranges will push on to the month with the furthest ahead transaction in it, which I can only assume is what you wanted if you added transactions to them.

WDYT? We could also just revert the behaviour so the live ranges just push to the current month and ignore the future transactions but IMO that would go against https://github.com/actualbudget/actual/pull/5753.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5790 **Author:** [@matt-fidd](https://github.com/matt-fidd) **Created:** 9/25/2025 **Status:** ✅ Merged **Merged:** 9/25/2025 **Merged by:** [@matt-fidd](https://github.com/matt-fidd) **Base:** `master` ← **Head:** `fix-live-range` --- ### 📝 Commits (6) - [`085d3e8`](https://github.com/actualbudget/actual/commit/085d3e8c4c10b040de54d72e34563d45ff4a71fb) fix live range - [`18c88dd`](https://github.com/actualbudget/actual/commit/18c88dde896a480171ed456fe7971977562aa19d) note - [`2ac7b6d`](https://github.com/actualbudget/actual/commit/2ac7b6d295c12cddfaa32784c719caf406f67028) use latest of currentMonth/latestTransaction - [`5a2c83f`](https://github.com/actualbudget/actual/commit/5a2c83fed82ee33fe742534bfb2a3019353b6688) [autofix.ci] apply automated fixes - [`7168544`](https://github.com/actualbudget/actual/commit/716854473322a4cf564d3dc2dddc6a519f4ffcdc) standardise card code - [`e9938e2`](https://github.com/actualbudget/actual/commit/e9938e2c89f2aef6edfcc64a373095c15c48eb04) Merge branch 'master' into fix-live-range ### 📊 Changes **11 files changed** (+181 additions, -59 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/reports/reportRanges.ts` (+11 -1) 📝 `packages/desktop-client/src/components/reports/reports/Calendar.tsx` (+22 -11) 📝 `packages/desktop-client/src/components/reports/reports/CalendarCard.tsx` (+22 -5) 📝 `packages/desktop-client/src/components/reports/reports/CashFlow.tsx` (+17 -8) 📝 `packages/desktop-client/src/components/reports/reports/CashFlowCard.tsx` (+20 -2) 📝 `packages/desktop-client/src/components/reports/reports/NetWorth.tsx` (+17 -7) 📝 `packages/desktop-client/src/components/reports/reports/NetWorthCard.tsx` (+20 -4) 📝 `packages/desktop-client/src/components/reports/reports/SpendingCard.tsx` (+2 -3) 📝 `packages/desktop-client/src/components/reports/reports/Summary.tsx` (+21 -10) 📝 `packages/desktop-client/src/components/reports/reports/SummaryCard.tsx` (+23 -8) ➕ `upcoming-release-notes/5790.md` (+6 -0) </details> ### 📄 Description Fixes https://discord.com/channels/937901803608096828/1389677350215618623/1420520966295126036 This was a balance between retaining the existing behaviour and keeping the changes from https://github.com/actualbudget/actual/pull/5753. I settled on this way because I imagine most people will not add transactions in future months, so they wouldn't see a difference. If you do though, the ranges will push on to the month with the furthest ahead transaction in it, which I can only assume is what you wanted if you added transactions to them. WDYT? We could also just revert the behaviour so the live ranges just push to the current month and ignore the future transactions but IMO that would go against https://github.com/actualbudget/actual/pull/5753. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:24:14 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#6121
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?