github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-05 22:52:20 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[GH-ISSUE #1940] [Maintenance][TS] Add missing Modal type #7687

New Issue
Closed
opened 2026-04-10 17:39:12 -05:00 by GiteaMirror · 1 comment
GiteaMirror commented 2026-04-10 17:39:12 -05:00
Owner
Copy Link

Originally created by @MatissJanis on GitHub (Nov 20, 2023).
Original GitHub issue: https://github.com/actualbudget/actual/issues/1940

When reviewing #1885 I noticed that we do not have a Modal type. It is currently inferred as any.

Currently it is used in a few places. For example: 4761e9ce2f/packages/loot-core/src/client/state-types/modals.d.ts (L124)

The goal would be to bring it back (it was removed here). This will mean re-introducing the strict type AND fixing the issues that will arise.

Originally created by @MatissJanis on GitHub (Nov 20, 2023). Original GitHub issue: https://github.com/actualbudget/actual/issues/1940 When reviewing #1885 I noticed that we do not have a `Modal` type. It is currently inferred as `any`. Currently it is used in a few places. For example: https://github.com/actualbudget/actual/blob/4761e9ce2ff80ef5d2927f597499a5644f66de1c/packages/loot-core/src/client/state-types/modals.d.ts#L124 The goal would be to bring it back (it was removed [here](https://github.com/actualbudget/actual/commit/e8b3419933286faea7829993380c1ad1dd0dccfa)). This will mean re-introducing the strict type AND fixing the issues that will arise.
GiteaMirror added the maintenance label 2026-04-10 17:39:12 -05:00
GiteaMirror commented 2026-04-10 17:39:14 -05:00
Author
Owner
Copy Link

@MatissJanis commented on GitHub (Jul 8, 2024):

Don't think this is applicable any more.

Related to TS migration: https://github.com/actualbudget/actual/issues/1483

<!-- gh-comment-id:2214949831 --> @MatissJanis commented on GitHub (Jul 8, 2024): Don't think this is applicable any more. Related to TS migration: https://github.com/actualbudget/actual/issues/1483
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label maintenance
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#7687
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?