github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 15:12:35 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[GH-ISSUE #5044] Tech Debt: Fix missing dependency array in SaveReportChoose.tsx useEffect hook #43806

New Issue
Closed
opened 2026-04-26 04:33:07 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 04:33:07 -05:00
Owner
Copy Link

Originally created by @coderabbitai[bot] on GitHub (May 22, 2025).
Original GitHub issue: https://github.com/actualbudget/actual/issues/5044

Originally assigned to: @joel-jeremy on GitHub.

Description

The useEffect hook in SaveReportChoose.tsx (lines 23-27) is missing a dependency array, causing it to run after every render. This can lead to unnecessary re-renders and potential performance issues.

Current code

useEffect(() => {
  if (inputRef.current) {
    inputRef.current.focus();
  }
});

Suggested fix

useEffect(() => {
  if (inputRef.current) {
    inputRef.current.focus();
  }
}, []);

Context

This issue was identified during review of PR #4955 (https://github.com/actualbudget/actual/pull/4955#discussion_r2101632830) but was decided to be fixed in a separate PR.

Expected outcome

The useEffect hook should only run once on component mount, not after every render.

Originally created by @coderabbitai[bot] on GitHub (May 22, 2025). Original GitHub issue: https://github.com/actualbudget/actual/issues/5044 Originally assigned to: @joel-jeremy on GitHub. ## Description The useEffect hook in SaveReportChoose.tsx (lines 23-27) is missing a dependency array, causing it to run after every render. This can lead to unnecessary re-renders and potential performance issues. ## Current code ```typescript useEffect(() => { if (inputRef.current) { inputRef.current.focus(); } }); ``` ## Suggested fix ```typescript useEffect(() => { if (inputRef.current) { inputRef.current.focus(); } }, []); ``` ## Context This issue was identified during review of PR #4955 (https://github.com/actualbudget/actual/pull/4955#discussion_r2101632830) but was decided to be fixed in a separate PR. ## Expected outcome The useEffect hook should only run once on component mount, not after every render.
GiteaMirror added the tech debtgood first issue labels 2026-04-26 04:33:07 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label good first issue tech debt
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#43806
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?