[PR #3571] [MERGED] Fixes #2885 - Focus ring getting stuck on last column of /accounts/budgeted #4927

Closed
opened 2026-02-28 21:03:20 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/3571
Author: @The-Firexx
Created: 10/4/2024
Status: Merged
Merged: 11/12/2024
Merged by: @joel-jeremy

Base: masterHead: master


📝 Commits (8)

📊 Changes

2 files changed (+44 additions, -4 deletions)

View changed files

📝 packages/desktop-client/src/components/transactions/TransactionsTable.jsx (+38 -4)
upcoming-release-notes/3571.md (+6 -0)

📄 Description

This pull request is to allow a user to use TAB to reach the Cancel and Add button, which cause a better user experience.
This fixes #2885

The changes I made are minimal, however if it is necessary to create/edit tests or other things please let me know.
Also, I'm not very used to React, so any "bad practice" please also report.

Thank you.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/3571 **Author:** [@The-Firexx](https://github.com/The-Firexx) **Created:** 10/4/2024 **Status:** ✅ Merged **Merged:** 11/12/2024 **Merged by:** [@joel-jeremy](https://github.com/joel-jeremy) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (8) - [`3b49d5e`](https://github.com/actualbudget/actual/commit/3b49d5e4299c4c48dcc973efd1d093f459e62558) Fixes focus ring getting stuck on last column of /accounts/budgeted screen when creating a new transaction. - [`fa939a6`](https://github.com/actualbudget/actual/commit/fa939a66faaecd585b95923f7b82ecbbd1ce3476) Fix lint problems with the previous commit - [`149cc52`](https://github.com/actualbudget/actual/commit/149cc52bc3430f6566bf2aee63c027c6005b431e) Merge branch 'master' into master - [`a6f46ad`](https://github.com/actualbudget/actual/commit/a6f46ada0e2f6277ba075c395e6b881227677ee3) Changed the way the hook is made to the cancel and add button, removing the need to change Button2 - [`fe4f789`](https://github.com/actualbudget/actual/commit/fe4f7894a3f8f5be315f7fb0ab7ecba27f7af60f) Merge branch 'master' of https://github.com/The-Firexx/actual - [`a63bd04`](https://github.com/actualbudget/actual/commit/a63bd04881b6bd9a533d2918e32230e748a7d432) Merge branch 'master' of https://github.com/actualbudget/actual - [`32b74b6`](https://github.com/actualbudget/actual/commit/32b74b624430f1d42748145a8c7ce150bf06ce36) Changed the name of variables as mentioned in PR - [`a352a10`](https://github.com/actualbudget/actual/commit/a352a10d2e06cbbfc3bb8b549c08d080139322d0) Merge branch 'master' of https://github.com/actualbudget/actual ### 📊 Changes **2 files changed** (+44 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/transactions/TransactionsTable.jsx` (+38 -4) ➕ `upcoming-release-notes/3571.md` (+6 -0) </details> ### 📄 Description This pull request is to allow a user to use TAB to reach the Cancel and Add button, which cause a better user experience. This fixes #2885 The changes I made are minimal, however if it is necessary to create/edit tests or other things please let me know. Also, I'm not very used to React, so any "bad practice" please also report. Thank you. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:03:20 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#4927