github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-22 08:52:49 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #1180] [MERGED] Improve some of the typings in loot-core #3571

New Issue
Closed
opened 2026-02-28 20:43:36 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:43:36 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1180
Author: @j-f1
Created: 6/24/2023
Status: ✅ Merged
Merged: 6/27/2023
Merged by: @j-f1

Base: master ← Head: jed/handler-types

📝 Commits (10+)

  • ba12eb1 type the handlers export as Handlers
  • 579eec1 Add types to file import & a few actions
  • d17eb72 Add types to import/export/backup methods
  • f785da1 Rename to ServerHandlers, fix some issues
  • ed2cb36 More fixes
  • e4d424a Add types to months.ts
  • 7d308b3 Update to memoize-one v6 to get typings
  • c85840e Add handler typing to App
  • ff8747c Remove schedule/get-possible-transactions
  • 63a5bcd Add some types to schedule handlers

📊 Changes

36 files changed (+330 additions, -186 deletions)

View changed files

📝 packages/desktop-client/package.json (+1 -1)
📝 packages/desktop-client/src/components/budget/rollover/BudgetSummary.tsx (+1 -1)
📝 packages/loot-core/package.json (+1 -1)
📝 packages/loot-core/src/client/actions/account.ts (+0 -1)
📝 packages/loot-core/src/client/actions/app.ts (+1 -1)
📝 packages/loot-core/src/client/actions/sync.ts (+6 -3)
📝 packages/loot-core/src/mocks/budget.ts (+5 -5)
📝 packages/loot-core/src/platform/server/connection/index.d.ts (+2 -1)
📝 packages/loot-core/src/server/accounts/parse-file.test.ts (+2 -1)
📝 packages/loot-core/src/server/accounts/parse-file.ts (+21 -9)
📝 packages/loot-core/src/server/accounts/transactions.ts (+9 -6)
📝 packages/loot-core/src/server/api.ts (+7 -4)
📝 packages/loot-core/src/server/app.ts (+10 -7)
📝 packages/loot-core/src/server/backups.ts (+10 -6)
📝 packages/loot-core/src/server/budget/app.ts (+2 -1)
📝 packages/loot-core/src/server/budget/base.ts (+1 -1)
📝 packages/loot-core/src/server/budget/types/handlers.d.ts (+5 -1)
📝 packages/loot-core/src/server/cloud-storage.ts (+15 -3)
📝 packages/loot-core/src/server/main-app.ts (+2 -1)
📝 packages/loot-core/src/server/main.ts (+6 -3)

...and 16 more files

📄 Description

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1180 **Author:** [@j-f1](https://github.com/j-f1) **Created:** 6/24/2023 **Status:** ✅ Merged **Merged:** 6/27/2023 **Merged by:** [@j-f1](https://github.com/j-f1) **Base:** `master` ← **Head:** `jed/handler-types` --- ### 📝 Commits (10+) - [`ba12eb1`](https://github.com/actualbudget/actual/commit/ba12eb1c35a279795b4e719e653f6e5478530194) type the `handlers` export as Handlers - [`579eec1`](https://github.com/actualbudget/actual/commit/579eec1c22d8b736dc9063a78acc0ccb01da850e) Add types to file import & a few actions - [`d17eb72`](https://github.com/actualbudget/actual/commit/d17eb72a5c178cf18cf5cdbf6e6299a2a856320a) Add types to import/export/backup methods - [`f785da1`](https://github.com/actualbudget/actual/commit/f785da190cb2b22ea0b946f17d6dd616ca55d6d9) Rename to ServerHandlers, fix some issues - [`ed2cb36`](https://github.com/actualbudget/actual/commit/ed2cb364ed8aebfbce39ad403c431478a0321476) More fixes - [`e4d424a`](https://github.com/actualbudget/actual/commit/e4d424a8acbafcee8d97f74c3b214035562d1d01) Add types to months.ts - [`7d308b3`](https://github.com/actualbudget/actual/commit/7d308b318f9e39ffd3f6d9395cf3dede24133337) Update to memoize-one v6 to get typings - [`c85840e`](https://github.com/actualbudget/actual/commit/c85840ecc3344fdcd14f09534a446f242dc21751) Add handler typing to App - [`ff8747c`](https://github.com/actualbudget/actual/commit/ff8747ce1aa38001c95c03612cd2e803a62548c0) Remove schedule/get-possible-transactions - [`63a5bcd`](https://github.com/actualbudget/actual/commit/63a5bcdfbb1f7b74b030577e0675fa8120af8502) Add some types to schedule handlers ### 📊 Changes **36 files changed** (+330 additions, -186 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/package.json` (+1 -1) 📝 `packages/desktop-client/src/components/budget/rollover/BudgetSummary.tsx` (+1 -1) 📝 `packages/loot-core/package.json` (+1 -1) 📝 `packages/loot-core/src/client/actions/account.ts` (+0 -1) 📝 `packages/loot-core/src/client/actions/app.ts` (+1 -1) 📝 `packages/loot-core/src/client/actions/sync.ts` (+6 -3) 📝 `packages/loot-core/src/mocks/budget.ts` (+5 -5) 📝 `packages/loot-core/src/platform/server/connection/index.d.ts` (+2 -1) 📝 `packages/loot-core/src/server/accounts/parse-file.test.ts` (+2 -1) 📝 `packages/loot-core/src/server/accounts/parse-file.ts` (+21 -9) 📝 `packages/loot-core/src/server/accounts/transactions.ts` (+9 -6) 📝 `packages/loot-core/src/server/api.ts` (+7 -4) 📝 `packages/loot-core/src/server/app.ts` (+10 -7) 📝 `packages/loot-core/src/server/backups.ts` (+10 -6) 📝 `packages/loot-core/src/server/budget/app.ts` (+2 -1) 📝 `packages/loot-core/src/server/budget/base.ts` (+1 -1) 📝 `packages/loot-core/src/server/budget/types/handlers.d.ts` (+5 -1) 📝 `packages/loot-core/src/server/cloud-storage.ts` (+15 -3) 📝 `packages/loot-core/src/server/main-app.ts` (+2 -1) 📝 `packages/loot-core/src/server/main.ts` (+6 -3) _...and 16 more files_ </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:43:36 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3571
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?