github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 19:52:56 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #3234] [MERGED] Added configuration to CSV importer that allows to skip lines #4748

New Issue
Closed
opened 2026-02-28 21:00:39 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:00:39 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/3234
Author: @Horizon0156
Created: 8/11/2024
Status: ✅ Merged
Merged: 8/14/2024
Merged by: @matt-fidd

Base: master ← Head: feat/skip-lines

📝 Commits (7)

  • 48099fd Added configuration to CSV importer that allows to skip lines
  • e32caec Merge branch 'master' into feat/skip-lines
  • bc49301 Fixed several type / parser check when import is executed with a different CSV structure on accounts with transactions
  • 23d24ad Fixed linter warning
  • b1a452b Merge branch 'master' into feat/skip-lines
  • 3256280 Reverted changes on sync.ts as initial error is not occuring anymore.
  • a9df1c3 Merge commit '3e07d18acdecbb03300a71f07caa5eaf4d88d41f' into feat/skip-lines

📊 Changes

4 files changed (+58 additions, -11 deletions)

View changed files

📝 packages/desktop-client/src/components/modals/ImportTransactions.jsx (+44 -10)
📝 packages/loot-core/src/server/accounts/parse-file.ts (+7 -1)
📝 packages/loot-core/src/types/prefs.d.ts (+1 -0)
➕ upcoming-release-notes/3234.md (+6 -0)

📄 Description

First of all: Thanks for the great work on Actual ❤️

As I'm a lazy guy and my bank is bloating up CSV exports with additional instructions on top, I've added a simple, optional configuration value that will remove 1-n additional lines from the top of the CSV file. Therefore, the user does not need to modify the bank export before importing it to Actual.

This was also requested by other users:
Fixes #377
Fixes #2157

This requires #3232 to be merged as well, as this is fixing the CSV import in the latest version in general.

Additional details:

This is how a CSV export looks for my bank (ING). Ignore the language, it's just about the structure 😄

Umsatzanzeige;Datei erstellt am: 11.08.2024 14:54

IBAN;XX 1234 1234 1234 1234 12
Kontoname;Girokonto
Bank;ING
Kunde;XXXXXXX
Zeitraum;11.07.2024 - 11.08.2024
Saldo;1.111,11;EUR

Sortierung;Datum absteigend

In der CSV-Datei finden Sie alle bereits gebuchten Umsätze. Die vorgemerkten Umsätze werden nicht aufgenommen, auch wenn sie in Ihrem Internetbanking angezeigt werden.

Buchung;Valuta;Auftraggeber/Empfänger;Buchungstext;Verwendungszweck;Saldo;Währung;Betrag;Währung
...

Without manually removing the first 13 lines, I would not be able to run the importer. Now we have the following configuration field, that defaults to 0.
Bildschirmfoto 2024-08-11 um 15 06 04

When the "Skip lines" parameter is not adjusted (=0), no logic will be applied to the actual parsing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/3234 **Author:** [@Horizon0156](https://github.com/Horizon0156) **Created:** 8/11/2024 **Status:** ✅ Merged **Merged:** 8/14/2024 **Merged by:** [@matt-fidd](https://github.com/matt-fidd) **Base:** `master` ← **Head:** `feat/skip-lines` --- ### 📝 Commits (7) - [`48099fd`](https://github.com/actualbudget/actual/commit/48099fddb9e73fa402ce10c35bfa6feb7340eadd) Added configuration to CSV importer that allows to skip lines - [`e32caec`](https://github.com/actualbudget/actual/commit/e32caec1768202f95964700f5d344b6165a8c8ea) Merge branch 'master' into feat/skip-lines - [`bc49301`](https://github.com/actualbudget/actual/commit/bc493012268df8faa45a3bc4d5b2b03dcbc431ba) Fixed several type / parser check when import is executed with a different CSV structure on accounts with transactions - [`23d24ad`](https://github.com/actualbudget/actual/commit/23d24ad2794b5c8f9cf12625396fc0d202022b80) Fixed linter warning - [`b1a452b`](https://github.com/actualbudget/actual/commit/b1a452b0e8732df79fa1d797c803557b690cb707) Merge branch 'master' into feat/skip-lines - [`3256280`](https://github.com/actualbudget/actual/commit/325628097c8e88dbe5acb9a0120e3e07eef1b9d9) Reverted changes on sync.ts as initial error is not occuring anymore. - [`a9df1c3`](https://github.com/actualbudget/actual/commit/a9df1c3905dfcad2fd313ab067ab9092486bb301) Merge commit '3e07d18acdecbb03300a71f07caa5eaf4d88d41f' into feat/skip-lines ### 📊 Changes **4 files changed** (+58 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/modals/ImportTransactions.jsx` (+44 -10) 📝 `packages/loot-core/src/server/accounts/parse-file.ts` (+7 -1) 📝 `packages/loot-core/src/types/prefs.d.ts` (+1 -0) ➕ `upcoming-release-notes/3234.md` (+6 -0) </details> ### 📄 Description First of all: Thanks for the great work on Actual ❤️ As I'm a lazy guy and my bank is bloating up CSV exports with additional instructions on top, I've added a simple, optional configuration value that will remove 1-n additional lines from the top of the CSV file. Therefore, the user does not need to modify the bank export before importing it to Actual. This was also requested by other users: Fixes #377 Fixes #2157 This requires #3232 to be merged as well, as this is fixing the CSV import in the latest version in general. ### Additional details: This is how a CSV export looks for my bank (ING). Ignore the language, it's just about the structure 😄 ``` Umsatzanzeige;Datei erstellt am: 11.08.2024 14:54 IBAN;XX 1234 1234 1234 1234 12 Kontoname;Girokonto Bank;ING Kunde;XXXXXXX Zeitraum;11.07.2024 - 11.08.2024 Saldo;1.111,11;EUR Sortierung;Datum absteigend In der CSV-Datei finden Sie alle bereits gebuchten Umsätze. Die vorgemerkten Umsätze werden nicht aufgenommen, auch wenn sie in Ihrem Internetbanking angezeigt werden. Buchung;Valuta;Auftraggeber/Empfänger;Buchungstext;Verwendungszweck;Saldo;Währung;Betrag;Währung ... ``` Without manually removing the first 13 lines, I would not be able to run the importer. Now we have the following configuration field, that defaults to 0. ![Bildschirmfoto 2024-08-11 um 15 06 04](https://github.com/user-attachments/assets/80f2e6de-34f0-4b2b-92dd-6683b2cdc082) When the "Skip lines" parameter is not adjusted (=0), no logic will be applied to the actual parsing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 21:00:39 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#4748
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?