github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 12:12:39 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #136] [CLOSED] Fix test suite falling over and add github CI #3039

New Issue
Closed
opened 2026-02-28 20:35:25 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:35:25 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/136
Author: @TomAFrench
Created: 7/24/2022
Status: ❌ Closed

Base: master ← Head: github-action-test

📝 Commits (5)

  • b96ce41 ci: run tests on github actions in addition to circleci
  • f42a855 ci: delete circleci config
  • e0969bd fix: get tests passing again
  • 4950ee1 Merge branch 'master' into github-action-test
  • e14a7b7 Merge branch 'master' into github-action-test

📊 Changes

6 files changed (+1542 additions, -261 deletions)

View changed files

➖ .circleci/config.yml (+0 -121)
➕ .github/workflows/test.yml (+18 -0)
📝 package.json (+0 -1)
📝 packages/loot-core/package.json (+1 -0)
📝 packages/loot-core/src/server/sync/index.js (+3 -3)
📝 yarn.lock (+1520 -136)

📄 Description

Edit: It seems like tests have been broken on master somehow and it only came to light when creating this PR. I've fixed this issue in this PR.

In general we seem to be moving away from using circleCI in favour of Github actions. This PR completes this switch.

A number of the scripts still reference circleCI however I think this is likely fine for now as we don't go down those codepaths on Github and it'll be easier to re-enable code signing later on if we leave them in.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/136 **Author:** [@TomAFrench](https://github.com/TomAFrench) **Created:** 7/24/2022 **Status:** ❌ Closed **Base:** `master` ← **Head:** `github-action-test` --- ### 📝 Commits (5) - [`b96ce41`](https://github.com/actualbudget/actual/commit/b96ce4138b73b240675e7e46e7c91f9093e86b56) ci: run tests on github actions in addition to circleci - [`f42a855`](https://github.com/actualbudget/actual/commit/f42a855b3583e50949d2437ef995a5f3d535c029) ci: delete circleci config - [`e0969bd`](https://github.com/actualbudget/actual/commit/e0969bd54655abbe0fee1a965043a5269941d9b9) fix: get tests passing again - [`4950ee1`](https://github.com/actualbudget/actual/commit/4950ee1310010a059c6b6c4549e08a5ee93dfcfa) Merge branch 'master' into github-action-test - [`e14a7b7`](https://github.com/actualbudget/actual/commit/e14a7b7643d643c2bb16e83eb4635e4f00043f61) Merge branch 'master' into github-action-test ### 📊 Changes **6 files changed** (+1542 additions, -261 deletions) <details> <summary>View changed files</summary> ➖ `.circleci/config.yml` (+0 -121) ➕ `.github/workflows/test.yml` (+18 -0) 📝 `package.json` (+0 -1) 📝 `packages/loot-core/package.json` (+1 -0) 📝 `packages/loot-core/src/server/sync/index.js` (+3 -3) 📝 `yarn.lock` (+1520 -136) </details> ### 📄 Description Edit: It seems like tests have been broken on master somehow and it only came to light when creating this PR. I've fixed this issue in this PR. In general we seem to be moving away from using circleCI in favour of Github actions. This PR completes this switch. A number of the scripts still reference circleCI however I think this is likely fine for now as we don't go down those codepaths on Github and it'll be easier to re-enable code signing later on if we leave them in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-02-28 20:35:25 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#3039
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?