github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 12:12:39 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[PR #6570] fix(web): Close popover on Escape press #6609

New Issue
Closed
opened 2026-02-28 21:30:37 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 21:30:37 -06:00
Owner
Copy Link

Original Pull Request: https://github.com/actualbudget/actual/pull/6570

State: closed
Merged: Yes

Summary

Fixes a bug where the filter popover cannot be closed using the Escape key when an Autocomplete component is inside the popover.

Details

The issue occurs because e.stopPropagation() prevents the Escape key event from reaching the popover. As a result, the user must manually close the popover.

Fix

Call stopPropagation() only when the dropdown is open; otherwise, allow the event to propagate to the parent popover.

Fixes #3039

**Original Pull Request:** https://github.com/actualbudget/actual/pull/6570 **State:** closed **Merged:** Yes --- ### Summary Fixes a bug where the filter popover cannot be closed using the Escape key when an Autocomplete component is inside the popover. ### Details The issue occurs because e.stopPropagation() prevents the Escape key event from reaching the popover. As a result, the user must manually close the popover. ### Fix Call stopPropagation() only when the dropdown is open; otherwise, allow the event to propagate to the parent popover. Fixes #3039
GiteaMirror added the pull-request label 2026-02-28 21:30:37 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#6609
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?