github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 20:15:33 -05:00
Code Issues 1.6k Packages Projects Releases 55 Wiki Activity

[PR #6570] [MERGED] fix(web): Close popover on Escape press #32534

New Issue
Closed
opened 2026-04-18 08:34:02 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-18 08:34:02 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/6570
Author: @skliaruk
Created: 1/6/2026
Status: ✅ Merged
Merged: 1/6/2026
Merged by: @youngcw

Base: master ← Head: close-popover-on-escape

📝 Commits (3)

  • 07d6ca4 fix(web): Close popover on second Escape press when autocomplete options are closed
  • 043340a [autofix.ci] apply automated fixes
  • 9156133 fix(web): use more accurate approach with isOpen

📊 Changes

3 files changed (+10 additions, -10 deletions)

View changed files

📝 packages/desktop-client/src/components/autocomplete/Autocomplete.tsx (+1 -1)
📝 packages/desktop-client/src/components/transactions/TransactionsTable.test.tsx (+3 -9)
➕ upcoming-release-notes/6570.md (+6 -0)

📄 Description

Summary

Fixes a bug where the filter popover cannot be closed using the Escape key when an Autocomplete component is inside the popover.

Details

The issue occurs because e.stopPropagation() prevents the Escape key event from reaching the popover. As a result, the user must manually close the popover.

Fix

Call stopPropagation() only when the dropdown is open; otherwise, allow the event to propagate to the parent popover.

Fixes #3039

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/6570 **Author:** [@skliaruk](https://github.com/skliaruk) **Created:** 1/6/2026 **Status:** ✅ Merged **Merged:** 1/6/2026 **Merged by:** [@youngcw](https://github.com/youngcw) **Base:** `master` ← **Head:** `close-popover-on-escape` --- ### 📝 Commits (3) - [`07d6ca4`](https://github.com/actualbudget/actual/commit/07d6ca426d8555450591a333afc94f5fc101e414) fix(web): Close popover on second Escape press when autocomplete options are closed - [`043340a`](https://github.com/actualbudget/actual/commit/043340a0e00e243de1126abf4df1bd8288714473) [autofix.ci] apply automated fixes - [`9156133`](https://github.com/actualbudget/actual/commit/9156133d88218f7b46d59aadd8c15d5f28d6fc26) fix(web): use more accurate approach with isOpen ### 📊 Changes **3 files changed** (+10 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/autocomplete/Autocomplete.tsx` (+1 -1) 📝 `packages/desktop-client/src/components/transactions/TransactionsTable.test.tsx` (+3 -9) ➕ `upcoming-release-notes/6570.md` (+6 -0) </details> ### 📄 Description ### Summary Fixes a bug where the filter popover cannot be closed using the Escape key when an Autocomplete component is inside the popover. ### Details The issue occurs because e.stopPropagation() prevents the Escape key event from reaching the popover. As a result, the user must manually close the popover. ### Fix Call stopPropagation() only when the dropdown is open; otherwise, allow the event to propagate to the parent popover. Fixes #3039 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-18 08:34:02 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#32534
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?