github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-10 20:23:07 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

Remove deprecated Stack component #2578

New Issue
Closed
opened 2026-02-28 20:19:48 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 20:19:48 -06:00
Owner
Copy Link

Originally created by @coderabbitai[bot] on GitHub (Oct 29, 2025).

Originally assigned to: @MatissJanis on GitHub.

Context

The Stack component has been deprecated in favor of the SpaceBetween component (see #6026). This issue tracks the removal of all usages of the Stack component from the codebase.

Related PR: #6026
Related comment: https://github.com/actualbudget/actual/pull/6026#discussion_r2475559743

TODO List

Mobile Components

  • packages/desktop-client/src/components/mobile/banksync/MobileBankSyncAccountEditPage.tsx
  • packages/desktop-client/src/components/mobile/banksync/BankSyncAccountsListItem.tsx

Tags Components

  • packages/desktop-client/src/components/tags/TagCreationRow.tsx
  • packages/desktop-client/src/components/tags/ManageTags.tsx

Schedules Components

  • packages/desktop-client/src/components/schedules/PostsOfflineNotification.tsx
  • packages/desktop-client/src/components/schedules/DiscoverSchedules.tsx
  • packages/desktop-client/src/components/schedules/ScheduleDetails.tsx

Select Components

  • packages/desktop-client/src/components/select/RecurringSchedulePicker.tsx

Rules Components

  • packages/desktop-client/src/components/rules/RuleRow.tsx
  • packages/desktop-client/src/components/rules/RuleEditor.tsx

Reports Components

  • packages/desktop-client/src/components/reports/SaveReportName.tsx
  • packages/desktop-client/src/components/reports/SaveReportDelete.tsx
  • packages/desktop-client/src/components/reports/SaveReportChoose.tsx

Modals

  • packages/desktop-client/src/components/modals/EditUser.tsx
  • packages/desktop-client/src/components/modals/TrackingBudgetSummaryModal.tsx
  • packages/desktop-client/src/components/modals/TransferOwnership.tsx
  • packages/desktop-client/src/components/modals/UnmigrateBudgetAutomationsModal.tsx
  • packages/desktop-client/src/components/modals/EditAccess.tsx
  • packages/desktop-client/src/components/modals/ImportTransactionsModal/FieldMappings.tsx
  • packages/desktop-client/src/components/modals/ImportTransactionsModal/ImportTransactionsModal.tsx
  • packages/desktop-client/src/components/modals/ImportTransactionsModal/Transaction.tsx
  • packages/desktop-client/src/components/modals/BudgetAutomationsModal.tsx

Manager Components

  • packages/desktop-client/src/components/manager/subscribe/OpenIdForm.tsx

Budget Components

  • packages/desktop-client/src/components/budget/tracking/budgetsummary/BudgetSummary.tsx
  • packages/desktop-client/src/components/budget/goals/editor/HistoricalAutomation.tsx
  • packages/desktop-client/src/components/budget/goals/BudgetAutomationEditor.tsx
  • packages/desktop-client/src/components/budget/goals/editor/ScheduleAutomation.tsx
  • packages/desktop-client/src/components/budget/goals/BudgetAutomation.tsx
  • packages/desktop-client/src/components/budget/goals/editor/PercentageAutomation.tsx
  • packages/desktop-client/src/components/budget/goals/BudgetAutomationReadOnly.tsx

Bank Sync Components

  • packages/desktop-client/src/components/banksync/EditSyncAccount.tsx
  • packages/desktop-client/src/components/banksync/BankSyncCheckboxOptions.tsx

Filters Components

  • packages/desktop-client/src/components/filters/NameFilter.tsx
  • packages/desktop-client/src/components/filters/FiltersStack.tsx
  • packages/desktop-client/src/components/filters/FiltersMenu.jsx

Admin Components

  • packages/desktop-client/src/components/admin/UserDirectory/UserDirectory.tsx

Accounts Components

  • packages/desktop-client/src/components/accounts/Header.tsx

Other Components

  • packages/desktop-client/src/components/Notifications.tsx
  • packages/desktop-client/src/components/ManageRules.tsx
  • packages/desktop-client/src/components/FatalError.tsx

Final Steps

  • Remove Stack component from packages/component-library/src/Stack.tsx
  • Remove Stack export from component library index
  • Update any related tests

Migration Guide

Replace Stack usages with SpaceBetween component where appropriate.

Originally created by @coderabbitai[bot] on GitHub (Oct 29, 2025). Originally assigned to: @MatissJanis on GitHub. ## Context The `Stack` component has been deprecated in favor of the `SpaceBetween` component (see #6026). This issue tracks the removal of all usages of the Stack component from the codebase. Related PR: #6026 Related comment: https://github.com/actualbudget/actual/pull/6026#discussion_r2475559743 ## TODO List ### Mobile Components - [ ] `packages/desktop-client/src/components/mobile/banksync/MobileBankSyncAccountEditPage.tsx` - [ ] `packages/desktop-client/src/components/mobile/banksync/BankSyncAccountsListItem.tsx` ### Tags Components - [ ] `packages/desktop-client/src/components/tags/TagCreationRow.tsx` - [ ] `packages/desktop-client/src/components/tags/ManageTags.tsx` ### Schedules Components - [ ] `packages/desktop-client/src/components/schedules/PostsOfflineNotification.tsx` - [ ] `packages/desktop-client/src/components/schedules/DiscoverSchedules.tsx` - [ ] `packages/desktop-client/src/components/schedules/ScheduleDetails.tsx` ### Select Components - [ ] `packages/desktop-client/src/components/select/RecurringSchedulePicker.tsx` ### Rules Components - [ ] `packages/desktop-client/src/components/rules/RuleRow.tsx` - [ ] `packages/desktop-client/src/components/rules/RuleEditor.tsx` ### Reports Components - [ ] `packages/desktop-client/src/components/reports/SaveReportName.tsx` - [ ] `packages/desktop-client/src/components/reports/SaveReportDelete.tsx` - [ ] `packages/desktop-client/src/components/reports/SaveReportChoose.tsx` ### Modals - [ ] `packages/desktop-client/src/components/modals/EditUser.tsx` - [ ] `packages/desktop-client/src/components/modals/TrackingBudgetSummaryModal.tsx` - [ ] `packages/desktop-client/src/components/modals/TransferOwnership.tsx` - [ ] `packages/desktop-client/src/components/modals/UnmigrateBudgetAutomationsModal.tsx` - [ ] `packages/desktop-client/src/components/modals/EditAccess.tsx` - [ ] `packages/desktop-client/src/components/modals/ImportTransactionsModal/FieldMappings.tsx` - [ ] `packages/desktop-client/src/components/modals/ImportTransactionsModal/ImportTransactionsModal.tsx` - [ ] `packages/desktop-client/src/components/modals/ImportTransactionsModal/Transaction.tsx` - [ ] `packages/desktop-client/src/components/modals/BudgetAutomationsModal.tsx` ### Manager Components - [ ] `packages/desktop-client/src/components/manager/subscribe/OpenIdForm.tsx` ### Budget Components - [ ] `packages/desktop-client/src/components/budget/tracking/budgetsummary/BudgetSummary.tsx` - [ ] `packages/desktop-client/src/components/budget/goals/editor/HistoricalAutomation.tsx` - [ ] `packages/desktop-client/src/components/budget/goals/BudgetAutomationEditor.tsx` - [ ] `packages/desktop-client/src/components/budget/goals/editor/ScheduleAutomation.tsx` - [ ] `packages/desktop-client/src/components/budget/goals/BudgetAutomation.tsx` - [ ] `packages/desktop-client/src/components/budget/goals/editor/PercentageAutomation.tsx` - [ ] `packages/desktop-client/src/components/budget/goals/BudgetAutomationReadOnly.tsx` ### Bank Sync Components - [ ] `packages/desktop-client/src/components/banksync/EditSyncAccount.tsx` - [ ] `packages/desktop-client/src/components/banksync/BankSyncCheckboxOptions.tsx` ### Filters Components - [ ] `packages/desktop-client/src/components/filters/NameFilter.tsx` - [ ] `packages/desktop-client/src/components/filters/FiltersStack.tsx` - [ ] `packages/desktop-client/src/components/filters/FiltersMenu.jsx` ### Admin Components - [ ] `packages/desktop-client/src/components/admin/UserDirectory/UserDirectory.tsx` ### Accounts Components - [ ] `packages/desktop-client/src/components/accounts/Header.tsx` ### Other Components - [ ] `packages/desktop-client/src/components/Notifications.tsx` - [ ] `packages/desktop-client/src/components/ManageRules.tsx` - [ ] `packages/desktop-client/src/components/FatalError.tsx` ### Final Steps - [ ] Remove Stack component from `packages/component-library/src/Stack.tsx` - [ ] Remove Stack export from component library index - [ ] Update any related tests ## Migration Guide Replace `Stack` usages with `SpaceBetween` component where appropriate.
GiteaMirror added the good first issuetech debt labels 2026-02-28 20:19:48 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label good first issue tech debt
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#2578
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?