github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 15:12:35 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #2582] [MERGED] Dim categories hidden by their groups #34577

New Issue
Closed
opened 2026-04-20 21:43:28 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 21:43:28 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/2582
Author: @psybers
Created: 4/10/2024
Status: ✅ Merged
Merged: 4/12/2024
Merged by: @joel-jeremy

Base: master ← Head: issue2578

📝 Commits (9)

  • 069829b Dim categories hidden by their groups
  • a92c3d1 Dim hidden cats on mobile view
  • fd9ac3b Do not show hide/show menu on mobile for categories in hidden groups
  • 4240783 Rename catGroup to categoryGroup
  • b259cad Fix lint issue
  • 0486fe3 Hide menu line
  • f85174c Pass in categoryGroup instead of isHidden
  • 72147bc avoid need for extra local
  • 3b43550 fix lint issues

📊 Changes

9 files changed (+43 additions, -9 deletions)

View changed files

📝 packages/desktop-client/src/components/Modals.tsx (+1 -0)
📝 packages/desktop-client/src/components/budget/BudgetCategories.jsx (+2 -0)
📝 packages/desktop-client/src/components/budget/ExpenseCategory.tsx (+8 -2)
📝 packages/desktop-client/src/components/budget/SidebarCategory.tsx (+8 -3)
📝 packages/desktop-client/src/components/mobile/budget/BudgetTable.jsx (+3 -1)
📝 packages/desktop-client/src/components/mobile/budget/index.tsx (+2 -0)
📝 packages/desktop-client/src/components/modals/CategoryMenuModal.tsx (+12 -3)
📝 packages/loot-core/src/client/state-types/modals.d.ts (+1 -0)
➕ upcoming-release-notes/2582.md (+6 -0)

📄 Description

Closes #2578.

This dims the categories if the parent group is hidden. It also does not show the 'hide'/'show' menu items if the category is hidden (as that would not actually change their hidden status anyway).

dimmed-cats

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/2582 **Author:** [@psybers](https://github.com/psybers) **Created:** 4/10/2024 **Status:** ✅ Merged **Merged:** 4/12/2024 **Merged by:** [@joel-jeremy](https://github.com/joel-jeremy) **Base:** `master` ← **Head:** `issue2578` --- ### 📝 Commits (9) - [`069829b`](https://github.com/actualbudget/actual/commit/069829bd1fe0b68f894a8adb1c1a8c2ff0fead8b) Dim categories hidden by their groups - [`a92c3d1`](https://github.com/actualbudget/actual/commit/a92c3d1624cc3cc8f173e4641a0f2ed87390ee48) Dim hidden cats on mobile view - [`fd9ac3b`](https://github.com/actualbudget/actual/commit/fd9ac3b100b60e891f8b2c19d7de084c2b210fa7) Do not show hide/show menu on mobile for categories in hidden groups - [`4240783`](https://github.com/actualbudget/actual/commit/42407832d9a6d2cb5c26fea767d014059ebe63ac) Rename catGroup to categoryGroup - [`b259cad`](https://github.com/actualbudget/actual/commit/b259cade5ec06eddc378f88a1eb0c5ea5ac7d91a) Fix lint issue - [`0486fe3`](https://github.com/actualbudget/actual/commit/0486fe3d6051ecaff31afcd49b6857a1438bedb0) Hide menu line - [`f85174c`](https://github.com/actualbudget/actual/commit/f85174ca2682ba3901ef6ef482999837124edbe3) Pass in categoryGroup instead of isHidden - [`72147bc`](https://github.com/actualbudget/actual/commit/72147bcbe1775103988ff17c85257eda3b7ca138) avoid need for extra local - [`3b43550`](https://github.com/actualbudget/actual/commit/3b4355068f178f034f6729d8d6c43975bb8f93c9) fix lint issues ### 📊 Changes **9 files changed** (+43 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/Modals.tsx` (+1 -0) 📝 `packages/desktop-client/src/components/budget/BudgetCategories.jsx` (+2 -0) 📝 `packages/desktop-client/src/components/budget/ExpenseCategory.tsx` (+8 -2) 📝 `packages/desktop-client/src/components/budget/SidebarCategory.tsx` (+8 -3) 📝 `packages/desktop-client/src/components/mobile/budget/BudgetTable.jsx` (+3 -1) 📝 `packages/desktop-client/src/components/mobile/budget/index.tsx` (+2 -0) 📝 `packages/desktop-client/src/components/modals/CategoryMenuModal.tsx` (+12 -3) 📝 `packages/loot-core/src/client/state-types/modals.d.ts` (+1 -0) ➕ `upcoming-release-notes/2582.md` (+6 -0) </details> ### 📄 Description Closes #2578. This dims the categories if the parent group is hidden. It also does not show the 'hide'/'show' menu items if the category is hidden (as that would not actually change their hidden status anyway). ![dimmed-cats](https://github.com/actualbudget/actual/assets/1115390/4d6b5754-9d53-4a03-9e91-cf28ed743cd7) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 21:43:28 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#34577
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?