github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-11 20:44:32 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

💚 disabling flaky unit test step (#795)

Browse Source 
Disabling the flaky unit test step. We should re-enable it eventually,
but right now it just creates unnecessary noise..
This commit is contained in:
Matiss Janis Aboltins
2023-03-20 19:44:05 +00:00
committed by GitHub
parent 181d088e76
commit 84cbe6e54c
2 changed files with 10 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
packages/desktop-client/src/components/accounts/TransactionsTable.test.js
View File

@@ -1,6 +1,6 @@
import React, { useState, useEffect } from 'react';
import { render, screen, fireEvent, waitFor } from '@testing-library/react';
import { render, screen, fireEvent } from '@testing-library/react';
import userEvent from '@testing-library/user-event';
import { format as formatDate, parse as parseDate } from 'date-fns';
@@ -359,13 +359,11 @@ describe('Transactions', () => {
// When reaching the bottom it shouldn't error
input = await editField(container, 'notes', 4);
await userEvent.type(input, '[Enter]');
await waitFor(() => {
expect(container.querySelector('input')).toBeNull();
});
// TODO: fix flakiness and re-enable
// When reaching the top it shouldn't error
input = await editField(container, 'notes', 0);
await userEvent.type(input, '{Shift>}[Enter]{/Shift}');
// input = await editField(container, 'notes', 0);
// await userEvent.type(input, '{Shift>}[Enter]{/Shift}');
});
test('keybinding escape resets the value', async () => {

6
upcoming-release-notes/795.md Normal file
View File

@@ -0,0 +1,6 @@
---
category: Maintenance
authors: [MatissJanis]
---
Disable flaky unit test steps