From 84cbe6e54cdb3356951d825aaaf3d52e45d1eb13 Mon Sep 17 00:00:00 2001 From: Matiss Janis Aboltins Date: Mon, 20 Mar 2023 19:44:05 +0000 Subject: [PATCH] :green_heart: disabling flaky unit test step (#795) Disabling the flaky unit test step. We should re-enable it eventually, but right now it just creates unnecessary noise.. --- .../src/components/accounts/TransactionsTable.test.js | 10 ++++------ upcoming-release-notes/795.md | 6 ++++++ 2 files changed, 10 insertions(+), 6 deletions(-) create mode 100644 upcoming-release-notes/795.md diff --git a/packages/desktop-client/src/components/accounts/TransactionsTable.test.js b/packages/desktop-client/src/components/accounts/TransactionsTable.test.js index 671b3c5554..5420ef0660 100644 --- a/packages/desktop-client/src/components/accounts/TransactionsTable.test.js +++ b/packages/desktop-client/src/components/accounts/TransactionsTable.test.js @@ -1,6 +1,6 @@ import React, { useState, useEffect } from 'react'; -import { render, screen, fireEvent, waitFor } from '@testing-library/react'; +import { render, screen, fireEvent } from '@testing-library/react'; import userEvent from '@testing-library/user-event'; import { format as formatDate, parse as parseDate } from 'date-fns'; @@ -359,13 +359,11 @@ describe('Transactions', () => { // When reaching the bottom it shouldn't error input = await editField(container, 'notes', 4); await userEvent.type(input, '[Enter]'); - await waitFor(() => { - expect(container.querySelector('input')).toBeNull(); - }); + // TODO: fix flakiness and re-enable // When reaching the top it shouldn't error - input = await editField(container, 'notes', 0); - await userEvent.type(input, '{Shift>}[Enter]{/Shift}'); + // input = await editField(container, 'notes', 0); + // await userEvent.type(input, '{Shift>}[Enter]{/Shift}'); }); test('keybinding escape resets the value', async () => { diff --git a/upcoming-release-notes/795.md b/upcoming-release-notes/795.md new file mode 100644 index 0000000000..2101f544dc --- /dev/null +++ b/upcoming-release-notes/795.md @@ -0,0 +1,6 @@ +--- +category: Maintenance +authors: [MatissJanis] +--- + +Disable flaky unit test steps