[AI] Fix #2155: duplicated transactions are marked as uncleared (#7723)

* init

* note

packages/desktop-client/src/components/modals/ConfirmTransactionEditModal.tsx

@@ -73,21 +73,6 @@ export function ConfirmTransactionEditModal({
                   out of balance.
                 </Trans>
               </Block>
-            ) : confirmReason === 'batchDuplicateWithReconciledTransfer' ? (
-              <Block>
-                <Trans>
-                  This transfer has a linked transaction in another account that
-                  is reconciled. Duplicating it may bring that account's
-                  reconciliation out of balance.
-                </Trans>
-              </Block>
-            ) : confirmReason === 'batchDuplicateWithReconciled' ? (
-              <Block>
-                <Trans>
-                  Duplicating reconciled transactions may bring your
-                  reconciliation out of balance.
-                </Trans>
-              </Block>
             ) : confirmReason === 'editReconciled' ? (
               <Block>
                 <Trans>

packages/desktop-client/src/hooks/useTransactionBatchActions.ts

@@ -297,7 +297,11 @@ export function useTransactionBatchActions() {
         added: transactions.reduce(
           (newTransactions: TransactionEntity[], trans: TransactionEntity) => {
             return newTransactions.concat(
-              realizeTempTransactions(ungroupTransaction(trans)),
+              realizeTempTransactions(ungroupTransaction(trans)).map(t => ({
+                ...t,
+                cleared: false,
+                reconciled: false,
+              })),
             );
           },
           [],
@@ -309,11 +313,7 @@ export function useTransactionBatchActions() {
       onSuccess?.(ids);
     };
 
-    await checkForReconciledTransactions(
-      ids,
-      'batchDuplicateWithReconciled',
-      onConfirmDuplicate,
-    );
+    await onConfirmDuplicate(ids);
   };
 
   const onBatchDelete = async ({ ids, onSuccess }: BatchDeleteProps) => {
@@ -445,7 +445,6 @@ export function useTransactionBatchActions() {
   > = {
     batchDeleteWithReconciled: 'batchDeleteWithReconciledTransfer',
     batchEditWithReconciled: 'batchEditWithReconciledTransfer',
-    batchDuplicateWithReconciled: 'batchDuplicateWithReconciledTransfer',
   };
 
   const checkForReconciledTransactions = async (

packages/desktop-client/src/modals/modalsSlice.ts

@@ -32,8 +32,6 @@ export type ConfirmTransactionEditReason =
   | 'batchDeleteWithReconciledTransfer'
   | 'batchEditWithReconciled'
   | 'batchEditWithReconciledTransfer'
-  | 'batchDuplicateWithReconciled'
-  | 'batchDuplicateWithReconciledTransfer'
   | 'editReconciled'
   | 'unlockReconciled'
   | 'deleteReconciled';

upcoming-release-notes/7723.md

@@ -0,0 +1,6 @@
+---
+category: Bugfixes
+authors: [youngcw]
+---
+
+Duplicated transactions are marked as uncleared and unlocked