From 1fadfa4e9b847c68babcdb7455cb3080f3e2271b Mon Sep 17 00:00:00 2001 From: youngcw Date: Wed, 6 May 2026 11:43:30 -0600 Subject: [PATCH] [AI] Fix #2155: duplicated transactions are marked as uncleared (#7723) * init * note --- .../modals/ConfirmTransactionEditModal.tsx | 15 --------------- .../src/hooks/useTransactionBatchActions.ts | 13 ++++++------- packages/desktop-client/src/modals/modalsSlice.ts | 2 -- upcoming-release-notes/7723.md | 6 ++++++ 4 files changed, 12 insertions(+), 24 deletions(-) create mode 100644 upcoming-release-notes/7723.md diff --git a/packages/desktop-client/src/components/modals/ConfirmTransactionEditModal.tsx b/packages/desktop-client/src/components/modals/ConfirmTransactionEditModal.tsx index c43e3454ef..756c979bbe 100644 --- a/packages/desktop-client/src/components/modals/ConfirmTransactionEditModal.tsx +++ b/packages/desktop-client/src/components/modals/ConfirmTransactionEditModal.tsx @@ -73,21 +73,6 @@ export function ConfirmTransactionEditModal({ out of balance. - ) : confirmReason === 'batchDuplicateWithReconciledTransfer' ? ( - - - This transfer has a linked transaction in another account that - is reconciled. Duplicating it may bring that account's - reconciliation out of balance. - - - ) : confirmReason === 'batchDuplicateWithReconciled' ? ( - - - Duplicating reconciled transactions may bring your - reconciliation out of balance. - - ) : confirmReason === 'editReconciled' ? ( diff --git a/packages/desktop-client/src/hooks/useTransactionBatchActions.ts b/packages/desktop-client/src/hooks/useTransactionBatchActions.ts index 5c92407edd..c357eccfb3 100644 --- a/packages/desktop-client/src/hooks/useTransactionBatchActions.ts +++ b/packages/desktop-client/src/hooks/useTransactionBatchActions.ts @@ -297,7 +297,11 @@ export function useTransactionBatchActions() { added: transactions.reduce( (newTransactions: TransactionEntity[], trans: TransactionEntity) => { return newTransactions.concat( - realizeTempTransactions(ungroupTransaction(trans)), + realizeTempTransactions(ungroupTransaction(trans)).map(t => ({ + ...t, + cleared: false, + reconciled: false, + })), ); }, [], @@ -309,11 +313,7 @@ export function useTransactionBatchActions() { onSuccess?.(ids); }; - await checkForReconciledTransactions( - ids, - 'batchDuplicateWithReconciled', - onConfirmDuplicate, - ); + await onConfirmDuplicate(ids); }; const onBatchDelete = async ({ ids, onSuccess }: BatchDeleteProps) => { @@ -445,7 +445,6 @@ export function useTransactionBatchActions() { > = { batchDeleteWithReconciled: 'batchDeleteWithReconciledTransfer', batchEditWithReconciled: 'batchEditWithReconciledTransfer', - batchDuplicateWithReconciled: 'batchDuplicateWithReconciledTransfer', }; const checkForReconciledTransactions = async ( diff --git a/packages/desktop-client/src/modals/modalsSlice.ts b/packages/desktop-client/src/modals/modalsSlice.ts index 284e09a324..f4cd01ec7c 100644 --- a/packages/desktop-client/src/modals/modalsSlice.ts +++ b/packages/desktop-client/src/modals/modalsSlice.ts @@ -32,8 +32,6 @@ export type ConfirmTransactionEditReason = | 'batchDeleteWithReconciledTransfer' | 'batchEditWithReconciled' | 'batchEditWithReconciledTransfer' - | 'batchDuplicateWithReconciled' - | 'batchDuplicateWithReconciledTransfer' | 'editReconciled' | 'unlockReconciled' | 'deleteReconciled'; diff --git a/upcoming-release-notes/7723.md b/upcoming-release-notes/7723.md new file mode 100644 index 0000000000..b2fb32b3ba --- /dev/null +++ b/upcoming-release-notes/7723.md @@ -0,0 +1,6 @@ +--- +category: Bugfixes +authors: [youngcw] +--- + +Duplicated transactions are marked as uncleared and unlocked