Fixed [Codacy] coverage examples and improved unknown coverage handling (#2102)

This commit is contained in:
Pyves
2018-09-21 22:49:35 +01:00
committed by GitHub
parent 3c373b58ac
commit a4bec27771
3 changed files with 16 additions and 4 deletions

View File

@@ -383,12 +383,12 @@ const allBadgeExamples = [
},
{
title: 'Codacy coverage',
previewUrl: '/codacy/coverage/c44df2d9c89a4809896914fd1a40bedd.svg',
previewUrl: '/codacy/coverage/59d607d0e311408885e418004068ea58.svg',
},
{
title: 'Codacy branch coverage',
previewUrl:
'/codacy/coverage/c44df2d9c89a4809896914fd1a40bedd/master.svg',
'/codacy/coverage/59d607d0e311408885e418004068ea58/master.svg',
},
{
title: 'Docker Automated build',

View File

@@ -39,8 +39,13 @@ module.exports = class CodacyCoverage extends LegacyService {
return
}
try {
badgeData.text[1] = res
badgeData.colorscheme = coveragePercentageColor(parseInt(res))
const coverage = parseInt(res)
if (Number.isNaN(coverage)) {
badgeData.text[1] = 'unknown'
} else {
badgeData.text[1] = res
badgeData.colorscheme = coveragePercentageColor(coverage)
}
sendBadge(format, badgeData)
} catch (e) {
badgeData.text[1] = 'invalid'

View File

@@ -17,6 +17,13 @@ t.create('Coverage')
})
)
t.create('Coverage unknown')
.get('/coverage/e27821fb6289410b8f58338c7e0bc686.json')
.expectJSON({
name: 'coverage',
value: 'unknown',
})
t.create('Coverage on branch')
.get('/coverage/59d607d0e311408885e418004068ea58/master.json')
.expectJSONTypes(