From a4bec27771ef2bdc2b24a16380d26b34eec51c27 Mon Sep 17 00:00:00 2001 From: Pyves Date: Fri, 21 Sep 2018 22:49:35 +0100 Subject: [PATCH] Fixed [Codacy] coverage examples and improved unknown coverage handling (#2102) --- lib/all-badge-examples.js | 4 ++-- services/codacy/codacy-coverage.service.js | 9 +++++++-- services/codacy/codacy.tester.js | 7 +++++++ 3 files changed, 16 insertions(+), 4 deletions(-) diff --git a/lib/all-badge-examples.js b/lib/all-badge-examples.js index 6fd70421be..dc3a0469c6 100644 --- a/lib/all-badge-examples.js +++ b/lib/all-badge-examples.js @@ -383,12 +383,12 @@ const allBadgeExamples = [ }, { title: 'Codacy coverage', - previewUrl: '/codacy/coverage/c44df2d9c89a4809896914fd1a40bedd.svg', + previewUrl: '/codacy/coverage/59d607d0e311408885e418004068ea58.svg', }, { title: 'Codacy branch coverage', previewUrl: - '/codacy/coverage/c44df2d9c89a4809896914fd1a40bedd/master.svg', + '/codacy/coverage/59d607d0e311408885e418004068ea58/master.svg', }, { title: 'Docker Automated build', diff --git a/services/codacy/codacy-coverage.service.js b/services/codacy/codacy-coverage.service.js index 0257e2122f..e9d3dae252 100644 --- a/services/codacy/codacy-coverage.service.js +++ b/services/codacy/codacy-coverage.service.js @@ -39,8 +39,13 @@ module.exports = class CodacyCoverage extends LegacyService { return } try { - badgeData.text[1] = res - badgeData.colorscheme = coveragePercentageColor(parseInt(res)) + const coverage = parseInt(res) + if (Number.isNaN(coverage)) { + badgeData.text[1] = 'unknown' + } else { + badgeData.text[1] = res + badgeData.colorscheme = coveragePercentageColor(coverage) + } sendBadge(format, badgeData) } catch (e) { badgeData.text[1] = 'invalid' diff --git a/services/codacy/codacy.tester.js b/services/codacy/codacy.tester.js index 19d6f242ab..ac6a93c6dd 100644 --- a/services/codacy/codacy.tester.js +++ b/services/codacy/codacy.tester.js @@ -17,6 +17,13 @@ t.create('Coverage') }) ) +t.create('Coverage unknown') + .get('/coverage/e27821fb6289410b8f58338c7e0bc686.json') + .expectJSON({ + name: 'coverage', + value: 'unknown', + }) + t.create('Coverage on branch') .get('/coverage/59d607d0e311408885e418004068ea58/master.json') .expectJSONTypes(