Commit Graph
35859 Commits
Author SHA1 Message Date
Nicki Křížek 6fceea4244 [9.16] [CVE-2024-4076] serve-stale zversion crash
Backport of MR isc-private/bind9!631

Merge branch '4507-clear-zversion-v9_16' into 'bind-9.16'

See merge request isc-projects/bind9!9175
2024-07-24 12:43:19 +00:00
Matthijs MekkingandNicki Křížek 582f06664e Add release note for [GL #4507] 2024-07-24 13:54:32 +02:00
Mark AndrewsandNicki Křížek 441b288974 Add CHANGES note for [GL #4507]
(cherry picked from commit 09ff8b1169f8be6867c0b2004d0369d246ad2994)
2024-07-24 13:54:29 +02:00
Mark AndrewsandNicki Křížek a61be8eef0 Clear qctx->zversion
Clear qctx->zversion when clearing qctx->zrdataset et al in
lib/ns/query.c:qctx_freedata.  The uncleared pointer could lead to
an assertion failure if zone data needed to be re-saved which could
happen with stale data support enabled.

(cherry picked from commit 179fb3532ab8d4898ab070b2db54c0ce872ef709)
2024-07-24 13:51:41 +02:00
Nicki Křížek 7933d0dcd8 [9.16] [CVE-2024-1975] Remove support for SIG(0) message verification
Backport of isc-private/bind9!690 

Fixes: isc-projects/bind9#4480

Merge branch '4480-drop-sig0-support-bind-9.16' into 'bind-9.16'

See merge request isc-projects/bind9!9174
2024-07-24 11:51:02 +00:00
Petr ŠpačekandNicki Křížek 0978875725 Add CHANGES note for [GL #4480]
(cherry picked from commit 6eda4f465aa75eb6d66a27f2d7a3dfae7611ecf9)
2024-07-24 13:16:01 +02:00
Aram SargsyanandNicki Křížek fbbb9f2f6e Adapt the upforwd test to the SIG(0) removal
Change the check so that update with SIG(0) is expected to fail.

(cherry picked from commit 5f7558f6dbb0527c08caf281299245ab8de268cd)
2024-07-24 13:15:29 +02:00
Petr ŠpačekandNicki Křížek c448b8be0d Adapt the tsiggss test to the SIG(0) removal
Test that SIG(0) signer is NOT sent to the external socket for
authorization. It MUST NOT be considered a valid signature by
any chance.

Also check that the signer's name does not appear in authsock.pl
output.

(cherry picked from commit cf8838085905171fbc00747eb210e8b8284ca0e1)
2024-07-24 13:15:29 +02:00
Aram SargsyanandNicki Křížek c21a152445 Enable stdout autoflush in authsock.pl
With enabled buffering the output gets lost when the process
receives a TERM signal. Disable the buffering.

(cherry picked from commit a0311dfb6e2a51f89dfa8b200b96a0f4675fb654)
2024-07-24 13:15:29 +02:00
Petr ŠpačekandNicki Křížek 9f31ec7ec9 Document SIG(0) verification removal
(cherry picked from commit 654ba34d80b8b6ed805461d7ada2466f8c19a6f1)
2024-07-24 13:15:29 +02:00
Petr ŠpačekandNicki Křížek 0820a90b41 Remove support for SIG(0) message verification
(cherry picked from commit 857fd5c346e3309ee8e280c29174b46579af5a13)
2024-07-24 13:15:27 +02:00
Nicki Křížek 51f86ded38 [9.16][CVE-2024-1737 (part 2)] Be smarter about refusing to add many RR types to the database
Add HTTPS, SVCB, SRV, PTR, NAPTR, DNSKEY and TXT records to the list of
the priority types that are put at the beginning of the slabheader list
for faster access and to avoid eviction when there are more types than
the max-types-per-name limit.

(cherry picked from commit b27c6bcce8)

---

Backport of MR https://gitlab.isc.org/isc-private/bind9/-/merge_requests/712

Related https://gitlab.isc.org/isc-projects/bind9/-/issues/3405

Merge branch '3405-limit-the-number-of-resource-records-in-rrset-nxdomain-9.16' into 'bind-9.16'

See merge request isc-projects/bind9!9172
2024-07-24 11:14:10 +00:00
Ondřej SurýandNicki Křížek 26c9da5f28 Be smarter about refusing to add many RR types to the database
Instead of outright refusing to add new RR types to the cache, be a bit
smarter:

1. If the new header type is in our priority list, we always add either
   positive or negative entry at the beginning of the list.

2. If the new header type is negative entry, and we are over the limit,
   we mark it as ancient immediately, so it gets evicted from the cache
   as soon as possible.

3. Otherwise add the new header after the priority headers (or at the
   head of the list).

4. If we are over the limit, evict the last entry on the normal header
   list.

(cherry picked from commit 57cd34441a)
2024-07-24 12:12:04 +02:00
Ondřej SurýandNicki Křížek c5ebda6deb Make the resolver qtype ANY test order agnostic
Instead of relying on a specific order of the RR types in the databases
pick the first RR type as returned from the cache.

(cherry picked from commit 58f660cf2b)
2024-07-24 12:12:03 +02:00
Ondřej SurýandNicki Křížek d56d2a32b8 Expand the list of the priority types
Add HTTPS, SVCB, SRV, PTR, NAPTR, DNSKEY and TXT records to the list of
the priority types that are put at the beginning of the slabheader list
for faster access and to avoid eviction when there are more types than
the max-types-per-name limit.

(cherry picked from commit b27c6bcce8)
2024-07-24 12:11:59 +02:00
Nicki Křížek 5360c90612 [9.16][CVE-2024-1737] Add a limit to the number of RRs in RRSets
Previously, the number of RRs in the RRSets were internally unlimited.
As the data structure that holds the RRs is just a linked list, and
there are places where we just walk through all of the RRs, adding an
RRSet with huge number of RRs inside would slow down processing of said
RRSets.

Add a configurable limit to cap the number of the RRs in a single RRSet.
This is enforced at the database (rbtdb, qpzone, qpcache) level and
configured with new max-records-per-rrset configuration option that can
be configured globally, per-view and per-zone.

(cherry picked from commit c5c4d00c38530390c9e1ae4c98b65fbbadfe9e5e)

Not a backport, closes https://gitlab.isc.org/isc-projects/bind9/-/issues/3405 for 9.16

Merge branch '3405-limit-the-number-of-resource-records-in-rrset-9.16' into 'bind-9.16'

See merge request isc-projects/bind9!9170
2024-07-24 10:09:58 +00:00
Nicki Křížek 8a4db4bb8e Revert "Build gcc:oraclelinux9:amd64 CI jobs with --disable-developer"
This reverts commit 6a7ec0c01c.
2024-07-24 10:56:59 +02:00
Ondřej SurýandNicki Křížek dfcadc2085 Add a limit to the number of RR types for single name
Previously, the number of RR types for a single owner name was limited
only by the maximum number of the types (64k).  As the data structure
that holds the RR types for the database node is just a linked list, and
there are places where we just walk through the whole list (again and
again), adding a large number of RR types for a single owner named with
would slow down processing of such name (database node).

Add a hard-coded limit (100) to cap the number of the RR types for a single
owner.  The limit can be changed at the compile time by adding following
define to CFLAGS:

    -DDNS_RBTDB_MAX_RTYPES=<limit>
2024-07-24 10:56:59 +02:00
Ondřej SurýandNicki Křížek fdabf4b957 Add a limit to the number of RRs in RRSets
Previously, the number of RRs in the RRSets were internally unlimited.
As the data structure that holds the RRs is just a linked list, and
there are places where we just walk through all of the RRs, adding an
RRSet with huge number of RRs inside would slow down processing of said
RRSets.

The fix for end-of-life branches make the limit compile-time only for
simplicity and the limit can be changed at the compile time by adding
following define to CFLAGS:

    -DDNS_RDATASET_MAX_RECORDS=<limit>

(cherry picked from commit c5c4d00c38530390c9e1ae4c98b65fbbadfe9e5e)
2024-07-24 10:56:57 +02:00
Nicki Křížek 8536c916b6 [9.16] Prevent passing DNS_EVENT_TRYSTALE events to resume_dslookup()
Closes isc-projects/bind9#4661

Merge branch '4661-clear-dns-fetchopt-trystale-ontimeout-9.16' into 'bind-9.16'

See merge request isc-projects/bind9!9168
2024-07-24 08:55:38 +00:00
Mark AndrewsandNicki Křížek 02aa54c690 Add CHANGES not for [GL #4661]
(cherry picked from commit 975bbfba90925a427d71dacd8648448e3f0de2d9)
2024-06-18 10:44:52 +02:00
Mark AndrewsandNicki Křížek b36e1cfbcd Clear DNS_FETCHOPT_TRYSTALE_ONTIMEOUT
When calling dns_resolver_createfetch in resolver.c with a callback
of resume_dslookup, clear DNS_FETCHOPT_TRYSTALE_ONTIMEOUT from
options as DNS_EVENT_TRYSTALE is not an expected event type and
triggers a REQUIRE.

(cherry picked from commit 6faea6da3d646557d234d63ddd5d524d222e8082)
2024-06-06 18:28:35 +02:00
Michał Kępień 6f28b59daa Merge branch '4706-4707-add-more-label-checks-to-dangerfile.py-9.16' into 'bind-9.16'
[9.16] Add more label checks to dangerfile.py

See merge request isc-projects/bind9!9087
2024-06-03 11:15:50 +00:00
Michał Kępień c1fb781de8 Fail for merge requests with "Affects v9.x" labels
Setting "Affects v9.x" labels on a merge request duplicates information
already present on the GitLab issue associated with that merge request.
For trivial merge requests that are not associated with any GitLab
issue, setting the "Affects v9.x" label(s) is considered unnecessary.
Trigger a failure for every merge request marked with at least one
"Affects v9.x" label.

(cherry picked from commit aae51cf28d)
2024-06-03 11:11:43 +00:00
Michał Kępień 8482c3590e Warn about auto-generated merge request titles
Merge request titles auto-generated by GitLab are often a source of
confusion regarding the actual contents of a given merge request.  Warn
for merge requests containing titles that look like auto-generated ones.

(cherry picked from commit 80ec57f198)
2024-06-03 11:11:43 +00:00
Michał Kępień df4d0479d2 Fail for branches using old-style version suffixes
Using "-v9_x" and "-v9.x" version suffixes for branch names is now
deprecated since some automation logic does not handle these.  Fail for
any merge request using such old-style version suffixes.

(cherry picked from commit 09851e6230)
2024-06-03 11:11:42 +00:00
Michał Kępień 211ff9c67f Fail for backports with "Affects v9.x" labels set
Backports are not expected to have any "Affects v9.x" labels set since
those are only meant to be set for merge requests that should have
backports created for them.

(cherry picked from commit 9359cb9c99)
2024-06-03 11:11:42 +00:00
Ondřej Surý fa3172680f Merge branch 'ondrej/drop-windows-from-ci-9.16' into 'bind-9.16'
Remove Windows builds from the CI

See merge request isc-projects/bind9!9076
2024-06-03 07:58:19 +00:00
Ondřej Surý 728d371d64 Remove Windows builds from the CI
Now that BIND 9.16 has reach end-of-life, we can finally remove the
Windows from the CI and decomission the Windows build infrastructure.

Yay!
2024-05-29 08:48:22 +02:00
Nicki Křížek 42c8e1a53d Merge branch 'nicki/use-bind-team-gitlab-tokens-9.16' into 'bind-9.16'
[9.16] Use bind-team tokens for CI gitlab access

See merge request isc-projects/bind9!9069
2024-05-27 11:36:43 +00:00
Nicki Křížek fa3324b10a Use BIND_TEAM_API_TOKEN for danger bot
This is done to unify the token usage across our repositories to
simplify token maintenance.

(cherry picked from commit 6767172bc0)
2024-05-27 11:28:11 +00:00
Michal Nowak e247899727 Merge branch 'mnowak/alpine-3.20-9.16' into 'bind-9.16'
[9.16] Add Alpine Linux 3.20

See merge request isc-projects/bind9!9061
2024-05-23 12:13:07 +00:00
Michal Nowak dcc3e8b289 Add Alpine Linux 3.20
(cherry picked from commit 6f22e79ef9)
2024-05-23 13:25:43 +02:00
Michal Nowak c524ff6845 Merge branch 'mnowak/short-stress-tests-should-keep-artifacts-9.16' into 'bind-9.16'
[9.16] Short stress tests should keep artifacts

See merge request isc-projects/bind9!9058
2024-05-22 12:14:11 +00:00
Michal Nowak ce5637d1c7 Short stress tests should keep artifacts
(cherry picked from commit aa72747c80)
2024-05-22 10:56:04 +00:00
Evan Hunt 849f55a1de Merge branch '4730-clang-format-header-file-changes-bind-9.16' into 'bind-9.16'
[9.16] Resolve "Clang format header file changes"

See merge request isc-projects/bind9!9054
2024-05-18 00:27:54 +00:00
Mark AndrewsandEvan Hunt 9a0769d817 Clang-format header file changes 2024-05-17 16:45:43 -07:00
Nicki Křížek 2e528d4cbc Merge branch 'nicki/add-mailmap-9.16' into 'bind-9.16'
[9.16] Add .mailmap to the git repo

See merge request isc-projects/bind9!9031
2024-05-14 12:22:12 +00:00
Nicki Křížek 42f4f2e9fb Add .mailmap to the git repo
Mailmap can be used to unify the display name in standard git tools.

(cherry picked from commit 986013a708)
2024-05-14 11:30:45 +00:00
Michal Nowak c2c4d07dd1 Merge branch 'mnowak/fedora-40-9.16' into 'bind-9.16'
[9.16] Add Fedora 40

See merge request isc-projects/bind9!9016
2024-05-06 18:20:15 +00:00
Michal Nowak 3bd37c0df6 Add Fedora 40
(cherry picked from commit 1a09f822ad)
2024-05-06 19:48:41 +02:00
Michal Nowak 7f2a9b6964 Merge branch 'mnowak/ubuntu-24.04-noble-numbat-9.16' into 'bind-9.16'
[9.16] Add Ubuntu 24.04 LTS (Noble Numbat)

See merge request isc-projects/bind9!9014
2024-05-06 17:08:03 +00:00
Michal Nowak f0011ecb13 Add Ubuntu 24.04 LTS (Noble Numbat)
(cherry picked from commit d02ed1a0eb)
2024-05-06 18:43:18 +02:00
Michal Nowak 38c476458e Merge branch 'mnowak/openbsd-7.5-9.16' into 'bind-9.16'
[9.16] Add OpenBSD 7.5

See merge request isc-projects/bind9!9012
2024-05-06 15:37:30 +00:00
Michal Nowak 01befe621c Add OpenBSD 7.5
(cherry picked from commit 102fccdcba)
2024-05-06 15:28:18 +00:00
Michal Nowak a46dc1c4e2 Merge branch '4711-stress-test-finer-runtime-granularity-9.16' into 'bind-9.16'
[9.16] Add short version of "stress" tests to MR-triggered pipelines

See merge request isc-projects/bind9!9010
2024-05-06 15:03:41 +00:00
Michal Nowak 4c5ac9f692 Add short "stress" test jobs
(cherry picked from commit f33b746353)
2024-05-06 16:38:47 +02:00
Michal Nowak a136792437 Rename "stress" tests to long "stress" tests
(cherry picked from commit 58a1a50e76)
2024-05-06 16:38:47 +02:00
Michal Nowak 15af238c38 Revert "Drop parallel build from stress tests"
This reverts commit 3fd7e7c81f.

In AWS this is no longer a concern.

(cherry picked from commit 1d77a3b3c6)
2024-05-06 16:20:53 +02:00
Michal Nowak b1c504f5ca Merge branch 'mnowak/stress-tests-freebsd-instance-autoscaler-9.16' into 'bind-9.16'
[9.16] Use FreeBSD autoscaler for "stress" tests

See merge request isc-projects/bind9!8995
2024-04-29 20:45:38 +00:00