ComputerSurge/bind9
3
0
Fork 0
Code Pull Requests 1 Activity

Address race in dnssec system test. 'clear signing records' can fail

Browse Source 
as the update triggers by the rndc command to clear the signing records
may not have completed by the time the subsequent rndc command to test
that the records have been removed is commenced.  Loop several times to
prevent false negative.

(cherry picked from commit 353018c0e5)
This commit is contained in:
Mark Andrews
2020-05-19 13:50:51 +10:00
parent 90bf2b10b2
commit 809d55226b
1 changed files with 9 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
bin/tests/system/dnssec/tests.sh
+9 -6
View File
@@ -2670,13 +2670,16 @@ if [ $ret != 0 ]; then echo_i "failed"; fi
status=`expr $status + $ret`
echo_i "clear signing records ($n)"
$RNDCCMD 10.53.0.3 signing -clear all update-nsec3.example > /dev/null || ret=1
sleep 1
$RNDCCMD 10.53.0.3 signing -list update-nsec3.example 2>&1 > signing.out
grep "No signing records found" signing.out > /dev/null 2>&1 || {
ret=1
sed 's/^/ns3 /' signing.out | cat_i
$RNDCCMD 10.53.0.3 signing -clear all update-nsec3.example > /dev/null 2>&1 || ret=1
check_no_signing_record_found() {
$RNDCCMD 10.53.0.3 signing -list update-nsec3.example > signing.out 2>&1
grep -q "No signing records found" signing.out || {
sed 's/^/ns3 /' signing.out | cat_i
return 1
}
return 0
}
retry_quiet 5 check_no_signing_record_found || ret=1
n=`expr $n + 1`
if [ $ret != 0 ]; then echo_i "failed"; fi
status=`expr $status + $ret`