ComputerSurge/bind9
3
0
Fork 0
Code Pull Requests 1 Activity

the validator can attach to the view normally

Browse Source 
dns_view_weakattach() and _weakdetach() are used by objects that
are created by the view and need it to persist until they are
destroyed, but don't need to prevent it from being shut down. the
validator can use normal view references instead of weak references.
This commit is contained in:
Evan Hunt
2022-05-11 12:15:46 -07:00
parent e8ab719bc2
commit 435e29c3e0
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
lib/dns/validator.c
View File

@@ -3137,7 +3137,7 @@ dns_validator_create(dns_view_t *view, dns_name_t *name, dns_rdatatype_t type,
.action = action,
.arg = arg };
dns_view_weakattach(view, &val->view);
dns_view_attach(view, &val->view);
isc_mutex_init(&val->lock);
result = dns_view_getsecroots(val->view, &val->keytable);
@@ -3171,7 +3171,7 @@ cleanup:
isc_task_detach(&tclone);
isc_event_free(ISC_EVENT_PTR(&event));
dns_view_weakdetach(&val->view);
dns_view_detach(&val->view);
isc_mem_put(view->mctx, val, sizeof(*val));
return (result);
@@ -3250,7 +3250,7 @@ destroy(dns_validator_t *val) {
isc_mem_put(mctx, val->siginfo, sizeof(*val->siginfo));
}
isc_mutex_destroy(&val->lock);
dns_view_weakdetach(&val->view);
dns_view_detach(&val->view);
isc_mem_put(mctx, val, sizeof(*val));
}