ComputerSurge/bind9
3
0
Fork 0
Code Pull Requests 1 Activity

fixed a possible reference leak in dns_resolver_create()

Browse Source 
If an error occurred while creating the resolver, the mctx could
remain attached.
This commit is contained in:
Evan Hunt
2022-05-10 12:48:31 -07:00
parent fe1fa8dc88
commit e8ab719bc2
1 changed files with 1 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
lib/dns/resolver.c
View File

@@ -10234,10 +10234,6 @@ dns_resolver_create(dns_view_t *view, isc_taskmgr_t *taskmgr,
res->quotaresp[dns_quotatype_zone] = DNS_R_DROP;
res->quotaresp[dns_quotatype_server] = DNS_R_SERVFAIL;
isc_refcount_init(&res->references, 1);
atomic_init(&res->exiting, false);
atomic_init(&res->priming, false);
atomic_init(&res->zspill, 0);
atomic_init(&res->nfctx, 0);
ISC_LIST_INIT(res->whenshutdown);
ISC_LIST_INIT(res->alternates);
@@ -10343,8 +10339,7 @@ cleanup_buckets:
dns_badcache_destroy(&res->badcache);
cleanup_res:
isc_mem_put(view->mctx, res, sizeof(*res));
isc_mem_putanddetach(&res->mctx, res, sizeof(*res));
return (result);
}