44899 Commits

Author SHA1 Message Date
Antoine du Hamel
f36de72811 wasi: fix clean target in test/wasi/Makefile
PR-URL: https://github.com/nodejs/node/pull/59576
Refs: https://www.gnu.org/software/make/manual/make.html#Cleanup
Refs: https://www.gnu.org/software/make/manual/make.html#Parallel-Disable
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-08-30 19:06:03 +00:00
방진혁
eefe3b14bf stream: replace manual function validation with validateFunction
Replace repetitive manual function type checking with the existing
validateFunction in multiple stream operator functions.

PR-URL: https://github.com/nodejs/node/pull/59529
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mattias Buelens <mattias@buelens.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2025-08-30 14:37:15 +00:00
René
196f5466af lib: revert to using default derived class constructors
PR-URL: https://github.com/nodejs/node/pull/59650
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2025-08-30 14:28:10 +00:00
Michaël Zasso
67cb0adbc2 test: fix internet/test-dns
Some checks failed
Tools and deps update / tools-deps-update (doc, tools, cd tools/doc npm ci NEW_VERSION=$(npm outdated --parseable | cut -d: -f4 | xargs) if [ "$NEW_VERSION" != "" ]; then echo "NEW_VERSION=new version" >> $GITHUB_ENV rm -rf package-lock.json node_modules # Include $NEW_… (push) Has been skipped
Tools and deps update / tools-deps-update (googletest, dependencies, test, ./tools/dep_updaters/update-googletest.sh > temp-output cat temp-output tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true rm temp-output , deps) (push) Has been skipped
Tools and deps update / tools-deps-update (gyp-next, tools, gyp, ./tools/dep_updaters/update-gyp-next.sh > temp-output cat temp-output tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true rm temp-output , tools) (push) Has been skipped
Tools and deps update / tools-deps-update (histogram, dependencies, ./tools/dep_updaters/update-histogram.sh > temp-output cat temp-output tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true rm temp-output , deps) (push) Has been skipped
Tools and deps update / tools-deps-update (icu, dependencies, test, icu, ./tools/dep_updaters/update-icu.sh > temp-output cat temp-output tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true rm temp-output , deps) (push) Has been skipped
Tools and deps update / tools-deps-update (libuv, dependencies, ./tools/dep_updaters/update-libuv.sh > temp-output cat temp-output tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true rm temp-output , deps) (push) Has been skipped
Tools and deps update / tools-deps-update (llhttp, dependencies, ./tools/dep_updaters/update-llhttp.sh > temp-output cat temp-output tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true rm temp-output , deps) (push) Has been skipped
Tools and deps update / tools-deps-update (minimatch, dependencies, ./tools/dep_updaters/update-minimatch.sh > temp-output cat temp-output tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true rm temp-output , deps) (push) Has been skipped
Tools and deps update / tools-deps-update (nbytes, dependencies, ./tools/dep_updaters/update-nbytes.sh > temp-output cat temp-output tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true rm temp-output , deps) (push) Has been skipped
Tools and deps update / tools-deps-update (nghttp2, dependencies, ./tools/dep_updaters/update-nghttp2.sh > temp-output cat temp-output tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true rm temp-output , deps) (push) Has been skipped
Tools and deps update / tools-deps-update (nghttp3, dependencies, ./tools/dep_updaters/update-nghttp3.sh > temp-output cat temp-output tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true rm temp-output , deps) (push) Has been skipped
Tools and deps update / tools-deps-update (ngtcp2, dependencies, ./tools/dep_updaters/update-ngtcp2.sh > temp-output cat temp-output tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true rm temp-output , deps) (push) Has been skipped
Tools and deps update / tools-deps-update (postject, test, ./tools/dep_updaters/update-postject.sh > temp-output cat temp-output tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true rm temp-output , deps,test) (push) Has been skipped
Tools and deps update / tools-deps-update (root-certificates, crypto, notable-change, node ./tools/dep_updaters/update-root-certs.mjs -v -f "$GITHUB_ENV" , crypto) (push) Has been skipped
Tools and deps update / tools-deps-update (simdjson, dependencies, ./tools/dep_updaters/update-simdjson.sh > temp-output cat temp-output tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true rm temp-output , deps) (push) Has been skipped
Tools and deps update / tools-deps-update (sqlite, dependencies, sqlite, ./tools/dep_updaters/update-sqlite.sh > temp-output cat temp-output tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true rm temp-output , deps) (push) Has been skipped
Tools and deps update / tools-deps-update (undici, dependencies, ./tools/dep_updaters/update-undici.sh > temp-output cat temp-output tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true rm temp-output , deps) (push) Has been skipped
Tools and deps update / tools-deps-update (uvwasi, dependencies, ./tools/dep_updaters/update-uvwasi.sh > temp-output cat temp-output tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true rm temp-output , deps) (push) Has been skipped
Tools and deps update / tools-deps-update (zlib, dependencies, zlib, ./tools/dep_updaters/update-zlib.sh > temp-output cat temp-output tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true rm temp-output , deps) (push) Has been skipped
Tools and deps update / tools-deps-update (zstd, dependencies, zlib, ./tools/dep_updaters/update-zstd.sh > temp-output cat temp-output tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true rm temp-output , deps) (push) Has been skipped
Timezone update / timezone_update (push) Has been skipped
License update / update_license (push) Has been skipped
Find inactive collaborators / find (push) Has been skipped
Find inactive TSC voting members / find (push) Has been skipped
Run CodeQL / Analyze (cpp) (push) Failing after 4s
Run CodeQL / Analyze (javascript) (push) Failing after 3s
Run CodeQL / Analyze (python) (push) Failing after 4s
Close stalled issues and PRs / stale (push) Has been skipped
Daily WPT report / collect-versions (push) Failing after 10m57s
Close stale feature requests / stale (push) Has been skipped
The `nodejs.org` domain has now two TXT records.
Do not verify the exact number of records returned (only their shape),
and check that one of them is the SPF.

PR-URL: https://github.com/nodejs/node/pull/59660
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
2025-08-30 09:47:38 +00:00
Chengzhong Wu
5af035503a src: migrate WriteOneByte to WriteOneByteV2
Some checks failed
Test and upload documentation to artifacts / build-docs (push) Failing after 5s
Linters / lint-addon-docs (push) Failing after 3s
Linters / lint-cpp (push) Failing after 2s
Linters / format-cpp (push) Has been skipped
Linters / lint-js-and-md (push) Failing after 4s
Linters / lint-py (push) Failing after 2s
Linters / lint-yaml (push) Failing after 3s
Linters / lint-sh (push) Failing after 2s
Linters / lint-codeowners (push) Failing after 1s
Linters / lint-pr-url (push) Has been skipped
Linters / lint-readme (push) Failing after 2s
Notify on Push / Notify on Force Push on `main` (push) Has been skipped
Notify on Push / Notify on Push on `main` that lacks metadata (push) Has been skipped
Scorecard supply-chain security / Scorecard analysis (push) Failing after 1s
Coverage Linux (without intl) / coverage-linux-without-intl (push) Has been cancelled
Coverage Linux / coverage-linux (push) Has been cancelled
Coverage Windows / coverage-windows (push) Has been cancelled
PR-URL: https://github.com/nodejs/node/pull/59634
Fixes: https://github.com/nodejs/node/issues/59555
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
2025-08-29 22:41:00 +00:00
theanarkh
cbabdbf3f2 src: remove duplicate code
Some checks failed
Test and upload documentation to artifacts / build-docs (push) Failing after 3s
Linters / lint-addon-docs (push) Failing after 3s
Linters / lint-cpp (push) Failing after 1s
Linters / format-cpp (push) Has been skipped
Linters / lint-js-and-md (push) Failing after 3s
Linters / lint-py (push) Failing after 2s
Linters / lint-yaml (push) Failing after 1s
Linters / lint-sh (push) Failing after 2s
Linters / lint-codeowners (push) Failing after 1s
Linters / lint-pr-url (push) Has been skipped
Linters / lint-readme (push) Failing after 2s
Notify on Push / Notify on Force Push on `main` (push) Has been skipped
Notify on Push / Notify on Push on `main` that lacks metadata (push) Has been skipped
Scorecard supply-chain security / Scorecard analysis (push) Failing after 2s
Run CodeQL / Analyze (cpp) (push) Failing after 3s
Run CodeQL / Analyze (javascript) (push) Failing after 2s
Run CodeQL / Analyze (python) (push) Failing after 1s
Close stalled issues and PRs / stale (push) Has been skipped
Daily WPT report / report (push) Has been skipped
Daily WPT report / collect-versions (push) Has been skipped
Close stale feature requests / stale (push) Has been skipped
Coverage Linux (without intl) / coverage-linux-without-intl (push) Has been cancelled
Coverage Linux / coverage-linux (push) Has been cancelled
Coverage Windows / coverage-windows (push) Has been cancelled
Node.js daily job / build-lto (push) Has been cancelled
Test internet / test-internet (push) Has been cancelled
PR-URL: https://github.com/nodejs/node/pull/59649
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
2025-08-29 17:20:54 +00:00
Tim Perry
fb614c4324 doc: improve documentation for raw headers in HTTP/2 APIs
PR-URL: https://github.com/nodejs/node/pull/59633
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
2025-08-29 15:42:28 +00:00
theanarkh
ac92c928ef worker: add cpu profile APIs for worker
PR-URL: https://github.com/nodejs/node/pull/59428
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
2025-08-29 15:42:21 +00:00
Stefan Stojanovic
a240a9c222 doc: update install_tools.bat free disk space
Some checks failed
Test and upload documentation to artifacts / build-docs (push) Failing after 3s
Linters / lint-addon-docs (push) Failing after 4s
Linters / lint-cpp (push) Failing after 2s
Linters / format-cpp (push) Has been skipped
Linters / lint-js-and-md (push) Failing after 4s
Linters / lint-py (push) Failing after 1s
Linters / lint-yaml (push) Failing after 2s
Linters / lint-sh (push) Failing after 3s
Linters / lint-codeowners (push) Failing after 2s
Linters / lint-pr-url (push) Has been skipped
Linters / lint-readme (push) Failing after 2s
Notify on Push / Notify on Force Push on `main` (push) Has been skipped
Notify on Push / Notify on Push on `main` that lacks metadata (push) Has been skipped
Scorecard supply-chain security / Scorecard analysis (push) Failing after 1s
Coverage Linux (without intl) / coverage-linux-without-intl (push) Has been cancelled
Coverage Linux / coverage-linux (push) Has been cancelled
Coverage Windows / coverage-windows (push) Has been cancelled
Fixes: https://github.com/nodejs/node/issues/59326
PR-URL: https://github.com/nodejs/node/pull/59579
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-08-29 12:34:55 +00:00
Chengzhong Wu
95bef5af88 vm: sync-ify SourceTextModule linkage
Split `module.link(linker)` into two synchronous step
`sourceTextModule.linkRequests()` and
`sourceTextModule.instantiate()`. This allows creating vm modules and
resolving the dependencies in a complete synchronous procedure.

This also makes `syntheticModule.link()` redundant. The link step for a
SyntheticModule is no-op and is already taken care in the constructor
by initializing the binding slots with the given export names.

PR-URL: https://github.com/nodejs/node/pull/59000
Refs: https://github.com/nodejs/node/issues/37648
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
2025-08-29 12:17:18 +00:00
jakecastelli
d08a1f96b2 doc: fix quic session instance typo
Some checks failed
Test and upload documentation to artifacts / build-docs (push) Failing after 3s
Linters / lint-addon-docs (push) Failing after 3s
Linters / lint-cpp (push) Failing after 1s
Linters / format-cpp (push) Has been skipped
Linters / lint-js-and-md (push) Failing after 4s
Linters / lint-py (push) Failing after 2s
Linters / lint-yaml (push) Failing after 1s
Linters / lint-sh (push) Failing after 3s
Linters / lint-codeowners (push) Failing after 2s
Linters / lint-pr-url (push) Has been skipped
Linters / lint-readme (push) Failing after 2s
Notify on Push / Notify on Force Push on `main` (push) Has been skipped
Notify on Push / Notify on Push on `main` that lacks metadata (push) Has been skipped
Scorecard supply-chain security / Scorecard analysis (push) Failing after 2s
PR-URL: https://github.com/nodejs/node/pull/59642
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-08-29 02:24:57 +00:00
Node.js GitHub Bot
fba8e6ab4a 2025-08-28, Version 22.19.0 'Jod' (LTS)
Notable changes:

cli:
  * (SEMVER-MINOR) add NODE_USE_SYSTEM_CA=1 (Joyee Cheung) https://github.com/nodejs/node/pull/59276
  * (SEMVER-MINOR) support `${pid}` placeholder in --cpu-prof-name (Haram Jeong) https://github.com/nodejs/node/pull/59072
crypto:
  * (SEMVER-MINOR) add tls.setDefaultCACertificates() (Joyee Cheung) https://github.com/nodejs/node/pull/58822
dns:
  * (SEMVER-MINOR) support max timeout (theanarkh) https://github.com/nodejs/node/pull/58440
doc:
  * update the instruction on how to verify releases (Antoine du Hamel) https://github.com/nodejs/node/pull/59113
esm:
  * (SEMVER-MINOR) unflag --experimental-wasm-modules (Guy Bedford) https://github.com/nodejs/node/pull/57038
http:
  * (SEMVER-MINOR) add server.keepAliveTimeoutBuffer option (Haram Jeong) https://github.com/nodejs/node/pull/59243
lib:
  * docs deprecate _http_* (Sebastian Beltran) https://github.com/nodejs/node/pull/59293
net:
  * (SEMVER-MINOR) update net.blocklist to allow file save and file management (alphaleadership) https://github.com/nodejs/node/pull/58087
process:
  * (SEMVER-MINOR) add threadCpuUsage (Paolo Insogna) https://github.com/nodejs/node/pull/56467
zlib:
  * (SEMVER-MINOR) add dictionary support to zstdCompress and zstdDecompress (lluisemper) https://github.com/nodejs/node/pull/59240

PR-URL: https://github.com/nodejs/node/pull/59641
2025-08-28 23:08:02 +02:00
Joyee Cheung
bfcba89cc2 test: mark test-inspector-network-fetch as flaky again
Some checks failed
Test and upload documentation to artifacts / build-docs (push) Failing after 41s
Linters / lint-addon-docs (push) Failing after 3s
Linters / lint-cpp (push) Failing after 1s
Linters / format-cpp (push) Has been skipped
Linters / lint-js-and-md (push) Failing after 4s
Linters / lint-py (push) Failing after 2s
Linters / lint-yaml (push) Failing after 1s
Linters / lint-sh (push) Failing after 2s
Linters / lint-codeowners (push) Failing after 2s
Linters / lint-pr-url (push) Has been skipped
Linters / lint-readme (push) Failing after 3s
Notify on Push / Notify on Force Push on `main` (push) Has been skipped
Notify on Push / Notify on Push on `main` that lacks metadata (push) Has been skipped
Scorecard supply-chain security / Scorecard analysis (push) Failing after 2s
Run CodeQL / Analyze (cpp) (push) Failing after 2s
Run CodeQL / Analyze (javascript) (push) Failing after 2s
Run CodeQL / Analyze (python) (push) Failing after 2s
Close stalled issues and PRs / stale (push) Has been skipped
Daily WPT report / report (push) Has been skipped
Daily WPT report / collect-versions (push) Has been skipped
Close stale feature requests / stale (push) Has been skipped
Coverage Linux (without intl) / coverage-linux-without-intl (push) Has been cancelled
Coverage Linux / coverage-linux (push) Has been cancelled
Coverage Windows / coverage-windows (push) Has been cancelled
Node.js daily job / build-lto (push) Has been cancelled
Test internet / test-internet (push) Has been cancelled
https://redirect.github.com/nodejs/node/pull/59104 did not fix it
and it's still flaky in the CI.

Refs: https://github.com/nodejs/reliability/blob/main/reports/2025-08-26.md
Refs: https://github.com/nodejs/node/issues/59090
PR-URL: https://github.com/nodejs/node/pull/59640
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-08-28 20:21:07 +00:00
Joyee Cheung
28225857d7 test: skip test-fs-cp* tests that are constantly failing on Windows
These tests are likely actual regressions introduced when the
monolithic test-fs-cp.mjs was marked as flaky and got ignored due
to the flaky status. They are now constantly failing the Windows
CI and require the CI to always be re-run on Windows when the job
is resumed. Simply skip them until someone fixes them, as there's
no point keep running these known regressions on Windows anymore.

PR-URL: https://github.com/nodejs/node/pull/59637
Refs: https://github.com/nodejs/node/issues/59636
Refs: https://github.com/nodejs/node/pull/59408
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
2025-08-28 19:57:08 +00:00
Ruy Adorno
487938ba64 doc: fix filehandle.read typo
PR-URL: https://github.com/nodejs/node/pull/59635
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-08-28 19:23:59 +00:00
Luigi Pinca
cc0cdb1ed1 test: deflake test-http-keep-alive-empty-line
- Do not call `client.end()` to ensure that the socket is closed by the
  server.
- Remove the timer and send the empty line when the response is
  received.

Fixes: https://github.com/nodejs/node/issues/59577
PR-URL: https://github.com/nodejs/node/pull/59595
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
2025-08-28 19:02:10 +00:00
Augustin Mauroy
42021e4b4c doc: update migration recomendations for util.is**() deprecations
PR-URL: https://github.com/nodejs/node/pull/59269
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2025-08-28 16:59:53 +02:00
Xiao-Tao
b1898c5419 deps: V8: cherry-pick 6b1b9bca2a8
Some checks failed
Test and upload documentation to artifacts / build-docs (push) Failing after 3s
Linters / lint-addon-docs (push) Failing after 3s
Linters / lint-cpp (push) Failing after 1s
Linters / format-cpp (push) Has been skipped
Linters / lint-js-and-md (push) Failing after 3s
Linters / lint-py (push) Failing after 1s
Linters / lint-yaml (push) Failing after 2s
Linters / lint-sh (push) Failing after 2s
Linters / lint-codeowners (push) Failing after 2s
Linters / lint-pr-url (push) Has been skipped
Linters / lint-readme (push) Failing after 2s
Notify on Push / Notify on Force Push on `main` (push) Has been skipped
Notify on Push / Notify on Push on `main` that lacks metadata (push) Has been skipped
Scorecard supply-chain security / Scorecard analysis (push) Failing after 1s
Origin commit message:

    [loong64][codegen] Avoid memory access under stack pointer

    According to LoongArch ABI doc chapter 8.2:
      "Procedures must not assume the persistence on-stack data of which
       the addresses lie below the stack pointer."

    Change-Id: I92735e052227495ac9884c4290b57eaffbf905e1
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6786372
    Auto-Submit: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn>
    Reviewed-by: Matthias Liedtke <mliedtke@chromium.org>
    Commit-Queue: Matthias Liedtke <mliedtke@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#101634}

Refs: 6b1b9bca2a
PR-URL: https://github.com/nodejs/node/pull/59283
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
2025-08-28 06:48:11 +00:00
David Sanders
34f9b7eab9 doc: reserve NMV 140 for Electron 39
Some checks failed
Test and upload documentation to artifacts / build-docs (push) Failing after 4s
Linters / lint-addon-docs (push) Failing after 3s
Linters / lint-cpp (push) Failing after 2s
Linters / format-cpp (push) Has been skipped
Linters / lint-js-and-md (push) Failing after 2s
Linters / lint-py (push) Failing after 2s
Linters / lint-yaml (push) Failing after 2s
Linters / lint-sh (push) Failing after 3s
Linters / lint-codeowners (push) Failing after 2s
Linters / lint-pr-url (push) Has been skipped
Linters / lint-readme (push) Failing after 2s
Notify on Push / Notify on Force Push on `main` (push) Has been skipped
Notify on Push / Notify on Push on `main` that lacks metadata (push) Has been skipped
Scorecard supply-chain security / Scorecard analysis (push) Failing after 1s
PR-URL: https://github.com/nodejs/node/pull/59627
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-08-27 22:18:08 +00:00
Node.js GitHub Bot
d3ac95e6a8 2025-08-27, Version 24.7.0 (Current)
Notable changes:

crypto:
  * update root certificates to NSS 3.114 (Node.js GitHub Bot) https://github.com/nodejs/node/pull/59571
  * (SEMVER-MINOR) add AES-OCB Web Cryptography algorithm (Filip Skokan) https://github.com/nodejs/node/pull/59539
  * (SEMVER-MINOR) support ML-KEM in Web Cryptography (Filip Skokan) https://github.com/nodejs/node/pull/59569
  * (SEMVER-MINOR) support ML-KEM, DHKEM, and RSASVE key encapsulation mechanisms (Filip Skokan) https://github.com/nodejs/node/pull/59491
  * (SEMVER-MINOR) add argon2() and argon2Sync() methods (Ranieri Althoff) https://github.com/nodejs/node/pull/50353
  * (SEMVER-MINOR) support ML-DSA spki/pkcs8 key formats in Web Cryptography (Filip Skokan) https://github.com/nodejs/node/pull/59365
  * (SEMVER-MINOR) add ChaCha20-Poly1305 Web Cryptography algorithm (Filip Skokan) https://github.com/nodejs/node/pull/59365
  * (SEMVER-MINOR) add subtle.getPublicKey() utility function in Web Cryptography (Filip Skokan) https://github.com/nodejs/node/pull/59365
  * (SEMVER-MINOR) add SHA-3 Web Cryptography digest algorithms (Filip Skokan) https://github.com/nodejs/node/pull/59365
  * (SEMVER-MINOR) add SHAKE Web Cryptography digest algorithms (Filip Skokan) https://github.com/nodejs/node/pull/59365
  * (SEMVER-MINOR) add SubtleCrypto.supports feature detection in Web Cryptography (Filip Skokan) https://github.com/nodejs/node/pull/59365
  * (SEMVER-MINOR) support ML-DSA in Web Cryptography (Filip Skokan) https://github.com/nodejs/node/pull/59365
  * (SEMVER-MINOR) support ML-KEM KeyObject (Filip Skokan) https://github.com/nodejs/node/pull/59461
http:
  * (SEMVER-MINOR) add Agent.agentKeepAliveTimeoutBuffer option (Haram Jeong) https://github.com/nodejs/node/pull/59315
http2:
  * (SEMVER-MINOR) add support for raw header arrays in h2Stream.respond() (Tim Perry) https://github.com/nodejs/node/pull/59455
sea:
  * (SEMVER-MINOR) support execArgv in sea config (Joyee Cheung) https://github.com/nodejs/node/pull/59314
stream:
  * (SEMVER-MINOR) add brotli support to CompressionStream and DecompressionStream (Matthew Aitken) https://github.com/nodejs/node/pull/59464

PR-URL: https://github.com/nodejs/node/pull/59629
2025-08-27 23:16:17 +02:00
Joyee Cheung
bcb802cca0 sea: allow using inspector command line flags with SEA
Some checks failed
Test and upload documentation to artifacts / build-docs (push) Failing after 2s
Linters / lint-addon-docs (push) Failing after 2s
Linters / lint-cpp (push) Failing after 2s
Linters / format-cpp (push) Has been skipped
Linters / lint-js-and-md (push) Failing after 2s
Linters / lint-py (push) Failing after 1s
Linters / lint-yaml (push) Failing after 2s
Linters / lint-sh (push) Failing after 2s
Linters / lint-codeowners (push) Failing after 2s
Linters / lint-pr-url (push) Has been skipped
Linters / lint-readme (push) Failing after 2s
Notify on Push / Notify on Force Push on `main` (push) Has been skipped
Notify on Push / Notify on Push on `main` that lacks metadata (push) Has been skipped
Scorecard supply-chain security / Scorecard analysis (push) Failing after 1s
Run CodeQL / Analyze (cpp) (push) Failing after 2s
Run CodeQL / Analyze (javascript) (push) Failing after 1s
Run CodeQL / Analyze (python) (push) Failing after 1s
Close stalled issues and PRs / stale (push) Has been skipped
Daily WPT report / report (push) Has been skipped
Daily WPT report / collect-versions (push) Has been skipped
Close stale feature requests / stale (push) Has been skipped
Coverage Linux (without intl) / coverage-linux-without-intl (push) Has been cancelled
Coverage Linux / coverage-linux (push) Has been cancelled
Coverage Windows / coverage-windows (push) Has been cancelled
Node.js daily job / build-lto (push) Has been cancelled
Test internet / test-internet (push) Has been cancelled
The inspector command line flags should be allowed via NODE_OPTIONS,
though it should not be consumed when passed directly to the SEA.
This patch allows it to consume inspector flags from NODE_OPTIONS
and add tests for different behaviors.

PR-URL: https://github.com/nodejs/node/pull/59568
Fixes: https://github.com/nodejs/node/issues/51688
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
2025-08-27 19:38:55 +00:00
Carlo Cabrera
4e0af20184 build: compile bundled uvwasi conditionally
This does the same for `--shared-uvwasi` as #55886 does for `ada`,
`simdjson`, and `simdutf`.

Refs: https://github.com/nodejs/node/pull/55886
PR-URL: https://github.com/nodejs/node/pull/59622
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2025-08-27 18:40:27 +00:00
Xuguang Mei
ebd2da6d11 repl: add isValidParentheses check before wrap input
PR-URL: https://github.com/nodejs/node/pull/59607
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2025-08-27 17:32:01 +00:00
theanarkh
83c955d8c2 src: add name for more threads
PR-URL: https://github.com/nodejs/node/pull/59601
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
2025-08-27 17:20:32 +00:00
Darshan Sen
c86c488e18 inspector: add http2 tracking support
This allows tracking HTTP/2 calls through the Network tab of
Chrome DevTools for Node.js.

Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/59611
Refs: https://github.com/nodejs/node/issues/53946
Reviewed-By: Ryuhei Shima <shimaryuhei@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
2025-08-27 16:25:13 +00:00
Joyee Cheung
89067de391 src: remove JSONParser
This is now unused after
https://redirect.github.com/nodejs/node/pull/59473 and
and https://redirect.github.com/nodejs/node/pull/59323

PR-URL: https://github.com/nodejs/node/pull/59619
Fixes: https://github.com/nodejs/node/issues/59288
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Shelley Vohr <shelley.vohr@gmail.com>
Reviewed-By: Daniel Lemire <daniel@lemire.me>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
2025-08-27 14:46:43 +00:00
Node.js GitHub Bot
5c9db1046f deps: update amaro to 1.1.2
Some checks failed
Test and upload documentation to artifacts / build-docs (push) Failing after 4s
Linters / lint-addon-docs (push) Failing after 3s
Linters / lint-cpp (push) Failing after 2s
Linters / format-cpp (push) Has been skipped
Linters / lint-js-and-md (push) Failing after 3s
Linters / lint-py (push) Failing after 2s
Linters / lint-yaml (push) Failing after 1s
Linters / lint-sh (push) Failing after 2s
Linters / lint-codeowners (push) Failing after 2s
Linters / lint-pr-url (push) Has been skipped
Linters / lint-readme (push) Failing after 2s
Notify on Push / Notify on Force Push on `main` (push) Has been skipped
Notify on Push / Notify on Push on `main` that lacks metadata (push) Has been skipped
Scorecard supply-chain security / Scorecard analysis (push) Failing after 2s
Coverage Linux (without intl) / coverage-linux-without-intl (push) Has been cancelled
Coverage Linux / coverage-linux (push) Has been cancelled
Coverage Windows / coverage-windows (push) Has been cancelled
PR-URL: https://github.com/nodejs/node/pull/59616
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
2025-08-27 11:38:48 +00:00
Alexander Makarenko
2894849284 doc: fix missing link to the Error documentation in the http page
PR-URL: https://github.com/nodejs/node/pull/59080
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
2025-08-27 10:40:48 +00:00
hotpineapple
ec8c73d6ca test_runner: set mock timer's interval undefined
Some checks failed
Test and upload documentation to artifacts / build-docs (push) Failing after 3s
Linters / lint-addon-docs (push) Failing after 2s
Linters / lint-cpp (push) Failing after 2s
Linters / format-cpp (push) Has been skipped
Linters / lint-js-and-md (push) Failing after 2s
Linters / lint-py (push) Failing after 1s
Linters / lint-yaml (push) Failing after 4s
Linters / lint-sh (push) Failing after 2s
Linters / lint-codeowners (push) Failing after 2s
Linters / lint-pr-url (push) Has been skipped
Linters / lint-readme (push) Failing after 2s
Notify on Push / Notify on Force Push on `main` (push) Has been skipped
Notify on Push / Notify on Push on `main` that lacks metadata (push) Has been skipped
Scorecard supply-chain security / Scorecard analysis (push) Failing after 1s
Coverage Linux (without intl) / coverage-linux-without-intl (push) Has been cancelled
Coverage Linux / coverage-linux (push) Has been cancelled
Coverage Windows / coverage-windows (push) Has been cancelled
prevent adding timer to execution queue if clearInterval() called

PR-URL: https://github.com/nodejs/node/pull/59479
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
2025-08-27 03:36:54 +00:00
Antoine du Hamel
0a46aa9e5d tools: add script to make reviewing backport PRs easier
PR-URL: https://github.com/nodejs/node/pull/59161
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
2025-08-26 22:49:24 +00:00
Filip Skokan
27e2d81617 crypto: add Argon2 Web Cryptography algorithms
Some checks failed
Test and upload documentation to artifacts / build-docs (push) Failing after 3s
Linters / lint-addon-docs (push) Failing after 3s
Linters / lint-cpp (push) Failing after 2s
Linters / format-cpp (push) Has been skipped
Linters / lint-js-and-md (push) Failing after 2s
Linters / lint-py (push) Failing after 2s
Linters / lint-yaml (push) Failing after 2s
Linters / lint-sh (push) Failing after 2s
Linters / lint-codeowners (push) Failing after 1s
Linters / lint-pr-url (push) Has been skipped
Linters / lint-readme (push) Failing after 2s
Notify on Push / Notify on Force Push on `main` (push) Has been skipped
Notify on Push / Notify on Push on `main` that lacks metadata (push) Has been skipped
Scorecard supply-chain security / Scorecard analysis (push) Failing after 1s
Run CodeQL / Analyze (cpp) (push) Failing after 2s
Run CodeQL / Analyze (javascript) (push) Failing after 2s
Run CodeQL / Analyze (python) (push) Failing after 2s
Close stalled issues and PRs / stale (push) Has been skipped
Daily WPT report / report (push) Has been skipped
Daily WPT report / collect-versions (push) Has been skipped
Close stale feature requests / stale (push) Has been skipped
Coverage Linux (without intl) / coverage-linux-without-intl (push) Has been cancelled
Coverage Linux / coverage-linux (push) Has been cancelled
Coverage Windows / coverage-windows (push) Has been cancelled
Node.js daily job / build-lto (push) Has been cancelled
Test internet / test-internet (push) Has been cancelled
PR-URL: https://github.com/nodejs/node/pull/59544
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
2025-08-26 16:05:56 +00:00
Filip Skokan
d00228f5ca crypto: support SLH-DSA KeyObject, sign, and verify
PR-URL: https://github.com/nodejs/node/pull/59537
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
2025-08-26 15:41:25 +00:00
Filip Skokan
ab6991f66b doc,crypto: cleanup unlinked and self method references webcrypto.md
Some checks failed
Test and upload documentation to artifacts / build-docs (push) Failing after 3s
Linters / lint-addon-docs (push) Failing after 3s
Linters / lint-cpp (push) Failing after 1s
Linters / format-cpp (push) Has been skipped
Linters / lint-js-and-md (push) Failing after 4s
Linters / lint-py (push) Failing after 2s
Linters / lint-yaml (push) Failing after 2s
Linters / lint-sh (push) Failing after 2s
Linters / lint-codeowners (push) Failing after 2s
Linters / lint-pr-url (push) Has been skipped
Linters / lint-readme (push) Failing after 2s
Notify on Push / Notify on Force Push on `main` (push) Has been skipped
Notify on Push / Notify on Push on `main` that lacks metadata (push) Has been skipped
Scorecard supply-chain security / Scorecard analysis (push) Failing after 1s
PR-URL: https://github.com/nodejs/node/pull/59608
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2025-08-26 10:15:10 +00:00
Node.js GitHub Bot
886e4b3b53 tools: update gyp-next to 0.20.3
Some checks failed
Test and upload documentation to artifacts / build-docs (push) Failing after 4s
Linters / lint-addon-docs (push) Failing after 4s
Linters / lint-cpp (push) Failing after 2s
Linters / format-cpp (push) Has been skipped
Linters / lint-js-and-md (push) Failing after 3s
Linters / lint-py (push) Failing after 1s
Linters / lint-yaml (push) Failing after 2s
Linters / lint-sh (push) Failing after 3s
Linters / lint-codeowners (push) Failing after 2s
Linters / lint-pr-url (push) Has been skipped
Linters / lint-readme (push) Failing after 3s
Notify on Push / Notify on Force Push on `main` (push) Has been skipped
Notify on Push / Notify on Push on `main` that lacks metadata (push) Has been skipped
Scorecard supply-chain security / Scorecard analysis (push) Failing after 1s
Coverage Linux (without intl) / coverage-linux-without-intl (push) Has been cancelled
Coverage Linux / coverage-linux (push) Has been cancelled
Coverage Windows / coverage-windows (push) Has been cancelled
PR-URL: https://github.com/nodejs/node/pull/59603
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-08-26 01:06:31 +00:00
René
7beb6fac0e doc: improve sqlite.backup() progress/fulfillment documentation
Some checks failed
Test and upload documentation to artifacts / build-docs (push) Failing after 2s
Linters / lint-addon-docs (push) Failing after 3s
Linters / lint-cpp (push) Failing after 1s
Linters / format-cpp (push) Has been skipped
Linters / lint-js-and-md (push) Failing after 3s
Linters / lint-py (push) Failing after 1s
Linters / lint-yaml (push) Failing after 2s
Linters / lint-sh (push) Failing after 3s
Linters / lint-codeowners (push) Failing after 2s
Linters / lint-pr-url (push) Has been skipped
Linters / lint-readme (push) Failing after 2s
Notify on Push / Notify on Force Push on `main` (push) Has been skipped
Notify on Push / Notify on Push on `main` that lacks metadata (push) Has been skipped
Scorecard supply-chain security / Scorecard analysis (push) Failing after 2s
Run CodeQL / Analyze (cpp) (push) Failing after 2s
Run CodeQL / Analyze (javascript) (push) Failing after 2s
Run CodeQL / Analyze (python) (push) Failing after 2s
Close stalled issues and PRs / stale (push) Has been skipped
Find inactive TSC voting members / find (push) Has been skipped
Daily WPT report / report (push) Has been skipped
Daily WPT report / collect-versions (push) Has been skipped
Close stale feature requests / stale (push) Has been skipped
Coverage Linux (without intl) / coverage-linux-without-intl (push) Has been cancelled
Coverage Linux / coverage-linux (push) Has been cancelled
Coverage Windows / coverage-windows (push) Has been cancelled
Node.js daily job / build-lto (push) Has been cancelled
Test internet / test-internet (push) Has been cancelled
PR-URL: https://github.com/nodejs/node/pull/59598
Refs: https://github.com/nodejs/node/pull/56253
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
2025-08-25 15:58:10 +00:00
Rafael Gonzaga
8eeb8fcc00 benchmark: calibrate config v8/serialize.js
According to recent tests with `calibrate-n` on
a dedicated Hetzner machine (4vCPUs | 16gb) the
results got stable with n=1e5.

The work on https://github.com/nodejs/performance/issues/186#issue-3326002531
has shown this benchmark file spends 2-minutes for a single
run. This should improve things a bit.

PR-URL: https://github.com/nodejs/node/pull/59586
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2025-08-25 13:35:26 +00:00
Joyee Cheung
6722642e3d sea: implement execArgvExtension
This implements the execArgvExtension configuration field for SEA,
which takes one of three string values to specify whether and how
execution arguments can be extended for the SEA at run time:

* `"none"`: No extension is allowed. Only the arguments specified
  in `execArgv` will be used,
  and the `NODE_OPTIONS` environment variable will be ignored.
* `"env"`: _(Default)_ The `NODE_OPTIONS` environment variable can
  extend the execution arguments.
  This is the default behavior to maintain backward compatibility.
* `"cli"`: The executable can be launched with
  `--node-options="--flag1 --flag2"`, and those flags
  will be parsed as execution arguments for Node.js instead of being
  passed to the user script. This allows using arguments that are
  not supported by the `NODE_OPTIONS` environment variable.

PR-URL: https://github.com/nodejs/node/pull/59560
Fixes: https://github.com/nodejs/node/issues/55573
Fixes: https://github.com/nodejs/single-executable/issues/100
Refs: https://github.com/nodejs/node/issues/51688
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
2025-08-25 11:35:56 +00:00
Joyee Cheung
65858596ab crypto: load system CA certificates off thread
When --use-system-ca is enabled, load the system CA certificates
eagerly off the main thread to avoid blocking the main thread
when the first TLS connection is made.

PR-URL: https://github.com/nodejs/node/pull/59550
Refs: https://github.com/nodejs/node/issues/58990
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2025-08-25 11:35:46 +00:00
Matteo Collina
323f19c18f doc: clarify experimental platform vulnerability policy
Some checks failed
Test and upload documentation to artifacts / build-docs (push) Failing after 3s
Linters / lint-addon-docs (push) Failing after 4s
Linters / lint-cpp (push) Failing after 2s
Linters / format-cpp (push) Has been skipped
Linters / lint-js-and-md (push) Failing after 3s
Linters / lint-py (push) Failing after 2s
Linters / lint-yaml (push) Failing after 2s
Linters / lint-sh (push) Failing after 3s
Linters / lint-codeowners (push) Failing after 1s
Linters / lint-pr-url (push) Has been skipped
Linters / lint-readme (push) Failing after 3s
Notify on Push / Notify on Force Push on `main` (push) Has been skipped
Notify on Push / Notify on Push on `main` that lacks metadata (push) Has been skipped
Scorecard supply-chain security / Scorecard analysis (push) Failing after 2s
Adds a new section to the threat model specifying that security
vulnerabilities affecting only experimental platforms will not be
accepted as valid security issues and will be treated as normal bugs.

This clarifies that experimental OS/hardware combinations do not
qualify for CVEs or bug bounty rewards, aligning with their limited
testing and support infrastructure.

Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: https://github.com/nodejs/node/pull/59591
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
2025-08-25 10:35:13 +00:00
Rafael Gonzaga
15ede933c3 benchmark: reduce readfile-permission-enabled config
Some checks failed
Test and upload documentation to artifacts / build-docs (push) Failing after 4s
Linters / lint-addon-docs (push) Failing after 3s
Linters / lint-cpp (push) Failing after 2s
Linters / format-cpp (push) Has been skipped
Linters / lint-js-and-md (push) Failing after 4s
Linters / lint-py (push) Failing after 2s
Linters / lint-yaml (push) Failing after 2s
Linters / lint-sh (push) Failing after 3s
Linters / lint-codeowners (push) Failing after 1s
Linters / lint-pr-url (push) Has been skipped
Linters / lint-readme (push) Failing after 2s
Notify on Push / Notify on Force Push on `main` (push) Has been skipped
Notify on Push / Notify on Push on `main` that lacks metadata (push) Has been skipped
Scorecard supply-chain security / Scorecard analysis (push) Failing after 1s
Find inactive collaborators / find (push) Has been skipped
There's no need to test all readfile config as
permission model won't impact based on size.

PR-URL: https://github.com/nodejs/node/pull/59589
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
2025-08-24 21:19:33 +00:00
Rafael Gonzaga
62c62056ca benchmark: calibrate length of util.diff
500 + 1000 already cover the curve. 2000 doesn’t add
new qualitative insight — it just extends the same curve
further down (another ~3–4× slowdown).

According to https://github.com/nodejs/performance/issues/186
this benchmark takes one minute to conclude a single run.
This should fix it.

PR-URL: https://github.com/nodejs/node/pull/59588
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
2025-08-24 20:57:38 +00:00
Tobias Nießen
f86b652bc8 src: enforce assumptions in FIXED_ONE_BYTE_STRING
Some checks failed
Test and upload documentation to artifacts / build-docs (push) Failing after 4s
Linters / lint-addon-docs (push) Failing after 4s
Linters / lint-cpp (push) Failing after 1s
Linters / format-cpp (push) Has been skipped
Linters / lint-js-and-md (push) Failing after 4s
Linters / lint-py (push) Failing after 3s
Linters / lint-yaml (push) Failing after 2s
Linters / lint-sh (push) Failing after 3s
Linters / lint-codeowners (push) Failing after 2s
Linters / lint-pr-url (push) Has been skipped
Linters / lint-readme (push) Failing after 2s
Notify on Push / Notify on Force Push on `main` (push) Has been skipped
Notify on Push / Notify on Push on `main` that lacks metadata (push) Has been skipped
Scorecard supply-chain security / Scorecard analysis (push) Failing after 1s
License update / update_license (push) Has been skipped
Run CodeQL / Analyze (cpp) (push) Failing after 2s
Run CodeQL / Analyze (javascript) (push) Failing after 2s
Run CodeQL / Analyze (python) (push) Failing after 2s
Close stalled issues and PRs / stale (push) Has been skipped
Daily WPT report / report (push) Has been skipped
Daily WPT report / collect-versions (push) Has been skipped
Close stale feature requests / stale (push) Has been skipped
Coverage Linux (without intl) / coverage-linux-without-intl (push) Has been cancelled
Coverage Linux / coverage-linux (push) Has been cancelled
Coverage Windows / coverage-windows (push) Has been cancelled
Node.js daily job / build-lto (push) Has been cancelled
Test internet / test-internet (push) Has been cancelled
These functions are both meant to be used with a null-terminated and
thus non-empty sequence of `char`s. However, there is nothing stopping
call sites from passing zero-length sequences, which would certainly not
be null-terminated and also would cause an underflow in `N - 1`.
Therefore, this commit

- changes the size `N` of the array from `int` to `std::size_t`,
- ensures that compilation will fail if `N = 0`, and
- adds a runtime assertion that fails if the `N`-th `char` is not `\0`.

Note that the runtime assertion should be eliminated by any optimizing
compiler when given a string literal, which is how these functions are
used for the most part (though not exclusively).

PR-URL: https://github.com/nodejs/node/pull/58155
Reviewed-By: Daniel Lemire <daniel@lemire.me>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
2025-08-24 11:07:37 +00:00
Filip Skokan
8692e601cc crypto: add AES-OCB Web Cryptography algorithm
Some checks failed
Test and upload documentation to artifacts / build-docs (push) Failing after 5s
Linters / lint-addon-docs (push) Failing after 3s
Linters / lint-cpp (push) Failing after 2s
Linters / format-cpp (push) Has been skipped
Linters / lint-js-and-md (push) Failing after 3s
Linters / lint-py (push) Failing after 1s
Linters / lint-yaml (push) Failing after 2s
Linters / lint-sh (push) Failing after 2s
Linters / lint-codeowners (push) Failing after 1s
Linters / lint-pr-url (push) Has been skipped
Linters / lint-readme (push) Failing after 2s
Notify on Push / Notify on Force Push on `main` (push) Has been skipped
Notify on Push / Notify on Push on `main` that lacks metadata (push) Has been skipped
Scorecard supply-chain security / Scorecard analysis (push) Failing after 1s
Coverage Linux (without intl) / coverage-linux-without-intl (push) Has been cancelled
Coverage Linux / coverage-linux (push) Has been cancelled
Coverage Windows / coverage-windows (push) Has been cancelled
PR-URL: https://github.com/nodejs/node/pull/59539
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
2025-08-24 09:47:20 +00:00
Node.js GitHub Bot
28e6ba8e4d crypto: update root certificates to NSS 3.114
Some checks failed
Test and upload documentation to artifacts / build-docs (push) Failing after 5s
Linters / lint-addon-docs (push) Failing after 4s
Linters / lint-cpp (push) Failing after 2s
Linters / format-cpp (push) Has been skipped
Linters / lint-js-and-md (push) Failing after 4s
Linters / lint-py (push) Failing after 2s
Linters / lint-yaml (push) Failing after 2s
Linters / lint-sh (push) Failing after 2s
Linters / lint-codeowners (push) Failing after 2s
Linters / lint-pr-url (push) Has been skipped
Linters / lint-readme (push) Failing after 3s
Notify on Push / Notify on Force Push on `main` (push) Has been skipped
Notify on Push / Notify on Push on `main` that lacks metadata (push) Has been skipped
Scorecard supply-chain security / Scorecard analysis (push) Failing after 1s
Coverage Linux (without intl) / coverage-linux-without-intl (push) Has been cancelled
Coverage Linux / coverage-linux (push) Has been cancelled
Coverage Windows / coverage-windows (push) Has been cancelled
This is the certdata.txt[0] from NSS 3.114.

This is the version of NSS that shipped in Firefox 142.0 on 2025-08-19.

Certificates added:
- TrustAsia TLS ECC Root CA
- TrustAsia TLS RSA Root CA
- SwissSign RSA TLS Root CA 2022 - 1

Certificates removed:
- GlobalSign Root CA
- Entrust.net Premium 2048 Secure Server CA
- Baltimore CyberTrust Root
- Comodo AAA Services root
- XRamp Global CA Root
- Go Daddy Class 2 CA
- Starfield Class 2 CA

[0] https://raw.githubusercontent.com/nss-dev/nss/refs/tags/NSS_3_114_RTM/lib/ckfw/builtins/certdata.txt

PR-URL: https://github.com/nodejs/node/pull/59571
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-08-23 23:12:43 +00:00
Alex Yang
d1eabcb044 sqlite: add sqlite-type symbol for DatabaseSync
PR-URL: https://github.com/nodejs/node/pull/59405
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
2025-08-23 21:45:43 +00:00
René
52f616d42f test_runner: do not error when getting fullName of root context
PR-URL: https://github.com/nodejs/node/pull/59377
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
2025-08-23 19:40:58 +00:00
Filip Skokan
589ef79bf8 crypto: support ML-KEM in Web Cryptography
Some checks failed
Tools and deps update / tools-deps-update (corepack, dependencies, make corepack-update echo "NEW_VERSION=$(node deps/corepack/dist/corepack.js --version)" >> $GITHUB_ENV , deps) (push) Has been skipped
Tools and deps update / tools-deps-update (doc, tools, cd tools/doc npm ci NEW_VERSION=$(npm outdated --parseable | cut -d: -f4 | xargs) if [ "$NEW_VERSION" != "" ]; then echo "NEW_VERSION=new version" >> $GITHUB_ENV rm -rf package-lock.json node_modules # Include $NEW_… (push) Has been skipped
Tools and deps update / tools-deps-update (googletest, dependencies, test, ./tools/dep_updaters/update-googletest.sh > temp-output cat temp-output tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true rm temp-output , deps) (push) Has been skipped
Tools and deps update / tools-deps-update (gyp-next, tools, gyp, ./tools/dep_updaters/update-gyp-next.sh > temp-output cat temp-output tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true rm temp-output , tools) (push) Has been skipped
Tools and deps update / tools-deps-update (histogram, dependencies, ./tools/dep_updaters/update-histogram.sh > temp-output cat temp-output tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true rm temp-output , deps) (push) Has been skipped
Tools and deps update / tools-deps-update (icu, dependencies, test, icu, ./tools/dep_updaters/update-icu.sh > temp-output cat temp-output tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true rm temp-output , deps) (push) Has been skipped
Tools and deps update / tools-deps-update (libuv, dependencies, ./tools/dep_updaters/update-libuv.sh > temp-output cat temp-output tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true rm temp-output , deps) (push) Has been skipped
Tools and deps update / tools-deps-update (llhttp, dependencies, ./tools/dep_updaters/update-llhttp.sh > temp-output cat temp-output tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true rm temp-output , deps) (push) Has been skipped
Tools and deps update / tools-deps-update (minimatch, dependencies, ./tools/dep_updaters/update-minimatch.sh > temp-output cat temp-output tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true rm temp-output , deps) (push) Has been skipped
Tools and deps update / tools-deps-update (nbytes, dependencies, ./tools/dep_updaters/update-nbytes.sh > temp-output cat temp-output tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true rm temp-output , deps) (push) Has been skipped
Tools and deps update / tools-deps-update (nghttp2, dependencies, ./tools/dep_updaters/update-nghttp2.sh > temp-output cat temp-output tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true rm temp-output , deps) (push) Has been skipped
Tools and deps update / tools-deps-update (nghttp3, dependencies, ./tools/dep_updaters/update-nghttp3.sh > temp-output cat temp-output tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true rm temp-output , deps) (push) Has been skipped
Tools and deps update / tools-deps-update (ngtcp2, dependencies, ./tools/dep_updaters/update-ngtcp2.sh > temp-output cat temp-output tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true rm temp-output , deps) (push) Has been skipped
Tools and deps update / tools-deps-update (postject, test, ./tools/dep_updaters/update-postject.sh > temp-output cat temp-output tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true rm temp-output , deps,test) (push) Has been skipped
Tools and deps update / tools-deps-update (root-certificates, crypto, notable-change, node ./tools/dep_updaters/update-root-certs.mjs -v -f "$GITHUB_ENV" , crypto) (push) Has been skipped
Tools and deps update / tools-deps-update (simdjson, dependencies, ./tools/dep_updaters/update-simdjson.sh > temp-output cat temp-output tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true rm temp-output , deps) (push) Has been skipped
Tools and deps update / tools-deps-update (sqlite, dependencies, sqlite, ./tools/dep_updaters/update-sqlite.sh > temp-output cat temp-output tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true rm temp-output , deps) (push) Has been skipped
Tools and deps update / tools-deps-update (undici, dependencies, ./tools/dep_updaters/update-undici.sh > temp-output cat temp-output tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true rm temp-output , deps) (push) Has been skipped
Tools and deps update / tools-deps-update (uvwasi, dependencies, ./tools/dep_updaters/update-uvwasi.sh > temp-output cat temp-output tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true rm temp-output , deps) (push) Has been skipped
Tools and deps update / tools-deps-update (zlib, dependencies, zlib, ./tools/dep_updaters/update-zlib.sh > temp-output cat temp-output tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true rm temp-output , deps) (push) Has been skipped
Tools and deps update / tools-deps-update (zstd, dependencies, zlib, ./tools/dep_updaters/update-zstd.sh > temp-output cat temp-output tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true rm temp-output , deps) (push) Has been skipped
Timezone update / timezone_update (push) Has been skipped
Daily WPT report / report (push) Has been skipped
Daily WPT report / collect-versions (push) Has been skipped
Close stale feature requests / stale (push) Has been skipped
Coverage Linux (without intl) / coverage-linux-without-intl (push) Has been cancelled
Coverage Linux / coverage-linux (push) Has been cancelled
Coverage Windows / coverage-windows (push) Has been cancelled
Node.js daily job / build-lto (push) Has been cancelled
Test internet / test-internet (push) Has been cancelled
PR-URL: https://github.com/nodejs/node/pull/59569
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
2025-08-23 17:01:51 +02:00
Aviv Keller
19d2cee62c meta: update devcontainer to the latest schema
PR-URL: https://github.com/nodejs/node/pull/54347
Reviewed-By: James M Snell <jasnell@gmail.com>
2025-08-23 14:20:51 +00:00
Filip Skokan
0fab11805f crypto: require HMAC key length with SHA-3 hashes in Web Cryptography
PR-URL: https://github.com/nodejs/node/pull/59567
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
2025-08-23 10:25:50 +00:00
Sohyeon Kim
fb07edc82f test: use mustSucceed in test-repl-tab-complete-import
Refactor test/parallel/test-repl-tab-complete-import.js to use
mustSucceed in places where no error is expected in the callback. This
clarifies the intent of the tests and improves assertion accuracy.

Refs: https://github.com/nodejs/node/pull/59204
PR-URL: https://github.com/nodejs/node/pull/59368
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-08-23 09:28:02 +00:00