github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-05-06 19:47:47 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #2033] [MERGED] fix: handle mixed-format bucket configurations in migration #8009

New Issue
Closed
opened 2026-04-20 17:58:57 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 17:58:57 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/2033
Author: @kolaente
Created: 12/29/2025
Status: ✅ Merged
Merged: 1/5/2026
Merged by: @kolaente

Base: main ← Head: fix-bucket-config-migration-filter

📝 Commits (2)

  • 30c38b6 fix: handle mixed-format bucket configurations in migration
  • 0ad3a6f fix missing fields

📊 Changes

1 file changed (+54 additions, -26 deletions)

View changed files

📝 pkg/migration/20251001113831.go (+54 -26)

📄 Description

Summary

  • Uses json.RawMessage to flexibly parse bucket configuration filters that may be in old (string) or new (object) format
  • Detects each filter's format by checking the first JSON character (" = string, { = object)
  • Only updates rows that actually contain string filters needing conversion
  • Simplifies WHERE clause since format detection now happens in code

Problem

Migration 20251001113831 would fail with:

json: cannot unmarshal object into Go struct field bucketConfigurationCatchup.filter of type string

This occurred when a single bucket_configuration JSON array contained mixed formats - some buckets with old string filters and some with already-converted object filters.

Test Plan

  • Run migration on database with mixed-format bucket configurations
  • Verify string filters are converted to object format
  • Verify already-converted object filters are preserved
  • Verify empty/null filters remain nil

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/2033 **Author:** [@kolaente](https://github.com/kolaente) **Created:** 12/29/2025 **Status:** ✅ Merged **Merged:** 1/5/2026 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `fix-bucket-config-migration-filter` --- ### 📝 Commits (2) - [`30c38b6`](https://github.com/go-vikunja/vikunja/commit/30c38b6f12d5ed49c253cbd7c9b9a601cc29590b) fix: handle mixed-format bucket configurations in migration - [`0ad3a6f`](https://github.com/go-vikunja/vikunja/commit/0ad3a6f406d462fa0f1d80cb38885266a01d90ee) fix missing fields ### 📊 Changes **1 file changed** (+54 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `pkg/migration/20251001113831.go` (+54 -26) </details> ### 📄 Description ## Summary - Uses `json.RawMessage` to flexibly parse bucket configuration filters that may be in old (string) or new (object) format - Detects each filter's format by checking the first JSON character (`"` = string, `{` = object) - Only updates rows that actually contain string filters needing conversion - Simplifies WHERE clause since format detection now happens in code ## Problem Migration `20251001113831` would fail with: ``` json: cannot unmarshal object into Go struct field bucketConfigurationCatchup.filter of type string ``` This occurred when a single `bucket_configuration` JSON array contained mixed formats - some buckets with old string filters and some with already-converted object filters. ## Test Plan - [ ] Run migration on database with mixed-format bucket configurations - [ ] Verify string filters are converted to object format - [ ] Verify already-converted object filters are preserved - [ ] Verify empty/null filters remain nil --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 17:58:57 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#8009
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?