github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-05-06 19:47:47 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

Filters with invalid filter expressions are still created #2033

New Issue
Closed
opened 2026-03-22 13:51:53 -05:00 by GiteaMirror · 2 comments
GiteaMirror commented 2026-03-22 13:51:53 -05:00
Owner
Copy Link

Originally created by @Ma27 on GitHub (Nov 13, 2024).

Description

To reproduce:

  • Create a new saved filter with name "Foo"
  • Set the expression to syntax = error
  • When hitting the create button, you'll get an error that the expression is invalid and the create modal doesn't close.

However, a filter called Foo is created regardless.
This means if it takes 5 attempts to produce a valid filter, I'll have 5 filters called Foo created.

I'd expect no filter to be created given the error.

Vikunja Version

whatever is on try.vikunja.io

Browser and version

No response

Can you reproduce the bug on the Vikunja demo site?

Yes

Screenshots

No response

Originally created by @Ma27 on GitHub (Nov 13, 2024). ### Description To reproduce: * Create a new saved filter with name "Foo" * Set the expression to `syntax = error` * When hitting the create button, you'll get an error that the expression is invalid and the create modal doesn't close. However, a filter called `Foo` is created regardless. This means if it takes 5 attempts to produce a valid filter, I'll have 5 filters called `Foo` created. I'd expect no filter to be created given the error. ### Vikunja Version whatever is on try.vikunja.io ### Browser and version _No response_ ### Can you reproduce the bug on the Vikunja demo site? Yes ### Screenshots _No response_
GiteaMirror added the bug label 2026-03-22 13:51:53 -05:00
GiteaMirror commented 2026-03-22 13:51:54 -05:00
Author
Owner
Copy Link

@kolaente commented on GitHub (Nov 18, 2024):

Fixed in bd3eab8c34, please check with the next unstable build (should be ready for deployment in ~45min, also on try).

@kolaente commented on GitHub (Nov 18, 2024): Fixed in bd3eab8c340c6b465ddb50bafa169aebc5d9de8d, please check with the next unstable build (should be ready for deployment in ~45min, also on [try](https://try.vikunja.io)).
GiteaMirror commented 2026-03-22 13:51:55 -05:00
Author
Owner
Copy Link

@Ma27 commented on GitHub (Nov 18, 2024):

Looks correct now on try.vikunja.io, thanks!

Guess I'll just update my vikunja, using master anyways with the PRs from me on top and have regular backups just in case ;-)

@Ma27 commented on GitHub (Nov 18, 2024): Looks correct now on try.vikunja.io, thanks! Guess I'll just update my vikunja, using master anyways with the PRs from me on top and have regular backups just in case ;-)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#2033
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?