github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-05-06 11:37:49 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #2469] [MERGED] fix: use custom TableName() for dump/restore table resolution #5657

New Issue
Closed
opened 2026-04-16 13:47:33 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 13:47:33 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/2469
Author: @tink-bot
Created: 3/24/2026
Status: ✅ Merged
Merged: 3/24/2026
Merged by: @kolaente

Base: main ← Head: fix/dump-table-name-resolution

📝 Commits (2)

  • dbc28c3 fix: use custom TableName() for dump/restore table resolution
  • dcfb091 refactor: use xorm's TableInfo to resolve table names

📊 Changes

1 file changed (+8 additions, -6 deletions)

View changed files

📝 pkg/db/db.go (+8 -6)

📄 Description

RegisteredTableNames() derived table names from Go struct type names via the xorm name mapper, ignoring custom TableName() methods. This caused vikunja dump to query database_notification instead of the actual table notifications, failing with "Table doesn't exist".

Fixes #2464

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/2469 **Author:** [@tink-bot](https://github.com/tink-bot) **Created:** 3/24/2026 **Status:** ✅ Merged **Merged:** 3/24/2026 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `fix/dump-table-name-resolution` --- ### 📝 Commits (2) - [`dbc28c3`](https://github.com/go-vikunja/vikunja/commit/dbc28c3f4301d118a4036191c218374dc2ce2950) fix: use custom TableName() for dump/restore table resolution - [`dcfb091`](https://github.com/go-vikunja/vikunja/commit/dcfb0911b5f5c41669a467a0231f7b4204b981d1) refactor: use xorm's TableInfo to resolve table names ### 📊 Changes **1 file changed** (+8 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `pkg/db/db.go` (+8 -6) </details> ### 📄 Description `RegisteredTableNames()` derived table names from Go struct type names via the xorm name mapper, ignoring custom `TableName()` methods. This caused `vikunja dump` to query `database_notification` instead of the actual table `notifications`, failing with "Table doesn't exist". Fixes #2464 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 13:47:33 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#5657
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?