github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-05-15 13:11:10 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #2352] [MERGED] fix: prevent nil pointer panic in HandleTaskUpdatedMentions listener #5622

New Issue
Closed
opened 2026-04-16 13:44:33 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 13:44:33 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/2352
Author: @tink-bot
Created: 3/4/2026
Status: ✅ Merged
Merged: 3/4/2026
Merged by: @kolaente

Base: main ← Head: fix-nil-panic-mentions

📝 Commits (1)

  • 4446d6c fix: prevent nil pointer panic in mention notification listeners

📊 Changes

3 files changed (+36 additions, -5 deletions)

View changed files

📝 pkg/models/kanban_task_bucket.go (+7 -5)
📝 pkg/models/listeners.go (+16 -0)
📝 pkg/models/mentions_test.go (+13 -0)

📄 Description

Summary

  • Fixes a nil pointer dereference panic in HandleTaskUpdatedMentions (and related mention handlers) reported via Sentry
  • Root cause: TaskBucket.Update dispatched a TaskUpdatedEvent with nil Task when updateTaskBucket returned early (no bucket change), leaving b.Task unset
  • Added nil guard at the event dispatch site in kanban_task_bucket.go to prevent the nil event from being sent
  • Added defensive nil checks in four event listeners (HandleTaskUpdatedMentions, HandleTaskCreateMentions, HandleTaskCommentEditMentions, UpdateTaskInSavedFilterViews) for defense in depth
  • Added unit tests verifying all three mention handlers gracefully handle nil task events

Test plan

  • New unit tests pass: TestHandleMentionsWithNilTask with subtests for all three mention handlers
  • Existing feature tests pass (mage test:feature)
  • Linter passes (only pre-existing frontend/embed.go issue, unrelated)

Closes #2351

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/2352 **Author:** [@tink-bot](https://github.com/tink-bot) **Created:** 3/4/2026 **Status:** ✅ Merged **Merged:** 3/4/2026 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `fix-nil-panic-mentions` --- ### 📝 Commits (1) - [`4446d6c`](https://github.com/go-vikunja/vikunja/commit/4446d6cec1a354d563b0af8e18e21735a3118284) fix: prevent nil pointer panic in mention notification listeners ### 📊 Changes **3 files changed** (+36 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `pkg/models/kanban_task_bucket.go` (+7 -5) 📝 `pkg/models/listeners.go` (+16 -0) 📝 `pkg/models/mentions_test.go` (+13 -0) </details> ### 📄 Description ## Summary - Fixes a nil pointer dereference panic in `HandleTaskUpdatedMentions` (and related mention handlers) reported via Sentry - Root cause: `TaskBucket.Update` dispatched a `TaskUpdatedEvent` with nil `Task` when `updateTaskBucket` returned early (no bucket change), leaving `b.Task` unset - Added nil guard at the event dispatch site in `kanban_task_bucket.go` to prevent the nil event from being sent - Added defensive nil checks in four event listeners (`HandleTaskUpdatedMentions`, `HandleTaskCreateMentions`, `HandleTaskCommentEditMentions`, `UpdateTaskInSavedFilterViews`) for defense in depth - Added unit tests verifying all three mention handlers gracefully handle nil task events ## Test plan - [x] New unit tests pass: `TestHandleMentionsWithNilTask` with subtests for all three mention handlers - [x] Existing feature tests pass (`mage test:feature`) - [x] Linter passes (only pre-existing `frontend/embed.go` issue, unrelated) Closes #2351 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 13:44:33 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#5622
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?