github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-03-11 17:48:44 -05:00
Code Issues 219 Packages Projects Releases 2 Wiki Activity

[PR #1073] [MERGED] feat: introduce shared health check logic #1207

New Issue
Closed
opened 2025-11-01 21:13:17 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-01 21:13:17 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/1073
Author: @kolaente
Created: 7/2/2025
Status: ✅ Merged
Merged: 7/2/2025
Merged by: @kolaente

Base: main ← Head: codex/refactor-healthcheck-implementation

📝 Commits (2)

📊 Changes

4 files changed (+64 additions, -21 deletions)

View changed files

📝 pkg/cmd/healthcheck.go (+5 -20)
➕ pkg/health/health.go (+46 -0)
📝 pkg/routes/healthcheck.go (+5 -0)
📝 pkg/webtests/healthcheck_test.go (+8 -1)

📄 Description

Summary

  • add a health.Check helper to verify DB and redis connections
  • use health.Check in /health route
  • call health.Check from the healthcheck command
  • update tests for the new shared behaviour
  • reuse an existing DB session in health.Check

Testing

  • mage lint:fix
  • mage test:web

https://chatgpt.com/codex/tasks/task_e_6863c981236c8322b1e9ae66336f084b

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/1073 **Author:** [@kolaente](https://github.com/kolaente) **Created:** 7/2/2025 **Status:** ✅ Merged **Merged:** 7/2/2025 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `codex/refactor-healthcheck-implementation` --- ### 📝 Commits (2) - [`8c99055`](https://github.com/go-vikunja/vikunja/commit/8c99055484c6c60deb3ed0ca20165549d847418e) fix: reuse db session in health check - [`f2e02c7`](https://github.com/go-vikunja/vikunja/commit/f2e02c7fb327555f82808ab6a960b1cb2b071065) fix ### 📊 Changes **4 files changed** (+64 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `pkg/cmd/healthcheck.go` (+5 -20) ➕ `pkg/health/health.go` (+46 -0) 📝 `pkg/routes/healthcheck.go` (+5 -0) 📝 `pkg/webtests/healthcheck_test.go` (+8 -1) </details> ### 📄 Description ## Summary - add a `health.Check` helper to verify DB and redis connections - use `health.Check` in `/health` route - call `health.Check` from the `healthcheck` command - update tests for the new shared behaviour - reuse an existing DB session in `health.Check` ## Testing - `mage lint:fix` - `mage test:web` ------ https://chatgpt.com/codex/tasks/task_e_6863c981236c8322b1e9ae66336f084b --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-01 21:13:17 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/caldav
area/filters
area/frontend
area/gantt
area/internal-code
area/typesense
bug
changes requested
confirmed
dependencies
enhancement
good first issue
help wanted
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#1207
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?