github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2025-12-05 19:16:51 -06:00
Code Issues 219 Packages Projects Releases 2 Wiki Activity

[PR #932] [MERGED] fix: close modals by pressing escape #1073

New Issue
Closed
opened 2025-11-01 21:10:27 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-01 21:10:27 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/932
Author: @kolaente
Created: 6/12/2025
Status: ✅ Merged
Merged: 6/12/2025
Merged by: @kolaente

Base: main ← Head: codex/close-modal-on-escape-key-press

📝 Commits (3)

📊 Changes

1 file changed (+25 additions, -3 deletions)

View changed files

📝 frontend/src/components/misc/Modal.vue (+25 -3)

📄 Description

Resolves https://github.com/go-vikunja/vikunja/issues/276

Summary

  • allow closing modal dialogs when pressing Escape
  • keep event listener active even when an input has focus
  • avoid attaching duplicate Escape handlers

Testing

  • mage lint:fix
  • pnpm lint:fix (fails: pnpm not installed)

https://chatgpt.com/codex/tasks/task_e_6849dc07337c83229bc9b8f48b55c8ce

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/932 **Author:** [@kolaente](https://github.com/kolaente) **Created:** 6/12/2025 **Status:** ✅ Merged **Merged:** 6/12/2025 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `codex/close-modal-on-escape-key-press` --- ### 📝 Commits (3) - [`fbf39a1`](https://github.com/go-vikunja/vikunja/commit/fbf39a1b8010142ba80ce741136ec6d375b0b136) fix(frontend): prevent duplicate escape listeners - [`f70a37a`](https://github.com/go-vikunja/vikunja/commit/f70a37a4ec2e618f6cbe244e6e0b2ed53221d3d5) fix: formatting - [`e4200fc`](https://github.com/go-vikunja/vikunja/commit/e4200fc46625950f0e8fe734041a4802f0fc0dc6) cleanup ### 📊 Changes **1 file changed** (+25 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/components/misc/Modal.vue` (+25 -3) </details> ### 📄 Description Resolves https://github.com/go-vikunja/vikunja/issues/276 ## Summary - allow closing modal dialogs when pressing Escape - keep event listener active even when an input has focus - avoid attaching duplicate Escape handlers ## Testing - `mage lint:fix` - `pnpm lint:fix` *(fails: pnpm not installed)* ------ https://chatgpt.com/codex/tasks/task_e_6849dc07337c83229bc9b8f48b55c8ce --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the
pull-request
 label 2025-11-01 21:10:27 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/caldav
area/filters
area/frontend
area/gantt
area/internal-code
area/typesense
bug
changes requested
confirmed
dependencies
enhancement
good first issue
help wanted
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
question
security
support
upstream issue
waiting for reply
wontfix
No Label
pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#1073
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?