github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-04-28 18:38:24 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

fix(migration): do not fail when an attachment is too large

Browse Source 
Resolves https://vikunja.sentry.io/issues/6389417364/events/d79bdea146b54a9dace8c81e3f787975/
This commit is contained in:
kolaente
2025-03-21 18:03:27 +01:00
parent 23d2814b94
commit d522d40773
2 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/modules/migration/create_from_structure.go
View File

@@ -382,6 +382,10 @@ func createProjectWithEverything(s *xorm.Session, project *models.ProjectWithTas
fr := io.NopCloser(bytes.NewReader(a.File.FileContent))
err = a.NewAttachment(s, fr, a.File.Name, a.File.Size, user)
if err != nil {
if models.IsErrTaskAttachmentIsTooLarge(err) {
log.Warningf("[creating structure] Attachment %s is too large (%d bytes), skipping: %v", a.File.Name, a.File.Size, err)
continue
}
return
}
log.Debugf("[creating structure] Created new attachment %d", a.ID)

6
pkg/modules/migration/vikunja-file/vikunja.go
View File

@@ -267,11 +267,13 @@ func addDetailsToProject(l *models.ProjectWithTasksAndBuckets, storedFiles map[i
}
af, err := attachmentFile.Open()
if err != nil {
return fmt.Errorf("could not open attachment %d for reading: %w", attachment.ID, err)
log.Warningf(logPrefix+"Could not open attachment %d for reading: %v, skipping", attachment.ID, err)
continue
}
var buf bytes.Buffer
if _, err := buf.ReadFrom(af); err != nil {
return fmt.Errorf("could not read attachment %d: %w", attachment.ID, err)
log.Warningf(logPrefix+"Could not read attachment %d: %v, skipping", attachment.ID, err)
continue
}
attachment.ID = 0