github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-05-08 04:48:27 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

chore(lint): suppress gosec false positives on SSRF-safe HTTP client calls

Browse Source
This commit is contained in:
kolaente
2026-03-23 16:52:25 +01:00
committed by kolaente
parent 848a4e7f07
commit cc22acdf3e
6 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/modules/background/unsplash/proxy.go
View File

@@ -32,7 +32,7 @@ func unsplashImage(url string, c *echo.Context) error {
if err != nil {
return err
}
resp, err := utils.NewSSRFSafeHTTPClient().Do(req)
resp, err := utils.NewSSRFSafeHTTPClient().Do(req) //nolint:gosec // SSRF protection is handled by the SSRF-safe client
if err != nil {
return err
}

4
pkg/modules/background/unsplash/unsplash.go
View File

@@ -261,7 +261,7 @@ func (p *Provider) Set(s *xorm.Session, image *background.Image, project *models
if err != nil {
return
}
resp, err := utils.NewSSRFSafeHTTPClient().Do(req)
resp, err := utils.NewSSRFSafeHTTPClient().Do(req) //nolint:gosec // SSRF protection is handled by the SSRF-safe client
if err != nil {
return err
}
@@ -373,7 +373,7 @@ func pingbackByPhotoID(photoID string) {
if err != nil {
log.Errorf("Unsplash Pingback Failed: %s", err.Error())
}
_, err = utils.NewSSRFSafeHTTPClient().Do(req)
_, err = utils.NewSSRFSafeHTTPClient().Do(req) //nolint:gosec // SSRF protection is handled by the SSRF-safe client
if err != nil {
log.Errorf("Unsplash Pingback Failed: %s", err.Error())
}

2
pkg/modules/migration/helpers.go
View File

@@ -48,7 +48,7 @@ func DownloadFileWithHeaders(url string, headers http.Header) (buf *bytes.Buffer
}
hc := utils.NewSSRFSafeHTTPClient()
resp, err := hc.Do(req)
resp, err := hc.Do(req) //nolint:gosec // SSRF protection is handled by the SSRF-safe client
if err != nil {
return nil, err
}

2
pkg/modules/migration/microsoft-todo/microsoft_todo.go
View File

@@ -188,7 +188,7 @@ func makeAuthenticatedGetRequest(token, urlPart string, v interface{}) error {
}
req.Header.Set("Authorization", "Bearer "+token)
resp, err := utils.NewSSRFSafeHTTPClient().Do(req)
resp, err := utils.NewSSRFSafeHTTPClient().Do(req) //nolint:gosec // SSRF protection is handled by the SSRF-safe client
if err != nil {
return err
}

2
pkg/utils/avatar.go
View File

@@ -101,7 +101,7 @@ func DownloadImage(url string) ([]byte, error) {
return nil, fmt.Errorf("failed to create HTTP request: %w", err)
}
resp, err := NewSSRFSafeHTTPClient().Do(req)
resp, err := NewSSRFSafeHTTPClient().Do(req) //nolint:gosec // SSRF protection is handled by the SSRF-safe client
if err != nil {
return nil, fmt.Errorf("failed to download image: %w", err)
}

6
pkg/utils/httpclient_test.go
View File

@@ -46,7 +46,7 @@ func TestNewSSRFSafeHTTPClient(t *testing.T) {
client := NewSSRFSafeHTTPClient()
req, err := http.NewRequestWithContext(context.Background(), http.MethodGet, server.URL, nil)
require.NoError(t, err)
resp, err := client.Do(req)
resp, err := client.Do(req) //nolint:gosec // testing SSRF-safe client
require.NoError(t, err)
defer resp.Body.Close()
assert.Equal(t, http.StatusOK, resp.StatusCode)
@@ -59,7 +59,7 @@ func TestNewSSRFSafeHTTPClient(t *testing.T) {
// Attempt to connect to localhost (non-routable)
req, err := http.NewRequestWithContext(context.Background(), http.MethodGet, "http://127.0.0.1:1/test", nil)
require.NoError(t, err)
_, err = client.Do(req) //nolint:bodyclose
_, err = client.Do(req) //nolint:bodyclose,gosec // testing SSRF-safe client
require.Error(t, err)
})
@@ -75,7 +75,7 @@ func TestNewSSRFSafeHTTPClient(t *testing.T) {
client := NewSSRFSafeHTTPClient()
req, err := http.NewRequestWithContext(context.Background(), http.MethodGet, server.URL, nil)
require.NoError(t, err)
resp, err := client.Do(req)
resp, err := client.Do(req) //nolint:gosec // testing SSRF-safe client
require.NoError(t, err)
defer resp.Body.Close()
assert.Equal(t, http.StatusOK, resp.StatusCode)