github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-05-08 21:08:04 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

test: assert position existence instead of conditional skip

Browse Source 
Replace if-exists guard with require.True assertion so a
missing position correctly fails the test.
This commit is contained in:
kolaente
2026-04-03 19:18:41 +02:00
committed by kolaente
parent ce3e56f192
commit a628c99006
1 changed files with 31 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

61
pkg/models/task_position_test.go
View File

@@ -511,38 +511,39 @@ func TestSetTaskInBucketInViewsResolvesConflicts(t *testing.T) {
Get(lowestPosition)
require.NoError(t, err)
if exists && lowestPosition.Position >= MinPositionSpacing {
predictedPosition := lowestPosition.Position / 2
require.True(t, exists)
require.GreaterOrEqual(t, lowestPosition.Position, MinPositionSpacing)
// Insert a conflicting position at the predicted value
_, err = s.Insert(&TaskPosition{
TaskID: 999,
ProjectViewID: view.ID,
Position: predictedPosition,
})
require.NoError(t, err)
predictedPosition := lowestPosition.Position / 2
// Now create positions as task creation would
newPos := &TaskPosition{
TaskID: 998,
ProjectViewID: view.ID,
Position: predictedPosition,
}
_, err = s.Insert(newPos)
require.NoError(t, err)
// Insert a conflicting position at the predicted value
_, err = s.Insert(&TaskPosition{
TaskID: 999,
ProjectViewID: view.ID,
Position: predictedPosition,
})
require.NoError(t, err)
// Resolve conflicts
err = resolvePositionConflictsAfterInsert(s, []*TaskPosition{newPos})
require.NoError(t, err)
// Verify they have different positions
var p1, p2 TaskPosition
_, err = s.Where("task_id = ? AND project_view_id = ?", 999, view.ID).Get(&p1)
require.NoError(t, err)
_, err = s.Where("task_id = ? AND project_view_id = ?", 998, view.ID).Get(&p2)
require.NoError(t, err)
assert.NotEqual(t, p1.Position, p2.Position,
"Positions should be unique after conflict resolution")
// Now create positions as task creation would
newPos := &TaskPosition{
TaskID: 998,
ProjectViewID: view.ID,
Position: predictedPosition,
}
_, err = s.Insert(newPos)
require.NoError(t, err)
// Resolve conflicts
err = resolvePositionConflictsAfterInsert(s, []*TaskPosition{newPos})
require.NoError(t, err)
// Verify they have different positions
var p1, p2 TaskPosition
_, err = s.Where("task_id = ? AND project_view_id = ?", 999, view.ID).Get(&p1)
require.NoError(t, err)
_, err = s.Where("task_id = ? AND project_view_id = ?", 998, view.ID).Get(&p2)
require.NoError(t, err)
assert.NotEqual(t, p1.Position, p2.Position,
"Positions should be unique after conflict resolution")
}