github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-03-11 17:48:44 -05:00
Code Issues 219 Packages Projects Releases 2 Wiki Activity

fix: remove debug log statements from task duplicate

Browse Source 
Remove all log.Debugf calls from the Create method as they were
leftover development aids and should not be in production code.
This commit is contained in:
kolaente
2026-03-04 16:51:56 +01:00
parent 6c9407c58f
commit 6da0f68562
1 changed files with 1 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
pkg/models/task_duplicate.go
View File

@@ -18,7 +18,6 @@ package models
import (
"code.vikunja.io/api/pkg/files"
"code.vikunja.io/api/pkg/log"
"code.vikunja.io/api/pkg/web"
"xorm.io/xorm"
@@ -70,8 +69,6 @@ func (td *TaskDuplicate) Create(s *xorm.Session, doer web.Auth) (err error) {
return err
}
log.Debugf("Duplicating task %d", td.TaskID)
// Create the new task
newTask := &Task{
Title: originalTask.Title,
@@ -95,8 +92,6 @@ func (td *TaskDuplicate) Create(s *xorm.Session, doer web.Auth) (err error) {
return err
}
log.Debugf("Duplicated task %d into new task %d", td.TaskID, newTask.ID)
// Duplicate labels
labelTasks := []*LabelTask{}
err = s.Where("task_id = ?", td.TaskID).Find(&labelTasks)
@@ -111,8 +106,6 @@ func (td *TaskDuplicate) Create(s *xorm.Session, doer web.Auth) (err error) {
}
}
log.Debugf("Duplicated labels from task %d into %d", td.TaskID, newTask.ID)
// Duplicate attachments (copy underlying files)
attachments, err := getTaskAttachmentsByTaskIDs(s, []int64{td.TaskID})
if err != nil {
@@ -124,8 +117,7 @@ func (td *TaskDuplicate) Create(s *xorm.Session, doer web.Auth) (err error) {
attachment.File = &files.File{ID: attachment.FileID}
if err := attachment.File.LoadFileMetaByID(); err != nil {
if files.IsErrFileDoesNotExist(err) {
log.Debugf("Not duplicating attachment (file %d) because it does not exist", attachment.FileID)
continue
continue
}
return err
}
@@ -142,8 +134,6 @@ func (td *TaskDuplicate) Create(s *xorm.Session, doer web.Auth) (err error) {
}
}
log.Debugf("Duplicated attachments from task %d into %d", td.TaskID, newTask.ID)
// Create "copied from/to" relation
rel := &TaskRelation{
TaskID: newTask.ID,
@@ -164,8 +154,6 @@ func (td *TaskDuplicate) Create(s *xorm.Session, doer web.Auth) (err error) {
return err
}
log.Debugf("Created copy relations between task %d and %d", td.TaskID, newTask.ID)
// Re-read the task to populate all fields for the response
td.Task = newTask
return td.Task.ReadOne(s, doer)