github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-11-09 00:22:38 -06:00
Code Issues 690 Packages Projects Releases 13 Wiki Activity

fix(unsplash): close pingback response body

Browse Source 
The pingback discarded the response, leaking the body and its
connection on every pingback.
This commit is contained in:
kolaente
2026-10-19 14:50:05 +02:00
parent 812520d4de
commit 12ed4036c8
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/modules/background/unsplash/unsplash.go
+4 -1
View File
@@ -380,9 +380,12 @@ func pingbackByPhotoID(photoID string) {
if err != nil {
log.Errorf("Unsplash Pingback Failed: %s", err.Error())
}
_, err = utils.NewSSRFSafeHTTPClient().Do(req) //nolint:gosec // SSRF protection is handled by the SSRF-safe client
resp, err := utils.NewSSRFSafeHTTPClient().Do(req) //nolint:gosec // SSRF protection is handled by the SSRF-safe client
if err != nil {
log.Errorf("Unsplash Pingback Failed: %s", err.Error())
} else {
_, _ = io.Copy(io.Discard, resp.Body)
_ = resp.Body.Close()
}
log.Debugf("Pinged unsplash for photo %s", photoID)
}