mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2026-05-24 17:12:43 -05:00
Favorites are tracked at cipher level rather than on a per-user basis #629
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/vaultwarden#629
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @jjlin on GitHub (Mar 1, 2020).
Currently, whether a cipher is a "favorite" is a property of the cipher itself, but it should probably be tracked similarly to folders, with a separate "favorites" table that maps users to ciphers. Otherwise, for a shared cipher, when one user sets a cipher as a "favorite", it automatically becomes every other user's favorite too, which probably isn't the intended behavior.
Also, when changing the "favorite" property, the cipher update time probably shouldn't be updated (similar to #884).