[PR #639] [MERGED] Change CORS headers #2631

New Issue

Closed

opened 2025-11-07 07:49:33 -06:00 by GiteaMirror · 0 comments

GiteaMirror commented 2025-11-07 07:49:33 -06:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/639
Author: @vplme
Created: 10/1/2019
Status: ✅ Merged
Merged: 10/5/2019
Merged by: @dani-garcia

Base: master ← Head: cors-update

---

📝 Commits (1)

• 7b1da52 Change CORS headers

📊 Changes

1 file changed (+12 additions, -9 deletions)

View changed files

📝 src/util.rs (+12 -9)

📄 Description

All CORS header used to be added always even when that was not necessary.
Changed to only add Allow-Origin to all requests and move the others to preflight OPTIONS request.

Extension sends the request with file:// Origin. This seems to cause problems.
If Origin is file:// change it to the wildcard.

This seems to correspond with the responses from the official API.

Before merging

• Confirmation of fix from other Safari 13 extension user

Fixes #629

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/639 **Author:** [@vplme](https://github.com/vplme) **Created:** 10/1/2019 **Status:** ✅ Merged **Merged:** 10/5/2019 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `master` ← **Head:** `cors-update` --- ### 📝 Commits (1) - [`7b1da52`](https://github.com/dani-garcia/vaultwarden/commit/7b1da527a6dfd453a3d3d16ef2acd64565107991) Change CORS headers ### 📊 Changes **1 file changed** (+12 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `src/util.rs` (+12 -9) </details> ### 📄 Description All CORS header used to be added always even when that was not necessary. Changed to only add Allow-Origin to all requests and move the others to preflight OPTIONS request. Extension sends the request with `file://` Origin. This seems to cause problems. If Origin is `file://` change it to the wildcard. This seems to correspond with the responses from the official API. Before merging - [x] Confirmation of fix from other Safari 13 extension user Fixes #629 --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

GiteaMirror added the pull-request label 2025-11-07 07:49:33 -06:00

GiteaMirror closed this issue 2025-11-07 07:49:33 -06:00

GiteaMirror referenced this issue 2025-11-07 08:00:17 -06:00

[PR #2631] [MERGED] Fix persistent folder check within containers #2987

GiteaMirror referenced this issue 2026-03-07 21:04:40 -06:00

[PR #2631] [MERGED] Fix persistent folder check within containers #6764

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

cached-config-operations

test_dylint

1.35.4

1.35.3

1.35.2

1.35.1

1.35.0

1.34.3

1.34.2

1.34.1

1.34.0

1.33.2

1.33.1

1.33.0

1.32.7

1.32.6

1.32.5

1.32.4

1.32.3

1.32.2

1.32.1

1.32.0

1.31.0

1.30.5

1.30.4

1.30.3

1.30.2

1.30.1

1.30.0

1.29.2

1.29.1

1.29.0

1.28.1

1.28.0

1.27.0

1.26.0

1.25.2

1.25.1

1.25.0

1.24.0

1.23.1

1.23.0

1.22.2

1.22.1

1.22.0

1.21.0

1.20.0

1.19.0

1.18.0

1.17.0

1.16.3

1.16.2

1.16.1

1.16.0

1.15.1

1.15.0

1.14.2

1.14.1

1.14

1.13.1

1.13.0

1.12.0

1.11.0

1.10.0

1.9.1

1.9.0

1.8.0

1.7.0

1.6.1

1.6.0

1.5.0

1.4.0

1.3.0

1.2.0

1.1.0

1.0.0

0.13.0

0.12.0

0.11.0

0.10.0

0.9.0

Labels

Clear labels

better for forum

bug

documentation

duplicate

enhancement

future Vault

good first issue

help wanted

low priority

notes

pull-request

Mirrored from GitHub Pull Request

question

SSO

Third party

troubleshooting

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

GiteaMirror ninjasurge

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/vaultwarden#2631