github-starred/vaultwarden
2
0
Fork 0
mirror of https://github.com/dani-garcia/vaultwarden.git synced 2026-08-27 05:35:03 -05:00
Code Issues 534 Packages Projects Releases 86 Wiki Activity

Parse bool values correctly #571

New Issue
Closed
opened 2025-11-07 06:41:36 -06:00 by GiteaMirror · 2 comments
GiteaMirror commented 2025-11-07 06:41:36 -06:00
Owner
Copy Link
Copy Source

Originally created by @xoxys on GitHub (Jan 18, 2020).

Currently, uppercase bool values seems not to work e.g. SIGNUPS_ALLOWED=False which is really confusing and can lead to missconfigured public servers.

Normally, most common bool-ish string values like 1,0/yes,no/y,n/true,false/True,False should be converted to a real bool while reading env variables.

Originally created by @xoxys on GitHub (Jan 18, 2020). Currently, uppercase bool values seems not to work e.g. `SIGNUPS_ALLOWED=False` which is really confusing and can lead to missconfigured public servers. Normally, most common bool-ish string values like `1,0/yes,no/y,n/true,false/True,False` should be converted to a real bool while reading env variables.
GiteaMirror commented 2025-11-07 06:41:37 -06:00
Author
Owner
Copy Link
Copy Source

@dani-garcia commented on GitHub (Jan 20, 2020):

Should be fixed in https://github.com/dani-garcia/bitwarden_rs/commit/d212dfe735e59128667a4c579e52ce7e86b53a94 now.

@dani-garcia commented on GitHub (Jan 20, 2020): Should be fixed in https://github.com/dani-garcia/bitwarden_rs/commit/d212dfe735e59128667a4c579e52ce7e86b53a94 now.
GiteaMirror commented 2025-11-07 06:41:37 -06:00
Author
Owner
Copy Link
Copy Source

@xoxys commented on GitHub (Jan 20, 2020):

Cool, looks nice. Thanks for the fast fix.

@xoxys commented on GitHub (Jan 20, 2020): Cool, looks nice. Thanks for the fast fix.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
better for forum
bug
documentation
duplicate
enhancement
future Vault
good first issue
help wanted
low priority
notes
pull-request
Mirrored from GitHub Pull Request
 question
SSO
Third party
troubleshooting
wontfix
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vaultwarden#571