Currently It looks like that my bitwarden_rs installation is not able to fetch icons, because it runs inside a restrictive network.
Outgoing connections are not allowed, only via an normal proxy.
For that I tried to set these environment variables for the docker container:
[2019-08-11 08:31:24][rocket::rocket][INFO] GET /icons/accounts.autodesk.com/icon.png image/png:
[2019-08-11 08:31:24][_][INFO] Matched: GET /icons/<domain>/icon.png (icon)
[2019-08-11 08:31:39][bitwarden_rs::api::icons][INFO] Download failed for https://accounts.autodesk.com/favicon.ico
[2019-08-11 08:31:39][bitwarden_rs::api::icons][ERROR] Error downloading icon: Empty response. Empty response
thread '<unnamed>' panicked at 'Error creating negative cache marker: Os { code: 2, kind: NotFound, message: "No such file or directory" }', src/libcore/result.rs:1051:5
I have seen that the rust lib https://github.com/seanmonstar/reqwest/releases added the support for use of system proxy in the latest release, and that you are already using it.
But I do not know how much work it would be to activate the feature inside the code.
Originally created by @kTitan on GitHub (Aug 12, 2019).
Original GitHub issue: https://github.com/dani-garcia/vaultwarden/issues/570
Currently It looks like that my bitwarden_rs installation is not able to fetch icons, because it runs inside a restrictive network.
Outgoing connections are not allowed, only via an normal proxy.
For that I tried to set these environment variables for the docker container:
```
http_proxy: 'http://proxy:8888/'
https_proxy: 'http://proxy:8888/'
```
But after that I still get these errors:
```
[2019-08-11 08:31:24][rocket::rocket][INFO] GET /icons/accounts.autodesk.com/icon.png image/png:
[2019-08-11 08:31:24][_][INFO] Matched: GET /icons/<domain>/icon.png (icon)
[2019-08-11 08:31:39][bitwarden_rs::api::icons][INFO] Download failed for https://accounts.autodesk.com/favicon.ico
[2019-08-11 08:31:39][bitwarden_rs::api::icons][ERROR] Error downloading icon: Empty response. Empty response
thread '<unnamed>' panicked at 'Error creating negative cache marker: Os { code: 2, kind: NotFound, message: "No such file or directory" }', src/libcore/result.rs:1051:5
```
I have seen that the rust lib https://github.com/seanmonstar/reqwest/releases added the support for use of system proxy in the latest release, and that you are already using it.
But I do not know how much work it would be to activate the feature inside the code.
@kTitan I have created a pull-request for this feature. It was a small update.
I tested it and works as it should.
<!-- gh-comment-id:520473316 -->
@BlackDex commented on GitHub (Aug 12, 2019):
@kTitan I have created a pull-request for this feature. It was a small update.
I tested it and works as it should.
@BlackDex thanks for this quick pull request.
I just have seen that the hibp_breach function is also not working, because it also needs the proxy.
Could you add it there also? If you want I can also open an new issue for that.
<!-- gh-comment-id:520521185 -->
@kTitan commented on GitHub (Aug 12, 2019):
@BlackDex thanks for this quick pull request.
I just have seen that the `hibp_breach` function is also not working, because it also needs the proxy.
Could you add it there also? If you want I can also open an new issue for that.
@kTitan There are some more locations where this could be needed.
the DUO auth is something i can see quicly.
<!-- gh-comment-id:520724168 -->
@BlackDex commented on GitHub (Aug 13, 2019):
@kTitan There are some more locations where this could be needed.
the DUO auth is something i can see quicly.
Maybe it is better for this to wait for the updated reqwest module, since that will enable the use_sys_proxy by default. But that will only be by default in the 0.10 version and currently it is at 0.9
<!-- gh-comment-id:520727089 -->
@BlackDex commented on GitHub (Aug 13, 2019):
Maybe it is better for this to wait for the updated reqwest module, since that will enable the use_sys_proxy by default. But that will only be by default in the 0.10 version and currently it is at 0.9
But there is no release date scheduled for the 0.10 version if it, as far as I can see. So it will perhaps takes months/years :/
<!-- gh-comment-id:520861244 -->
@kTitan commented on GitHub (Aug 13, 2019):
But there is no release date scheduled for the 0.10 version if it, as far as I can see. So it will perhaps takes months/years :/
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Originally created by @kTitan on GitHub (Aug 12, 2019).
Original GitHub issue: https://github.com/dani-garcia/vaultwarden/issues/570
Currently It looks like that my bitwarden_rs installation is not able to fetch icons, because it runs inside a restrictive network.
Outgoing connections are not allowed, only via an normal proxy.
For that I tried to set these environment variables for the docker container:
But after that I still get these errors:
I have seen that the rust lib https://github.com/seanmonstar/reqwest/releases added the support for use of system proxy in the latest release, and that you are already using it.
But I do not know how much work it would be to activate the feature inside the code.
@BlackDex commented on GitHub (Aug 12, 2019):
@kTitan I have created a pull-request for this feature. It was a small update.
I tested it and works as it should.
@kTitan commented on GitHub (Aug 12, 2019):
@BlackDex thanks for this quick pull request.
I just have seen that the
hibp_breachfunction is also not working, because it also needs the proxy.Could you add it there also? If you want I can also open an new issue for that.
@BlackDex commented on GitHub (Aug 13, 2019):
@kTitan There are some more locations where this could be needed.
the DUO auth is something i can see quicly.
@BlackDex commented on GitHub (Aug 13, 2019):
Maybe it is better for this to wait for the updated reqwest module, since that will enable the use_sys_proxy by default. But that will only be by default in the 0.10 version and currently it is at 0.9
@kTitan commented on GitHub (Aug 13, 2019):
But there is no release date scheduled for the 0.10 version if it, as far as I can see. So it will perhaps takes months/years :/
@mprasil commented on GitHub (Aug 20, 2019):
#571 was now merged, so this should be resolved.