[GH-ISSUE #885] Favorites are tracked at cipher level rather than on a per-user basis #28119

New Issue

GiteaMirror · 2026-06-17T07:39:30-05:00

GiteaMirror commented

2026-06-17 07:39:30 -05:00

Originally created by @jjlin on GitHub (Mar 1, 2020).
Original GitHub issue: https://github.com/dani-garcia/vaultwarden/issues/885

Currently, whether a cipher is a "favorite" is a property of the cipher itself, but it should probably be tracked similarly to folders, with a separate "favorites" table that maps users to ciphers. Otherwise, for a shared cipher, when one user sets a cipher as a "favorite", it automatically becomes every other user's favorite too, which probably isn't the intended behavior.

Also, when changing the "favorite" property, the cipher update time probably shouldn't be updated (similar to #884).

Originally created by @jjlin on GitHub (Mar 1, 2020). Original GitHub issue: https://github.com/dani-garcia/vaultwarden/issues/885 Currently, whether a cipher is a "favorite" is a property of the cipher itself, but it should probably be tracked similarly to folders, with a separate "favorites" table that maps users to ciphers. Otherwise, for a shared cipher, when one user sets a cipher as a "favorite", it automatically becomes every other user's favorite too, which probably isn't the intended behavior. Also, when changing the "favorite" property, the cipher update time probably shouldn't be updated (similar to #884).

GiteaMirror closed this issue

2026-06-17 07:39:31 -05:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/vaultwarden#28119