github-starred/pangolin
2
0
Fork 0
mirror of https://github.com/fosrl/pangolin.git synced 2026-05-23 18:41:42 -05:00
Code Issues 959 Packages Projects Releases 74 Wiki Activity

[PR #2833] [CLOSED] 2736 fix healthcheck on disabled resources #7982

New Issue
Closed
opened 2026-04-25 16:31:47 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-25 16:31:47 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/fosrl/pangolin/pull/2833
Author: @rkvf01
Created: 4/11/2026
Status: ❌ Closed

Base: dev ← Head: 2736-fix-healthcheck

📝 Commits (3)

  • e397a64 fix healthchecks on disabled resource #2736
  • 7883487 Add a comment on the new function syncNewtsForResource
  • 0ecfb44 Merge from dev

📊 Changes

2 files changed (+57 additions, -2 deletions)

View changed files

📝 server/routers/newt/buildConfiguration.ts (+7 -1)
📝 server/routers/resource/updateResource.ts (+50 -1)

📄 Description

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Description

  • server/routers/newt/buildConfiguration.ts : Added checks to query now filters on resources.enabled as well as targets.enabled
  • server/routers/resource/updateResource.ts : Added syncNewtsForResource() to push an immediate sync to connected Newt clients when a resource is enabled or disabled.

How to test?

Added a test
repro-2736.ts

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fosrl/pangolin/pull/2833 **Author:** [@rkvf01](https://github.com/rkvf01) **Created:** 4/11/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `2736-fix-healthcheck` --- ### 📝 Commits (3) - [`e397a64`](https://github.com/fosrl/pangolin/commit/e397a6432ef151dc5723316344aa9fdefc1c3a8d) fix healthchecks on disabled resource #2736 - [`7883487`](https://github.com/fosrl/pangolin/commit/788348705fed52376a3aa557fe2940ee7ef5f391) Add a comment on the new function syncNewtsForResource - [`0ecfb44`](https://github.com/fosrl/pangolin/commit/0ecfb4483c33aac78ed751c8008246ed79f9d7a6) Merge from dev ### 📊 Changes **2 files changed** (+57 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `server/routers/newt/buildConfiguration.ts` (+7 -1) 📝 `server/routers/resource/updateResource.ts` (+50 -1) </details> ### 📄 Description ## Community Contribution License Agreement By creating this pull request, I grant the project maintainers an unlimited, perpetual license to use, modify, and redistribute these contributions under any terms they choose, including both the AGPLv3 and the Fossorial Commercial license terms. I represent that I have the right to grant this license for all contributed content. ## Description - server/routers/newt/buildConfiguration.ts : Added checks to query now filters on resources.enabled as well as targets.enabled - server/routers/resource/updateResource.ts : Added syncNewtsForResource() to push an immediate sync to connected Newt clients when a resource is enabled or disabled. ## How to test? Added a test [repro-2736.ts](https://github.com/user-attachments/files/26648442/repro-2736.ts) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-25 16:31:47 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
authentication
bug
config
dependencies
docker
documentation
enhancement
good first issue
help wanted
Improvement
Look Into
needs investigating
networking
new feature
non-critical bug
potential bug
pull-request
Mirrored from GitHub Pull Request
 question
reverse proxy
Security
stale
ui
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/pangolin#7982
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?