[PR #2034] [MERGED] refactor: Update <DomainPicker /> to accept default values #2833

New Issue

GiteaMirror · 2026-04-16T09:38:02-05:00

GiteaMirror commented

2026-04-16 09:38:02 -05:00

📋 Pull Request Information

Original PR: https://github.com/fosrl/pangolin/pull/2034
Author: @Fredkiss3
Created: 12/10/2025
Status: ✅ Merged
Merged: 12/17/2025
Merged by: @miloschwartz

Base: dev ← Head: refactor/domain-picker-default-value

📝 Commits (10+)

fbd3802 ♻️ Update domain picker component to accept default values
de684b2 🔇 remove console.log
aab0471 🏷️ fix typescript errors
6fc54bc ♻️ set default value on domain picker modal in proxy resource page
e02fa7c ♻️ pass the default domainId instead of the base domain
fccff9c Merge branch 'dev' into refactor/domain-picker-default-value
c98d61a ♻️ pass default value to domain picker
b133593 🚸 now the domain picker is deterministic
3ad4a76 ♻️ pass default subdomain value to org auth page settings
d3d5a1c 🚸 trigger null domain change if the user switches from another domain type to free domain option to prevent the modal from registering it as a valid value

📊 Changes

5 files changed (+266 additions, -221 deletions)

View changed files

📝 src/app/[orgId]/settings/resources/proxy/[niceId]/general/page.tsx (+30 -8)
📝 src/app/[orgId]/settings/resources/proxy/create/page.tsx (+2 -0)
📝 src/components/DomainPicker.tsx (+205 -207)
📝 src/components/private/AuthPageSettings.tsx (+17 -6)
📝 src/lib/queries.ts (+12 -0)

📄 Description

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Description

In this PR, I updated the domain picker component to accept default subdomain & base Domain props.
Also updated the fetch logic (fetch domains) to use react query instead.
Also fixed a typescript error introduced in c56574e431
I also made it so that the default value of subdomain and base domains are passed to the domain picker component in the proxy resource page.

screenshots

Video

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/fosrl/pangolin/pull/2034 **Author:** [@Fredkiss3](https://github.com/Fredkiss3) **Created:** 12/10/2025 **Status:** ✅ Merged **Merged:** 12/17/2025 **Merged by:** [@miloschwartz](https://github.com/miloschwartz) **Base:** `dev` ← **Head:** `refactor/domain-picker-default-value` --- ### 📝 Commits (10+) - [`fbd3802`](https://github.com/fosrl/pangolin/commit/fbd3802e468c5220b67edcd9d880968b4e9fb2ba) ♻️ Update domain picker component to accept default values - [`de684b2`](https://github.com/fosrl/pangolin/commit/de684b212fbe3cbca259781f2d09a429b506261b) 🔇 remove console.log - [`aab0471`](https://github.com/fosrl/pangolin/commit/aab0471b6b23e0205feb5144e0ea8a1070ead0c7) 🏷️ fix typescript errors - [`6fc54bc`](https://github.com/fosrl/pangolin/commit/6fc54bcc9e20a337ee856a8a1bdb72521d338621) ♻️ set default value on domain picker modal in proxy resource page - [`e02fa7c`](https://github.com/fosrl/pangolin/commit/e02fa7c14889cd3ba5bcc6b19214384a9fcf65cb) ♻️ pass the default domainId instead of the base domain - [`fccff9c`](https://github.com/fosrl/pangolin/commit/fccff9c23a0d10f5c5f21b95f0bc761504d11690) Merge branch 'dev' into refactor/domain-picker-default-value - [`c98d61a`](https://github.com/fosrl/pangolin/commit/c98d61a8fb937c24ec5bf1a6abe3d49d83dd5a23) ♻️ pass default value to domain picker - [`b133593`](https://github.com/fosrl/pangolin/commit/b133593ea2e87b07e7ed7fad333391705c1cad58) 🚸 now the domain picker is deterministic - [`3ad4a76`](https://github.com/fosrl/pangolin/commit/3ad4a76f039bc3372c71f9fe0fb6e0372117306a) ♻️ pass default subdomain value to org auth page settings - [`d3d5a1c`](https://github.com/fosrl/pangolin/commit/d3d5a1c204314c2f25fc85200a0d8b52035c96b7) 🚸 trigger `null` domain change if the user switches from another domain type to `free domain option` to prevent the modal from registering it as a valid value ### 📊 Changes **5 files changed** (+266 additions, -221 deletions) <details> <summary>View changed files</summary> 📝 `src/app/[orgId]/settings/resources/proxy/[niceId]/general/page.tsx` (+30 -8) 📝 `src/app/[orgId]/settings/resources/proxy/create/page.tsx` (+2 -0) 📝 `src/components/DomainPicker.tsx` (+205 -207) 📝 `src/components/private/AuthPageSettings.tsx` (+17 -6) 📝 `src/lib/queries.ts` (+12 -0) </details> ### 📄 Description ## Community Contribution License Agreement By creating this pull request, I grant the project maintainers an unlimited, perpetual license to use, modify, and redistribute these contributions under any terms they choose, including both the AGPLv3 and the Fossorial Commercial license terms. I represent that I have the right to grant this license for all contributed content. ## Description - In this PR, I updated the domain picker component to accept default subdomain & base Domain props. Also updated the fetch logic (fetch domains) to use react query instead. - Also fixed a typescript error introduced in c56574e4315a40afbfc6198fb09a67ce7cefbe05 - I also made it so that the default value of subdomain and base domains are passed to the domain picker component in the proxy resource page. ## screenshots <table> <tr> <td align=center>Video</td> </tr> <tr> <td> <video src="https://github.com/user-attachments/assets/6d373853-3f3c-4d42-aed0-6eb3298a311c"></video> </td> </tr> </table> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-16 09:38:02 -05:00

GiteaMirror closed this issue

2026-04-16 09:38:02 -05:00

GiteaMirror referenced this issue

2026-04-16 09:51:12 -05:00

[PR #2833] [CLOSED] 2736 fix healthcheck on disabled resources #3180

GiteaMirror referenced this issue

2026-04-20 09:16:27 -05:00

[PR #2833] [CLOSED] 2736 fix healthcheck on disabled resources #5123

GiteaMirror referenced this issue

2026-04-25 16:31:47 -05:00

[PR #2833] [CLOSED] 2736 fix healthcheck on disabled resources #7982